Skip to contentSkip to conversation

tc_core: Use double in tc_core_time2tick()

PATCH Applied Jarek Poplawski 1 participant 2 messages Jun 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tc_core: Use double in tc_core_time2tick()

CBQ minidle parameter is provided in microseconds, so needs time2tick conversion.

---

 tc/q_cbq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tc/q_cbq.c +1 -1
index c99dc3b..7f2bd0c 100644
@@ -406,7 +406,7 @@ static int cbq_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str
 		lss.change |= TCF_CBQ_LSS_EWMA|TCF_CBQ_LSS_AVPKT;
 	}
 	if (lss.change&TCF_CBQ_LSS_MINIDLE) {
-		lss.minidle <<= lss.ewma_log;
+		lss.minidle = tc_core_time2tick(lss.minidle << lss.ewma_log);
 		lss.change |= TCF_CBQ_LSS_EWMA;
 	}
 
#1 lore raw

PATCH RESEND 2/2 q_cbq: Fix minidle parameter conversion

Quoted 2 lines · Jarek Poplawski

CBQ minidle parameter is provided in microseconds, so needs time2tick conversion.

Wrong subject, sorry,
Jarek P.
---------------------> take 2 / resend

CBQ minidle parameter is provided in microseconds, so needs time2tick conversion.

---

 tc/q_cbq.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tc/q_cbq.c +1 -1
index c99dc3b..7f2bd0c 100644
@@ -406,7 +406,7 @@ static int cbq_parse_class_opt(struct qdisc_util *qu, int argc, char **argv, str
 		lss.change |= TCF_CBQ_LSS_EWMA|TCF_CBQ_LSS_AVPKT;
 	}
 	if (lss.change&TCF_CBQ_LSS_MINIDLE) {
-		lss.minidle <<= lss.ewma_log;
+		lss.minidle = tc_core_time2tick(lss.minidle << lss.ewma_log);
 		lss.change |= TCF_CBQ_LSS_EWMA;
 	}