Skip to contentSkip to conversation

OCFS2: fdatasync should skip unimportant metadata writeout

PATCH New Hisashi Hifumi 3 participants 3 messages Jun 9, 2009 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OCFS2: fdatasync should skip unimportant metadata writeout

Hi.

In ocfs2, fdatasync and fsync are identical.
I think fdatasync should skip committing transaction when inode->i_state is set just I_DIRTY_SYNC and this indicates only atime or/and mtime updates.
Following patch improves fdatasync throughput.

#sysbench --num-threads=16 --max-requests=300000 --test=fileio --file-block-size=4K --file-total-size=16G --file-test-mode=rndwr --file-fsync-mode=fdatasync run

Results:
-2.6.30-rc8
Test execution summary:
total time: 107.1445s
total number of events: 119559
total time taken by event execution: 116.1050
per-request statistics:
min: 0.0000s
avg: 0.0010s
max: 0.1220s
approx. 95 percentile: 0.0016s

Threads fairness:

    events (avg/stddev):           7472.4375/303.60
    execution time (avg/stddev):   7.2566/0.64

-2.6.30-rc8-patched
Test execution summary:
total time: 86.8529s
total number of events: 300016
total time taken by event execution: 24.3077
per-request statistics:
min: 0.0000s
avg: 0.0001s
max: 0.0336s
approx. 95 percentile: 0.0001s

Threads fairness:

    events (avg/stddev):           18751.0000/718.75
    execution time (avg/stddev):   1.5192/0.05 

Thanks.

fs/ocfs2/file.c +3 -0
diff -Nrup linux-2.6.30-rc8.org/fs/ocfs2/file.c linux-2.6.30-rc8.ocfs2/fs/ocfs2/file.c
@@ -187,6 +187,9 @@ static int ocfs2_sync_file(struct file *
 	if (err)
 		goto bail;
 
+	if (datasync && !(inode->i_state & I_DIRTY_DATASYNC))
+		goto bail;
+
 	journal = osb->journal->j_journal;
 	err = jbd2_journal_force_commit(journal);
 
#1 lore raw

PATCH 1/1 OCFS2: fdatasync should skip unimportant metadata writeout

Quoted 7 lines · Hisashi Hifumi

Hi.

In ocfs2, fdatasync and fsync are identical.
I think fdatasync should skip committing transaction when inode->i_state is set just I_DIRTY_SYNC and this indicates only atime or/and mtime updates.
Following patch improves fdatasync throughput.

That looks great, thanks for the patch Hisashi!

Quoted 1 line
	--Mark

--
Mark Fasheh

#2 lore raw

PATCH 1/1 OCFS2: fdatasync should skip unimportant metadata writeout

In reply to Hisashi Hifumi
Quoted 5 lines · Hisashi Hifumi

In ocfs2, fdatasync and fsync are identical.
I think fdatasync should skip committing transaction when inode->i_state is set just I_DIRTY_SYNC and this indicates only atime or/and mtime updates.
Following patch improves fdatasync throughput.

Nicely done, thanks. This is now in the ocfs2 git tree.

Joel

Signature · 10 lines
"Always give your best, never get discouraged, never be petty; always
 remember, others may hate you.  Those who hate you don't win unless
 you hate them.  And then you destroy yourself."
	- Richard M. Nixon

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127