Skip to contentSkip to conversation

be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()

PATCH Applied Sathya Perla 3 participants 3 messages Jun 10, 2009 – Jun 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()

Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.

---
 drivers/net/benet/be_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/benet/be_main.c +1 -1
index 347d002..69046a1 100644
@@ -1533,7 +1533,7 @@ static int be_close(struct net_device *netdev)
 	struct be_eq_obj *tx_eq = &adapter->tx_eq;
 	int vec;
 
-	cancel_delayed_work(&adapter->work);
+	cancel_delayed_work_sync(&adapter->work);
 
 	netif_stop_queue(netdev);
 	netif_carrier_off(netdev);
Signature · 1 line
1.6.0.4
#1 lore raw

Typo in desctription:

"Use cancel_delayed_work_sycn" -> "Use cancel_delayed_work_sync"

Thanks

Quoted 21 lines

Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.

---
 drivers/net/benet/be_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/benet/be_main.c +1 -1
index 347d002..69046a1 100644
@@ -1533,7 +1533,7 @@ static int be_close(struct net_device *netdev)
 	struct be_eq_obj *tx_eq = &adapter->tx_eq;
 	int vec;
 
-	cancel_delayed_work(&adapter->work);
+	cancel_delayed_work_sync(&adapter->work);
 
 	netif_stop_queue(netdev);
 	netif_carrier_off(netdev);