Skip to contentSkip to conversation

x86, bts: reenable ptrace branch trace support

PATCH In review Markus Metzger 3 participants 9 messages Apr 24, 2009 – Jun 10, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, bts: reenable ptrace branch trace support

The races found by Oleg Nesterov have been fixed.

Reenable branch trace support.

---
arch/x86/Kconfig.cpu | 1 0 + 1 - 0 !

 1 files changed, 1 deletion(-)
arch/x86/Kconfig.cpu +0 -1
Index: b/arch/x86/Kconfig.cpu
===================================================================
@@ -506,7 +506,6 @@ config X86_PTRACE_BTS
 	bool "Branch Trace Store"
 	default y
 	depends on X86_DEBUGCTLMSR
-	depends on BROKEN
 	---help---
 	  This adds a ptrace interface to the hardware's branch trace store.
 

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#1 lore raw
Commit-ID:  7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Gitweb:     http://git.kernel.org/tip/7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Author:     Markus Metzger <[email protected]>
AuthorDate: Fri, 24 Apr 2009 09:44:48 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 24 Apr 2009 10:18:51 +0200

x86, bts: reenable ptrace branch trace support

The races found by Oleg Nesterov have been fixed.

Reenable branch trace support.

LKML-Reference: <[email protected]>

---
 arch/x86/Kconfig.cpu |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/x86/Kconfig.cpu +0 -1
index 8130334..924e156 100644
@@ -506,7 +506,6 @@ config X86_PTRACE_BTS
 	bool "Branch Trace Store"
 	default y
 	depends on X86_DEBUGCTLMSR
-	depends on BROKEN
 	---help---
 	  This adds a ptrace interface to the hardware's branch trace store.
 
#2 lore raw
Quoted 9 lines · tip-bot for Markus Metzger
Commit-ID:  7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Gitweb:     http://git.kernel.org/tip/7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Author:     Markus Metzger <[email protected]>
AuthorDate: Fri, 24 Apr 2009 09:44:48 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 24 Apr 2009 10:18:51 +0200

x86, bts: reenable ptrace branch trace support

Quoted 8 lines

The races found by Oleg Nesterov have been fixed.

Reenable branch trace support.

LKML-Reference: <[email protected]>

OK, this whole BTS thing worries me because it seems to expose too much of the Intel Debug Store thingy to the outside world.

The thing is, once we do PEBS from inside the kernel, we'll have to share the debug store, and the way this thing sets it up isn't really going to work.

So what I'd like to see is having this debug store removed from the interface and abstracted away as cpu resource -- a single page when in use should suffice I think.

If you want to expose a buffer to userspace, use the regular mmap() interface and fill those pages from the DS interrupt handler.

#3 lore raw
Quoted 26 lines · Peter Zijlstra
Quoted 9 lines · tip-bot for Markus Metzger
Commit-ID:  7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Gitweb:     http://git.kernel.org/tip/7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Author:     Markus Metzger <[email protected]>
AuthorDate: Fri, 24 Apr 2009 09:44:48 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 24 Apr 2009 10:18:51 +0200

x86, bts: reenable ptrace branch trace support

Quoted 8 lines

The races found by Oleg Nesterov have been fixed.

Reenable branch trace support.

LKML-Reference: <[email protected]>

OK, this whole BTS thing worries me because it seems to expose too much of the Intel Debug Store thingy to the outside world.

The thing is, once we do PEBS from inside the kernel, we'll have to share the debug store, and the way this thing sets it up isn't really going to work.

Quoted 7 lines

So what I'd like to see is having this debug store removed from the interface and abstracted away as cpu resource -- a single page when in use should suffice I think.

If you want to expose a buffer to userspace, use the regular mmap() interface and fill those pages from the DS interrupt handler.

hm, that makes sense indeed. We are in the merge window now - Markus, what's your suggestion?

Ingo

#4 lore raw
Quoted 41 lines

-----Original Message-----
From: Ingo Molnar [mailto:[email protected]]
Sent: Wednesday, June 10, 2009 2:51 PM
To: Peter Zijlstra
Cc: [email protected]; [email protected]; [email protected]; Metzger, Markus T; [email protected]; [email protected]; [email protected]
Subject: Re: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

Quoted 30 lines · Peter Zijlstra
Quoted 9 lines · tip-bot for Markus Metzger
Commit-ID:  7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Gitweb:     http://git.kernel.org/tip/7e0bfad24d85de7cf2202a7b0ce51de11a077b21
Author:     Markus Metzger <[email protected]>
AuthorDate: Fri, 24 Apr 2009 09:44:48 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 24 Apr 2009 10:18:51 +0200

x86, bts: reenable ptrace branch trace support

Quoted 8 lines

The races found by Oleg Nesterov have been fixed.

Reenable branch trace support.

LKML-Reference: <[email protected]>

OK, this whole BTS thing worries me because it seems to expose too much of the Intel Debug Store thingy to the outside world.

The thing is, once we do PEBS from inside the kernel, we'll have to share the debug store, and the way this thing sets it up isn't really going to work.

So what I'd like to see is having this debug store removed from the interface and abstracted away as cpu resource -- a single page when in use should suffice I think.

Quoted 6 lines
Quoted 3 lines

If you want to expose a buffer to userspace, use the regular mmap() interface and fill those pages from the DS interrupt handler.

hm, that makes sense indeed. We are in the merge window now - Markus, what's your suggestion?

The Debug Store interface is completely in-kernel. It does not expose anything to the outside world.

What we expose is a ptrace interface for branch tracing. That this is built on top of Debug Store is completely hidden. The Debug Store interface may be changed without impacting the user-visible part at any time.

I do think that a ptrace interface makes sense since debuggers are the targeted users for branch tracing.

I don't see why we should not merge the fixes now and then rework the in-kernel parts as needed for supporting PEBS.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#5 lore raw
Quoted 9 lines · Markus T

The Debug Store interface is completely in-kernel. It does not expose anything to the outside world.

What we expose is a ptrace interface for branch tracing. That this is built on top of Debug Store is completely hidden. The Debug Store interface may be changed without impacting the user-visible part at any time.

Quoted 5 lines

I do think that a ptrace interface makes sense since debuggers are the targeted users for branch tracing.

I don't see why we should not merge the fixes now and then rework the in-kernel parts as needed for supporting PEBS.

Ok, so what is all that account_locked_memory() for?

#6 lore raw
Quoted 18 lines

-----Original Message-----
From: Peter Zijlstra [mailto:[email protected]]
Sent: Wednesday, June 10, 2009 3:29 PM
To: Metzger, Markus T
Cc: Ingo Molnar; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

Quoted 9 lines · Markus T

The Debug Store interface is completely in-kernel. It does not expose anything to the outside world.

What we expose is a ptrace interface for branch tracing. That this is built on top of Debug Store is completely hidden. The Debug Store interface may be changed without impacting the user-visible part at any time.

Quoted 7 lines
Quoted 5 lines

I do think that a ptrace interface makes sense since debuggers are the targeted users for branch tracing.

I don't see why we should not merge the fixes now and then rework the in-kernel parts as needed for supporting PEBS.

Ok, so what is all that account_locked_memory() for?

To allow debuggers (users) to decide how much memory they want to spend on branch tracing.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

#7 lore raw
Quoted 21 lines · Markus T
Quoted 21 lines

-----Original Message-----
From: Peter Zijlstra [mailto:[email protected]]
Sent: Wednesday, June 10, 2009 3:29 PM
To: Metzger, Markus T
Cc: Ingo Molnar; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

Quoted 12 lines · Markus T

The Debug Store interface is completely in-kernel. It does not expose anything to the outside world.

What we expose is a ptrace interface for branch tracing. That this is built on top of Debug Store is completely hidden. The Debug Store interface may be changed without impacting the user-visible part at any time.

I do think that a ptrace interface makes sense since debuggers are the targeted users for branch tracing.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

I don't see why we should not merge the fixes now and then rework the in-kernel parts as needed for supporting PEBS.

Ok, so what is all that account_locked_memory() for?

To allow debuggers (users) to decide how much memory they want to spend on branch tracing.

But that is the debug store, right? User visible through some mlock accounting and limit.

Furthermore, it appears there is an interface for setting the size, that's also user visible and not fixable after the fact.

Once you want to multiplex cpu-wide and per task BTS/PEBS contexts, there is no choice but to view the DS as a cpu resource, not a task resource, therefore you cannot specify a size, nor attribute it to specific tasks mm accounting.

#8 lore raw
Quoted 34 lines

-----Original Message-----
From: Peter Zijlstra [mailto:[email protected]]
Sent: Wednesday, June 10, 2009 3:44 PM
To: Metzger, Markus T
Cc: Ingo Molnar; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

Quoted 5 lines · Markus T
Quoted 5 lines

-----Original Message-----
From: Peter Zijlstra [mailto:[email protected]]
Sent: Wednesday, June 10, 2009 3:29 PM
To: Metzger, Markus T
Cc: Ingo Molnar; [email protected]; [email protected]; [email protected];

[email protected];

Quoted 19 lines
Quoted 19 lines

[email protected]; [email protected]
Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

Quoted 14 lines · Markus T

The Debug Store interface is completely in-kernel. It does not expose anything to the outside world.

What we expose is a ptrace interface for branch tracing. That this is built on top of Debug Store is completely hidden. The Debug Store interface may be changed without impacting the user-visible part at any time.

I do think that a ptrace interface makes sense since debuggers are the targeted users for branch tracing.

I don't see why we should not merge the fixes now and then rework the in-kernel parts as needed for supporting PEBS.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Ok, so what is all that account_locked_memory() for?

To allow debuggers (users) to decide how much memory they want to spend on branch tracing.

But that is the debug store, right? User visible through some mlock accounting and limit.

Debug Store is the underlying implementation, that's all.

In the current implementation, we lock the entire buffer. In a future implementation we might not need to lock the entire buffer, any more. The only user-visible effect is that he will get -ENOMEM for bigger buffers than today.

Quoted 2 lines

Furthermore, it appears there is an interface for setting the size, that's also user visible and not fixable after the fact.

I don't see how that differs from setting the initial size.

Quoted 4 lines

Once you want to multiplex cpu-wide and per task BTS/PEBS contexts, there is no choice but to view the DS as a cpu resource, not a task resource, therefore you cannot specify a size, nor attribute it to specific tasks mm accounting.

We can still attach a buffer to a task to hold the branch or pebs trace. When can copy the trace from the limited cpu resource to that per-task buffer when the Debug Store buffer overflows.

The accounting is done to have the tracer, i.e. the debugger, pay for the system resources it uses.
If we later on decide to use a fixed-size statically allocated per-cpu Debug Store buffer, the tracer would no longer need to pay for the locked memory. It would still have to pay for the memory to hold the bigger tracer buffer that the debugger requested.

regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.