xfstests: Gracefully fail aio tests if they weren't built

PATCH In review Eric Sandeen 2 participants 2 messages Jun 10, 2009

lore

Share & tools

lore

Eric Sandeen

author

2009-06-10 17:57 UTC #0 lore raw

PATCH 1/1 xfstests: Gracefully fail aio tests if they weren't built

Gracefully fail aio tests if they weren't built

configure & make succeeds w/o aio headers or libs, so tests should handle that.

Signed-off-by Eric Sandeen <[email protected]>

---

207 +3 -1

index 89f88d0..8e29e90 100755
@@ -47,7 +47,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-dio-extend-stat $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-dio-extend-stat
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

208 +3 -1

index 6043df3..9848f2f 100755
@@ -47,7 +47,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-dio-invalidate-failure  $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-dio-invalidate-failure
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

209 +3 -1

index 8e42fad..57cd429 100755
@@ -47,7 +47,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-dio-invalidate-readahead $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-dio-invalidate-readahead
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

210 +3 -1

index d12be17..8db47b4 100755
@@ -47,7 +47,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-dio-subblock-eof-read $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-dio-subblock-eof-read
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

211 +3 -1

index f7581c2..57ab2b4 100755
@@ -47,7 +47,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

212 +3 -1

index 44a23bf..f3e62ac 100755
@@ -48,7 +48,9 @@ _supported_fs generic
 _supported_os Linux
 
 rm -f $TEST_DIR/aio-testfile
-src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer $TEST_DIR/aio-testfile 2>&1
+AIO_TEST=src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer
+[ -x $AIO_TEST ] || _notrun "$AIO_TEST not built"
+$AIO_TEST $TEST_DIR/aio-testfile 2>&1
 status=$?
 rm -f $TEST_DIR/aio-testfile

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Christoph Hellwig

2009-06-10 18:53 UTC #1 lore raw

Quoted 6 lines · Eric Sandeen

Gracefully fail aio tests if they weren't built
configure & make succeeds w/o aio headers or libs, so tests should handle that.
Signed-off-by Eric Sandeen <[email protected]>

Maybe we should just add an _require_aio to check for libaio instead of needing different checks in each test?

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs