Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
Subsystems (3)
PATCH RESEND 4/4 Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
Hi Michael,
Quoted 17 lines · Michael Ellerman
Quoted 15 lines · Subrata Modak
Quoted 9 lines · Stephen Rothwell
Hi Subrata,
Review
Quoted 4 lines · On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <[email protected]>…
(quoted diff) +1
-1/* Find the TBI PHY. If it's not there, we don't support SGMII */ - ph = of_get_property(np, "tbi-handle", NULL); + ph = (phandle *)of_get_property(np, "tbi-handle", NULL);You don't need this cast because
of_get_property()returns "void *".Stephen,
True. But without this gcc complains:
Quoted 9 lines
Quoted 3 lines
CC [M]
drivers/net/ucc_geth.odrivers/net/ucc_geth.c: In function ‘ucc_geth_probe’:drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers from pointer target type^^^^^^^^^^^And what does that warning actually mean?
Your cast actually introduces a bug.
Ok fine. Here is a revised patch.
Subject: [PATCH][Resend][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Reference(s):
http://lkml.org/lkml/2009/6/4/241,
http://lkml.org/lkml/2009/6/10/338,
Fix the following build error:
drivers/net/ucc_geth.c: In function bucc_geth_probeb:drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1
---
drivers/net/ucc_geth.c renamed from drivers/net/ucc_geth.c.orig +2 -0
@@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_gstatic int ucc_geth_probe (struct of_device * ofdev,const struct of_device_id *match) { +struct device_node *mdio; +phandle *ph;struct device *device = &ofdev->dev;struct device_node *np = ofdev->node;struct net_device *dev =NULL ;
---
Regards--
Subrata
Quoted 1 line
cheers