Next June 04:PPC64 randconfig [drivers/net/lance.o]
Subsystems (4)
PATCH 3/4 Next June 04:PPC64 randconfig [drivers/net/lance.o]
Hi Benjamin/Paul,
Quoted 9 lines · Subrata Modak
CC
drivers/net/lance.odrivers/net/lance.c: In function 'lance_probe1':drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'drivers/net/lance.c: In function 'lance_rx':drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Reference: http://lkml.org/lkml/2009/6/4/240,
To fix the following build error:
drivers/net/lance.c: In function 'lance_probe1':drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus' drivers/net/lance.c: In function 'lance_rx':drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
I would like to propose the following patch. The prototypes for the functions:
'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to introduce the following soultion for powerpc ? It fixes the build problem i reported earlier.
---
arch/powerpc/include/asm/io.h renamed from arch/powerpc/include/asm/io.h.orig +3 -0
@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig#define mmio_outsw (addr, src, count) writesw(addr, src, count)#define mmio_outsl (addr, src, count) writesl(addr, src, count) +#define isa_virt_to_bus virt_to_phys +#define isa_bus_to_virt phys_to_virt +/** * virt_to_phys - map virtual addresses to physical * @address: address to remap
---
Regards--
Subrata
Quoted 23 lines · Subrata Modak
Hi Benjamin/Paul,
Quoted 9 lines · Subrata Modak
CC
drivers/net/lance.odrivers/net/lance.c: In function 'lance_probe1':drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'drivers/net/lance.c: In function 'lance_rx':drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2Reference: http://lkml.org/lkml/2009/6/4/240,
To fix the following build error:
drivers/net/lance.c: In function 'lance_probe1':drivers/net/lance.c:575: error: implicit declaration of function 'isa_virt_to_bus'drivers/net/lance.c: In function 'lance_rx':drivers/net/lance.c:1197: error: implicit declaration of function 'isa_bus_to_virt' make[2]: *** [drivers/net/lance.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
Quoted 8 lines
I would like to propose the following patch. The prototypes for the functions:
'isa_virt_to_bus' & 'isa_virt_to_bus' are existing for some archs like the mips, x86, parisc, arm & alpha, but, is missing for powerpc. Is it safe to introduce the following soultion for powerpc ? It fixes the build problem i reported earlier.Signed-off-by Subrata Modak <[email protected]>---
Benjamin,
I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ?
Regards--
Subrata
Quoted 18 lines
arch/powerpc/include/asm/io.h renamed from arch/powerpc/include/asm/io.h.orig +3
-1@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig#define mmio_outsw (addr, src, count) writesw(addr, src, count)#define mmio_outsl (addr, src, count) writesl(addr, src, count) +#define isa_virt_to_bus virt_to_phys +#define isa_bus_to_virt phys_to_virt +/** * virt_to_phys - map virtual addresses to physical * @address: address to remap --- Regards--
Subrata
Quoted 4 lines · Subrata Modak
Benjamin,
I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ?
I suppose ... in fact some old PReP machines can even have ISA slots iirc, but it's not going to do good with machines that have an iommu...
IE. Nobody should use that crap, period.
Cheers,
Ben.
Cheers,
Ben.
Quoted 21 lines
Regards--
SubrataQuoted 18 lines
arch/powerpc/include/asm/io.h renamed from arch/powerpc/include/asm/io.h.orig +3
-1@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig#define mmio_outsw (addr, src, count) writesw(addr, src, count)#define mmio_outsl (addr, src, count) writesl(addr, src, count) +#define isa_virt_to_bus virt_to_phys +#define isa_bus_to_virt phys_to_virt +/** * virt_to_phys - map virtual addresses to physical * @address: address to remap --- Regards--
Subrata
Quoted 11 lines · Benjamin Herrenschmidt
Quoted 4 lines · Subrata Modak
Benjamin,
I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ?
I suppose ... in fact some old PReP machines can even have ISA slots iirc, but it's not going to do good with machines that have an iommu...
IE. Nobody should use that crap, period.
Great,
Can you please make some changes at drivers/net/Kconfig so that this guy does not build for the PPC64 systems ?
Regards--
Subrata
Quoted 29 lines
Cheers,
Ben.Cheers,
Ben.Quoted 21 lines
Regards--
SubrataQuoted 18 lines
arch/powerpc/include/asm/io.h renamed from arch/powerpc/include/asm/io.h.orig +3
-1@@ -680,6 +680,9 @@ extern void __iounmap_at(void *ea, unsig#define mmio_outsw (addr, src, count) writesw(addr, src, count)#define mmio_outsl (addr, src, count) writesl(addr, src, count) +#define isa_virt_to_bus virt_to_phys +#define isa_bus_to_virt phys_to_virt +/** * virt_to_phys - map virtual addresses to physical * @address: address to remap --- Regards--
Subrata
Quoted 11 lines · Subrata Modak
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 4 lines · Subrata Modak
Benjamin,
I am not sure whether you liked the following patch to solve the above problem. Do, you want me address some other issue(s)/fixes for this ?
I suppose ... in fact some old PReP machines can even have ISA slots iirc, but it's not going to do good with machines that have an iommu...
Quoted 6 lines
Quoted 1 line
IE. Nobody should use that crap, period.
Great,
Can you please make some changes at
drivers/net/Kconfigso that this guy does not build for the PPC64 systems ?
When I said "that crap" I was talking about those interfaces which I -hope- are deprecated :-)
I suspect we never really sorted out the issue of DMA mapping for old legacy ISA stuff... pci_map_* should work to some extent, though you have to pass it the ISA bridge pci_dev.
Maybe it's time for somebody to start exposing a -proper- abstraction accross all platforms for that :-)
Ben.