Skip to contentSkip to conversation

perf_counter/x86: Add a quirk for Atom processors

PATCH In review Yong Wang 2 participants 4 messages Jun 12, 2009 x86

lore
Share & tools
lore

Yong Wang

author
#0 lore raw

PATCH 1/1 perf_counter/x86: Add a quirk for Atom processors

The fixed-function performance counters do not work on current Atom processors. Use the general-purpose ones instead.

---
 perf_counter.c |    6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/kernel/cpu/perf_counter.c +6 -0
index 895c82e..4bba0d8 100644
@@ -968,6 +968,12 @@ fixed_mode_idx(struct perf_counter *counter, struct hw_perf_counter *hwc)
 	if (!x86_pmu.num_counters_fixed)
 		return -1;
 
+        /* 
+	 * Quirk: IA32_FIXED_CTRs do not work on current Atom processors  
+	 */
+	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL && boot_cpu_data.x86_model == 28)
+		return -1;
+
 	event = hwc->config & ARCH_PERFMON_EVENT_MASK;
 
 	if (unlikely(event == x86_pmu.event_map(PERF_COUNT_HW_INSTRUCTIONS)))
#1 lore raw
Quoted 2 lines · Yong Wang

The fixed-function performance counters do not work on current Atom processors. Use the general-purpose ones instead.

ah, nice - applied to tip:perfcounters/core, thanks!

Does this make your Atom testbox work fine now?

Ingo

author
#2 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 2 lines · Yong Wang

The fixed-function performance counters do not work on current Atom processors. Use the general-purpose ones instead.

ah, nice - applied to tip:perfcounters/core, thanks!

Does this make your Atom testbox work fine now?

Yup, I tested the patch before I submitted it. It works fine now;-) I will also keep an eye on future Atom processors to see whether fixed function PMCs work or not.

Thanks
-Yong

#3 lore raw
In reply to Yong Wang
Commit-ID:  dff5da6d09daaab40a8741dce0ed3c2e94079de2
Gitweb:     http://git.kernel.org/tip/dff5da6d09daaab40a8741dce0ed3c2e94079de2
Author:     Yong Wang <[email protected]>
AuthorDate: Fri, 12 Jun 2009 16:08:55 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 12 Jun 2009 13:48:32 +0200

perf_counter/x86: Add a quirk for Atom processors

The fixed-function performance counters do not work on current Atom processors. Use the general-purpose ones instead.

Cc Peter Zijlstra <[email protected]>
Cc Mike Galbraith <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/perf_counter.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/perf_counter.c +7 -0
index 895c82e..275bc14 100644
@@ -968,6 +968,13 @@ fixed_mode_idx(struct perf_counter *counter, struct hw_perf_counter *hwc)
 	if (!x86_pmu.num_counters_fixed)
 		return -1;
 
+	/*
+	 * Quirk, IA32_FIXED_CTRs do not work on current Atom processors:
+	 */
+	if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
+					boot_cpu_data.x86_model == 28)
+		return -1;
+
 	event = hwc->config & ARCH_PERFMON_EVENT_MASK;
 
 	if (unlikely(event == x86_pmu.event_map(PERF_COUNT_HW_INSTRUCTIONS)))