Skip to contentSkip to conversation

Fix compilation of arch/arm/mach-omap1/mailbox.c

PATCH In review Jonathan McDowell 3 participants 5 messages Jun 12, 2009 – Jun 15, 2009

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP1 support
lore
Share & tools
lore

Jonathan McDowell

author
#0 lore raw

PATCH 1/1 Fix compilation of arch/arm/mach-omap1/mailbox.c

This fixes the positioning of " in MODULE_AUTHOR, which is currently causing a build failure on latest git with CONFIG_OMAP_MBOX_FWK=m; the original breakage appears to date from the end of last year in a5abbbe52b7e89a7633319c5417bd4331f7ac8ed

Signed-off-by Jonathan McDowell <[email protected]>

-----

arch/arm/mach-omap1/mailbox.c +1 -1
index 0af4d6c..6810b4a 100644
@@ -203,5 +203,5 @@ module_exit(omap1_mbox_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions");
-MODULE_AUTHOR("Hiroshi DOYU" <[email protected]>);
+MODULE_AUTHOR("Hiroshi DOYU <[email protected]>");
 MODULE_ALIAS("platform:omap1-mailbox");

-----

J.

Signature · 4 lines
] http://www.earth.li/~noodles/ []     "Making the impossible very     [
]  PGP/GPG Key @ the.earth.li   []     difficult" -- The OpenGALEN     [
] via keyserver, web or email.  []              website.               [
] RSA: 4096/2DA8B985            []                                     [
#1 lore raw

From: ext Jonathan McDowell <[email protected]>
Subject: [TRIVIAL PATCH] Fix compilation of arch/arm/mach-omap1/mailbox.c
Date: Sat, 13 Jun 2009 01:50:59 +0200

Quoted 6 lines

This fixes the positioning of " in MODULE_AUTHOR, which is currently causing a build failure on latest git with CONFIG_OMAP_MBOX_FWK=m; the original breakage appears to date from the end of last year in a5abbbe52b7e89a7633319c5417bd4331f7ac8ed

Signed-off-by Jonathan McDowell <[email protected]>

Thank you. Tony, please get this in.

Quoted 22 lines

-----

arch/arm/mach-omap1/mailbox.c +1 -2
index 0af4d6c..6810b4a 100644
@@ -203,5 +203,5 @@ module_exit(omap1_mbox_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions");
-MODULE_AUTHOR("Hiroshi DOYU" <[email protected]>);
+MODULE_AUTHOR("Hiroshi DOYU <[email protected]>");
 MODULE_ALIAS("platform:omap1-mailbox");
-----

J.

Signature · 4 lines
] http://www.earth.li/~noodles/ []     "Making the impossible very     [
]  PGP/GPG Key @ the.earth.li   []     difficult" -- The OpenGALEN     [
] via keyserver, web or email.  []              website.               [
] RSA: 4096/2DA8B985            []                                     [
reviewer
#2 lore raw
Quoted 4 lines · Hiroshi DOYU

From: ext Jonathan McDowell <[email protected]>
Subject: [TRIVIAL PATCH] Fix compilation of arch/arm/mach-omap1/mailbox.c
Date: Sat, 13 Jun 2009 01:50:59 +0200

Quoted 8 lines
Quoted 6 lines

This fixes the positioning of " in MODULE_AUTHOR, which is currently causing a build failure on latest git with CONFIG_OMAP_MBOX_FWK=m; the original breakage appears to date from the end of last year in a5abbbe52b7e89a7633319c5417bd4331f7ac8ed

Signed-off-by Jonathan McDowell <[email protected]>

Thank you. Tony, please get this in.

Will add to omap-fixes, can you please reply with your official *-by: ack?

Tony

Quoted 23 lines
Quoted 23 lines

-----

arch/arm/mach-omap1/mailbox.c +1 -2
index 0af4d6c..6810b4a 100644
@@ -203,5 +203,5 @@ module_exit(omap1_mbox_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions");
-MODULE_AUTHOR("Hiroshi DOYU" <[email protected]>);
+MODULE_AUTHOR("Hiroshi DOYU <[email protected]>");
 MODULE_ALIAS("platform:omap1-mailbox");
-----

J.

Signature · 4 lines
] http://www.earth.li/~noodles/ []     "Making the impossible very     [
]  PGP/GPG Key @ the.earth.li   []     difficult" -- The OpenGALEN     [
] via keyserver, web or email.  []              website.               [
] RSA: 4096/2DA8B985            []                                     [
Acked-by on v1 1/1
#3 lore raw
In reply to Jonathan McDowell

From: ext Jonathan McDowell <[email protected]>
Subject: [TRIVIAL PATCH] Fix compilation of arch/arm/mach-omap1/mailbox.c
Date: Sat, 13 Jun 2009 01:50:59 +0200

Quoted 5 lines

This fixes the positioning of " in MODULE_AUTHOR, which is currently causing a build failure on latest git with CONFIG_OMAP_MBOX_FWK=m; the original breakage appears to date from the end of last year in a5abbbe52b7e89a7633319c5417bd4331f7ac8ed

Acked-by Hiroshi DOYU <[email protected]>
Quoted 23 lines
Signed-off-by Jonathan McDowell <[email protected]>

-----

arch/arm/mach-omap1/mailbox.c +1 -2
index 0af4d6c..6810b4a 100644
@@ -203,5 +203,5 @@ module_exit(omap1_mbox_exit);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("omap mailbox: omap1 architecture specific functions");
-MODULE_AUTHOR("Hiroshi DOYU" <[email protected]>);
+MODULE_AUTHOR("Hiroshi DOYU <[email protected]>");
 MODULE_ALIAS("platform:omap1-mailbox");
-----

J.

Signature · 4 lines
] http://www.earth.li/~noodles/ []     "Making the impossible very     [
]  PGP/GPG Key @ the.earth.li   []     difficult" -- The OpenGALEN     [
] via keyserver, web or email.  []              website.               [
] RSA: 4096/2DA8B985            []                                     [
reviewer
#4 lore raw

PATCH 1/1 Fix compilation of arch/arm/mach-omap1/mailbox.c

In reply to Jonathan McDowell

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): 0a68518bc651bffde12e2a2a12588b07b9345d4d

PatchWorks
http://patchwork.kernel.org/patch/30004/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=0a68518bc651bffde12e2a2a12588b07b9345d4d