Skip to contentSkip to conversation

eeepc-laptop: add 3G rfkill support for 901Go

PATCH In review Janne Grunau 2 participants 6 messages Jun 12, 2009 – Jun 16, 2009

lore
Share & tools
lore
#0 lore raw

cover eeepc-laptop: add 3G rfkill support for 901Go

Hi,

The asus_acpi module coming with the Eee PC 901 Go can turn the internal 3G modem on and off. I haven't found updated sources for it (only the release from november 2007) but I haven't searched thoroughly nor requested updated sources from Asus.
Adding support to eeepc-laptop looking at objdump output was easy enough and probably faster than reply from Asus.

There remain only two little issues:
- the new values are not added to the end of the CM_ASL* enum but before CM_ASL_LID. I don't think it's a problem since it seems to be unused.
- The eeepc 1000HE reports 3G control support according to
http://wiki.debian.org/DebianEeePC/Models but has no 3G modem. I assume this is an error in the bios.

Janne Grunau (2):
eeepc-laptop: add 3G and Wimax CM_ASL values and acpi method names
eeepc-laptop: add rfkill support for the 3G modem in Eee PC 901 Go

 drivers/platform/x86/eeepc-laptop.c |   62 +++++++++++++++++++++++++++++++++-
 1 files changed, 60 insertions(+), 2 deletions(-)
#1 lore raw
Quoted 9 lines · Janne Grunau

Hi,

The asus_acpi module coming with the Eee PC 901 Go can turn the internal 3G modem on and off. I haven't found updated sources for it (only the release from november 2007) but I haven't searched thoroughly nor requested updated sources from Asus.
Adding support to eeepc-laptop looking at objdump output was easy enough and probably faster than reply from Asus.

Quoted 6 lines

There remain only two little issues:
- the new values are not added to the end of the CM_ASL* enum but before CM_ASL_LID. I don't think it's a problem since it seems to be unused.
- The eeepc 1000HE reports 3G control support according to
 http://wiki.debian.org/DebianEeePC/Models but has no 3G modem. I assume this is an error in the bios.

Hi,
First,
Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with your model CMSG ?

Then, I was working on a patch to refactor rfkill code in eeepc-laptop. With this patch, adding 3g rfkill
is only 15-20 lines. I'll add it to acpi4asus git tree soon.

Quoted 1 line

From here:

- I can rework your patch
- you can re-send it when rfkill refactoring is here.

as you want =).

Signature · 2 lines
Corentin Chary
http://xf.iksaif.net - http://uffs.org
#2 lore raw
Quoted 3 lines · Corentin Chary

First,
Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with your model CMSG ?

done, I suspect there's an error for the 701 and 901 in that table. CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
http://wiki.debian.org/DebianEeePC/Models supports that.

Do you plan to update eeepc-laptop with all CM_ASL bits?

Quoted 3 lines

Then, I was working on a patch to refactor rfkill code in eeepc-laptop. With this patch, adding 3g rfkill is only 15-20 lines.

good, I was too lazy to refactor it.

Quoted 6 lines

I'll add it to acpi4asus git tree soon.
From here:
- I can rework your patch
- you can re-send it when rfkill refactoring is here.

as you want =).

Drop me a mail when you're done but doesn't really matter who does it.

Janne

#3 lore raw
Quoted 8 lines · Janne Grunau
Quoted 3 lines · Corentin Chary

First,
Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with your model CMSG ?

done, I suspect there's an error for the 701 and 901 in that table. CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
http://wiki.debian.org/DebianEeePC/Models supports that.

I'll check that, thanks

Quoted 1 line

Do you plan to update eeepc-laptop with all CM_ASL bits?

All CM_ASL bits found in latest asus_acpi driver, yep.

Quoted 6 lines
Quoted 3 lines

Then, I was working on a patch to refactor rfkill code in eeepc-laptop. With this patch, adding 3g rfkill is only 15-20 lines.

good, I was too lazy to refactor it.

Quoted 8 lines
Quoted 6 lines

I'll add it to acpi4asus git tree soon.
From here:
 - I can rework your patch
- you can re-send it when rfkill refactoring is here.

as you want =).

Drop me a mail when you're done but doesn't really matter who does it.

Ok

Signature · 2 lines
Corentin Chary
http://xf.iksaif.net - http://uffs.org
#4 lore raw
Quoted 10 lines · Corentin Chary
Quoted 8 lines · Janne Grunau
Quoted 3 lines · Corentin Chary

First,
Could you fill http://dev.iksaif.net/projects/acpi4asus/wiki/CMSG with your model CMSG ?

done, I suspect there's an error for the 701 and 901 in that table. CM_ASL_CARDREADER should be 1 instead of CM_ASL_MODEM.
http://wiki.debian.org/DebianEeePC/Models supports that.

Quoted 20 lines

I'll check that, thanks

Quoted 1 line

Do you plan to update eeepc-laptop with all CM_ASL bits?

All CM_ASL bits found in latest asus_acpi driver, yep.

Quoted 14 lines
Quoted 3 lines

Then, I was working on a patch to refactor rfkill code in eeepc-laptop. With this patch, adding 3g rfkill is only 15-20 lines.

good, I was too lazy to refactor it.

Quoted 6 lines

I'll add it to acpi4asus git tree soon.
From here:
 - I can rework your patch
- you can re-send it when rfkill refactoring is here.

as you want =).

Drop me a mail when you're done but doesn't really matter who does it.

You can find the patch here,
http://git.iksaif.net/?p=acpi4asus.git;a=shortlog;h=refs/heads/eeepc-laptop

Signature · 2 lines
Corentin Chary
http://xf.iksaif.net - http://uffs.org