Skip to contentSkip to conversation

references to non-existent header files under include/linux

DISCUSSION Robert P. J. Day 3 participants 4 messages Jun 13, 2009

lore
Share & tools
lore
#0 lore raw

again, since this output is fairly short, this is a list of
references throughout the source tree of the form:

  #include <linux/whatever>

where there does not appear to be any such header file. might be some false positives but i'm not going to agonize over it.

=== Missing: include/linux/bounds.h === include/linux/mmzone.h:18:#include <linux/bounds.h> include/linux/page-flags.h:11:#include <linux/bounds.h>
=== Missing: include/linux/comedidev.h === drivers/staging/comedi/rt.c:27:#include <linux/comedidev.h>
=== Missing: include/linux/compile.h === arch/x86/boot/version.c:17:#include <linux/compile.h> init/version.c:9:#include <linux/compile.h>
=== Missing: include/linux/config.h === arch/h8300/kernel/timer/tpu.c:10:#include <linux/config.h>
=== Missing: include/linux/i2c/adp5588_keys.h === arch/blackfin/mach-bf537/boards/stamp.c:1093:#include <linux/i2c/adp5588_keys.h> === Missing: include/linux/i2c-pnx0105.h === arch/mips/nxp/pnx833x/common/platform.c:38:#include <linux/i2c-pnx0105.h> === Missing: include/linux/ipipe.h === arch/blackfin/mach-common/ints-priority.c:38:#include <linux/ipipe.h> === Missing: include/linux/ipipe_percpu.h === arch/blackfin/include/asm/ipipe.h:31:#include <linux/ipipe_percpu.h> === Missing: include/linux/ipipe_trace.h === arch/blackfin/include/asm/irq.h:36:#include <linux/ipipe_trace.h> === Missing: include/linux/kdb.h ===
drivers/acpi/osl.c:68:#include <linux/kdb.h>
=== Missing: include/linux/mfd/adp5520.h === arch/blackfin/mach-bf537/boards/stamp.c:1179:#include <linux/mfd/adp5520.h> === Missing: include/linux/modversions.h === drivers/staging/otus/zdusb.c:28:#include <linux/modversions.h>
=== Missing: include/linux/r4k-timer.h === arch/mips/kernel/sync-r4k.c:16:#include <linux/r4k-timer.h>
=== Missing: include/linux/spi/adxl34x.h === arch/blackfin/mach-bf537/boards/stamp.c:612:#include <linux/spi/adxl34x.h> arch/blackfin/mach-bf548/boards/ezkit.c:213:#include <linux/spi/adxl34x.h> === Missing: include/linux/tqueue.h === drivers/pcmcia/au1000_xxs1500.c:33:#include <linux/tqueue.h> drivers/pcmcia/au1000_pb1x00.c:29:#include <linux/tqueue.h>
=== Missing: include/linux/usb/isp1362.h === arch/blackfin/mach-bf533/boards/cm_bf533.c:37:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf533/boards/ezkit.c:38:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf533/boards/ip0x.c:41:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf533/boards/H8606.c:39:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf533/boards/stamp.c:39:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf537/boards/cm_bf537.c:40:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf537/boards/tcm_bf537.c:40:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf537/boards/pnav10.c:39:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf537/boards/minotaur.c:11:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf537/boards/stamp.c:42:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf561/boards/ezkit.c:85:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf561/boards/cm_bf561.c:37:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf527/boards/ezkit.c:39:#include <linux/usb/isp1362.h> arch/blackfin/mach-bf527/boards/cm_bf527.c:40:#include <linux/usb/isp1362.h> === Missing: include/linux/usb/isp1760.h === arch/blackfin/mach-bf537/boards/stamp.c:66:#include <linux/usb/isp1760.h> arch/blackfin/mach-bf548/boards/ezkit.c:63:#include <linux/usb/isp1760.h> arch/blackfin/mach-bf561/boards/ezkit.c:49:#include <linux/usb/isp1760.h> arch/blackfin/mach-bf527/boards/ezkit.c:64:#include <linux/usb/isp1760.h> arch/blackfin/mach-bf527/boards/cm_bf527.c:65:#include <linux/usb/isp1760.h>

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw
Quoted 6 lines · Robert P. J. Day

again, since this output is fairly short, this is a list of
references throughout the source tree of the form:

  #include <linux/whatever>
Quoted 7 lines

where there does not appear to be any such header file. might be some false positives but i'm not going to agonize over it.

=== Missing: include/linux/bounds.h === include/linux/mmzone.h:18:#include <linux/bounds.h> include/linux/page-flags.h:11:#include <linux/bounds.h>

bounds.h is generated.

Quoted 3 lines

=== Missing: include/linux/compile.h === arch/x86/boot/version.c:17:#include <linux/compile.h> init/version.c:9:#include <linux/compile.h>

compile.h is generated.

The rest looks like real bugs.
Please submit patches to fix them up.

Sam

#2 lore raw
Quoted 14 lines · Sam Ravnborg
Quoted 6 lines · Robert P. J. Day

again, since this output is fairly short, this is a list of
references throughout the source tree of the form:

  #include <linux/whatever>
Quoted 7 lines

where there does not appear to be any such header file. might be some false positives but i'm not going to agonize over it.

=== Missing: include/linux/bounds.h === include/linux/mmzone.h:18:#include <linux/bounds.h> include/linux/page-flags.h:11:#include <linux/bounds.h>

Quoted 6 lines

bounds.h is generated.

Quoted 3 lines

=== Missing: include/linux/compile.h === arch/x86/boot/version.c:17:#include <linux/compile.h> init/version.c:9:#include <linux/compile.h>

compile.h is generated.

which i would have recognized if i hadn't been reduced to drinking
decaf this morning. *sigh*.

Quoted 2 lines

The rest looks like real bugs.
Please submit patches to fix them up.

these days, i'm more partial to just doing the scan and, when the
official time comes, passing off the results to the various subsystem maintainers, only because sometimes it's not immediately obvious what the correct fix is.

maybe it's a typo, maybe it's a partial feature commit where the
code should include the header file but the header file is yet to be added, maybe it's part of code that is no longer even being compiled due to changes in #ifdef's or Kconfig files, maybe it's for a non-intel arch that i'm not set up to test, maybe ... anyway, you get the idea. and, in some cases, when the subsystem maintainer takes a look at it, it might be that that single incorrect line represents a much larger issue that only that maintainer should deal with.

in short, i'll just be lazy and whine, and let others do the actual
fixing. :-)

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday

========================================================================

#3 lore raw
Quoted 43 lines · Robert P. J. Day
Quoted 14 lines · Sam Ravnborg
Quoted 6 lines · Robert P. J. Day

again, since this output is fairly short, this is a list of
references throughout the source tree of the form:

  #include <linux/whatever>
Quoted 7 lines

where there does not appear to be any such header file. might be some false positives but i'm not going to agonize over it.

=== Missing: include/linux/bounds.h === include/linux/mmzone.h:18:#include <linux/bounds.h> include/linux/page-flags.h:11:#include <linux/bounds.h>

Quoted 6 lines

bounds.h is generated.

Quoted 3 lines

=== Missing: include/linux/compile.h === arch/x86/boot/version.c:17:#include <linux/compile.h> init/version.c:9:#include <linux/compile.h>

compile.h is generated.

which i would have recognized if i hadn't been reduced to drinking
decaf this morning. *sigh*.

Quoted 2 lines

The rest looks like real bugs.
Please submit patches to fix them up.

these days, i'm more partial to just doing the scan and, when the
official time comes, passing off the results to the various subsystem maintainers, only because sometimes it's not immediately obvious what the correct fix is.

maybe it's a typo, maybe it's a partial feature commit where the
code should include the header file but the header file is yet to be added, maybe it's part of code that is no longer even being compiled due to changes in #ifdef's or Kconfig files, maybe it's for a non-intel arch that i'm not set up to test, maybe ... anyway, you get the idea. and, in some cases, when the subsystem maintainer takes a look at it, it might be that that single incorrect line represents a much larger issue that only that maintainer should deal with.

Quoted 2 lines

in short, i'll just be lazy and whine, and let others do the actual
fixing. :-)

Well, I'm afraid that's not going to work out very well.

Best,
Rafael