Skip to contentSkip to conversation

hwmon: (abituguru3) DMI probing on more

PATCH In review Alistair John Strachan 3 participants 4 messages Jun 13, 2009 – Jun 15, 2009

lore
Share & tools
lore
#0 lore raw

cover hwmon: (abituguru3) DMI probing on more

Salut Jean,

These patches have been compile and runtime tested.

They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using the DMI probe method. The testers have been credited appropriately.

(The driver currently supports 17 models, 7 are now using DMI.)

--
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on

Quoted 9 lines · Alistair John Strachan

Salut Jean,

These patches have been compile and runtime tested.

They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using the DMI probe method. The testers have been credited appropriately.

(The driver currently supports 17 models, 7 are now using DMI.)

Hi,

All 3 look good to me, although I did notice 2 have a common prefix, we have some code to handle this in place, right ?

Regards,

Hans

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw

Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on

In reply to Alistair John Strachan
Quoted 8 lines · On Sunday 14 June 2009 08:22:27 Hans de Goede wrote:
Quoted 7 lines · Alistair John Strachan

Salut Jean,

These patches have been compile and runtime tested.

They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using the DMI probe method. The testers have been credited appropriately.

Quoted 6 lines
Quoted 1 line

(The driver currently supports 17 models, 7 are now using DMI.)

Hi,

All 3 look good to me, although I did notice 2 have a common prefix, we have some code to handle this in place, right ?

Yes, Jean pointed this out last time and now we just chop the bit we don't care about off (find first open bracket, trim any preceding spaces), and compare only exact strings (length must match, non case-sensitive strings must match).

Should all work fine, but I sent the strings separately in case there are regressions.

Signature · 7 lines
Cheers,
Alistair.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw

Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on

In reply to Alistair John Strachan

Hi Alistair,

Quoted 6 lines · Alistair John Strachan

These patches have been compile and runtime tested.

They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using the DMI probe method. The testers have been credited appropriately.

(The driver currently supports 17 models, 7 are now using DMI.)

I think it's somewhat overkill to split these changes into 3 patches. I don't really expect a regression here, and if it were to happen, I'm reasonably certain we would figure out which change is faulty without reverting the patches.

Care to resubmit as a single patch?

Thanks,

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors