spi: add driver for SPI controller of Intel Moorestown platform
cover spi: add driver for SPI controller of Intel Moorestown platform
Hi David,
This patch series adds driver for SPI controller of Intel Moorestown platform.
This driver has been tested with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously
User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
please help to review them.
I haven't seen your mail on this list for a while, so I cc' Andrew and Alan for their reviews as well.
Thanks,
Feng
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
Hi Feng,
Quoted 8 lines · Feng Tang
This patch series adds driver for SPI controller of Intel Moorestown platform.
This driver has been tested with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously
User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
Wow. This is a big surprise for me. I was working on a driver of the Synopsys Designware SPI controller myself during the last year. I posted my work on this list and got reviews from Linus Walleij. No word from David Brownell yet. I'll look into your work and see whether we can merge the drivers.
My first comment is regarding the name of the driver. This should be designware_spi, as this IP block appears in other chips as well, and is not Intel Moorestown specific.
Quoted 4 lines
please help to review them.
I haven't seen your mail on this list for a while, so I cc' Andrew and Alan for their reviews as well.
baruch
Signature · 10 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjectsQuoted 21 lines
-----Original Message-----
From: Baruch Siach [mailto:[email protected]]
Sent: 2009年6月15日 18:18
To: Tang, Feng
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [spi-devel-general] [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platformHi Feng,
Quoted 7 lines · Feng Tang
This patch series adds driver for SPI controller of Intel Moorestown platform.
This driver has been tested with Maxim's Max3110 UART device and Option's 3G modem GTM501L, both PIO and DMA works fine, and these 2 slave devcies can work simultaneously
Quoted 6 lines
Quoted 1 line
User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
Wow. This is a big surprise for me. I was working on a driver of the Synopsys Designware SPI controller myself during the last year. I posted my work on this list and got reviews from Linus Walleij. No word from David Brownell yet. I'll look into your work and see whether we can merge the drivers.
Good idea, we can work together to make the driver better.
Regarding the driver name, it is implemented as a PCI device driver, also it has some Moorestown specific stuff like DMA operation, DMA part of the driver only works with the DMA controller on Moorestown, that's why I used such a name. Anyway, we can discuss more about it.
Thanks,
Feng
Quoted 10 lines
My first comment is regarding the name of the driver. This should be
designware_spi, as this IP block appears in other chips as well, and is not Intel Moorestown specific.Quoted 4 lines
please help to review them.
I haven't seen your mail on this list for a while, so I cc' Andrew and Alan for their reviews as well.
Quoted 7 lines
baruch
--
~. .~ Tk OpenSystems =}------------------------------------------------ooO--U--Ooo------------{=
- [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il -
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
spi-devel-general mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
A message that is not in the archive (sent off-list or not yet received): EADF0A36011179459010BDF5142A457501C9D987BD-Uz4Je35TzWuiAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org
Quoted 8 lines · Feng
Quoted 7 lines
Quoted 2 lines
User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
Wow. This is a big surprise for me. I was working on a driver of the Synopsys Designware SPI controller myself during the last year. I posted my work on this list and got reviews from Linus Walleij. No word from David Brownell yet. I'll look into your work and see whether we can merge the drivers.
Quoted 6 lines
Good idea, we can work together to make the driver better.
Regarding the driver name, it is implemented as a PCI device driver, also it has some Moorestown specific stuff like DMA operation, DMA part of the driver only works with the DMA controller on Moorestown, that's why I used such a name. Anyway, we can discuss more about it.
Then the way to structure it is the classic "bus glue plus core".
Core would be a "designware_spi" (or, "dw_spi" by analogy to the "dw_dmac" DMA driver). It would either expose private calls to bus glue -- PCI or APB, I guess -- or would be a platform_bus thing with the PCI glue creating a platform_bus child of a PCI node.
- Dave
------------------------------------------------------------------------------
A message that is not in the archive (sent off-list or not yet received): 200906231909.54345.david-b-yBeKhBN/[email protected]
Quoted 27 lines
-----Original Message-----
From: David Brownell [mailto:[email protected]]
Sent: 2009年6月24日 10:10
To: Tang, Feng; Baruch Siach
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [spi-devel-general] [PATCH 0/2] spi: add driver for SPI controller of Intel Moorestown platformQuoted 8 lines · Feng
Quoted 7 lines
Quoted 2 lines
User can use "dw_apb_ssi_db.pdf" from Synopsys as HW datasheet
Wow. This is a big surprise for me. I was working on a driver of the Synopsys Designware SPI controller myself during the last year. I posted my work on this list and got reviews from Linus Walleij. No word from David Brownell yet. I'll look into your work and see whether we can merge the drivers.
Quoted 6 lines
Good idea, we can work together to make the driver better.
Regarding the driver name, it is implemented as a PCI device driver, also it has some Moorestown specific stuff like DMA operation, DMA part of the driver only works with the DMA controller on Moorestown, that's why I used such a name. Anyway, we can discuss more about it.
Quoted 6 lines
Then the way to structure it is the classic "bus glue plus core".
Core would be a "
designware_spi" (or, "dw_spi" by analogy to the "dw_dmac" DMA driver). It would either expose private calls to bus glue -- PCI or APB, I guess -- or would be aplatform_busthing with the PCI glue creating aplatform_buschild of a PCI node.
Thanks for the suggestion, will take a look at it
- Feng.
Quoted 2 lines
- Dave
------------------------------------------------------------------------------
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general