Skip to contentSkip to conversation

mpc83xx: set 64BIT_VSPRINTF for boards using nand_util

PATCH New Kim Phillips 2 participants 3 messages Jun 15, 2009 – Jun 16, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpc83xx: set 64BIT_VSPRINTF for boards using nand_util

When enabling NAND support for a board, one must also define CONFIG_SYS_64BIT_VSPRINTF because this is needed in nand_util.c for correct output.

Cc Dave Liu <[email protected]>
Cc Ron Madrid <[email protected]>
Cc Anton Vorontsov <[email protected]>
---
 include/configs/MPC8313ERDB.h |    1 +
 include/configs/MPC8315ERDB.h |    1 +
 include/configs/MPC8360ERDK.h |    1 +
 include/configs/SIMPC8313.h   |    1 +
 4 files changed, 4 insertions(+), 0 deletions(-)
include/configs/MPC8313ERDB.h +1 -0
index 2308568..5149ce7 100644
@@ -236,6 +236,7 @@
 #define CONFIG_CMD_NAND 1
 #define CONFIG_NAND_FSL_ELBC 1
 #define CONFIG_SYS_NAND_BLOCK_SIZE 16384
+#define CONFIG_SYS_64BIT_VSPRINTF	/* needed for nand_util.c */
 
 #define CONFIG_SYS_NAND_U_BOOT_SIZE  (512 << 10)
 #define CONFIG_SYS_NAND_U_BOOT_DST   0x00100000
include/configs/MPC8315ERDB.h +1 -0
index e03a107..4cf48f7 100644
@@ -226,6 +226,7 @@
 #define CONFIG_MTD_NAND_VERIFY_WRITE	1
 #define CONFIG_CMD_NAND			1
 #define CONFIG_NAND_FSL_ELBC		1
+#define CONFIG_SYS_64BIT_VSPRINTF	/* needed for nand_util.c */
 
 #define CONFIG_SYS_BR1_PRELIM	( CONFIG_SYS_NAND_BASE \
 				| (2<<BR_DECC_SHIFT)	/* Use HW ECC */ \
include/configs/MPC8360ERDK.h +1 -0
index f584435..4fcca09 100644
@@ -212,6 +212,7 @@
 #define CONFIG_NAND_FSL_UPM	1
 #define CONFIG_SYS_MAX_NAND_DEVICE	1
 #define CONFIG_MTD_NAND_VERIFY_WRITE
+#define CONFIG_SYS_64BIT_VSPRINTF	/* needed for nand_util.c */
 
 #define CONFIG_SYS_LBLAWBAR1_PRELIM	CONFIG_SYS_NAND_BASE
 #define CONFIG_SYS_LBLAWAR1_PRELIM	0x8000001b /* Access window size 4K */
include/configs/SIMPC8313.h +1 -0
index 72fe115..08b401e 100644
@@ -131,6 +131,7 @@
 #define CONFIG_MTD_NAND_VERIFY_WRITE
 #define CONFIG_CMD_NAND 		1
 #define CONFIG_NAND_FSL_ELBC		1
+#define CONFIG_SYS_64BIT_VSPRINTF	/* needed for nand_util.c */
 
 #define CONFIG_SYS_NAND_U_BOOT_SIZE	(512 << 10)
 #define CONFIG_SYS_NAND_U_BOOT_DST	0x00100000
Signature · 1 line
1.6.3.2
#1 lore raw

PATCH 1/1 mpc83xx: set 64BIT_VSPRINTF for boards using nand_util

Quoted 8 lines · Kim Phillips

When enabling NAND support for a board, one must also define CONFIG_SYS_64BIT_VSPRINTF because this is needed in nand_util.c for correct output.

Cc Dave Liu <[email protected]>
Cc Ron Madrid <[email protected]>
Cc Anton Vorontsov <[email protected]>
Quoted 6 lines

---

include/configs/MPC8313ERDB.h |    1 +
include/configs/MPC8315ERDB.h |    1 +
include/configs/MPC8360ERDK.h |    1 +
include/configs/SIMPC8313.h   |    1 +
4 files changed, 4 insertions(+), 0 deletions(-)

what about putting this dependency in include/asm-*/config.h

- k

#2 lore raw

PATCH 1/1 mpc83xx: set 64BIT_VSPRINTF for boards using nand_util

Quoted 18 lines · On Mon, 15 Jun 2009 21:53:45 -0500 Kumar Gala <[email protected]> wrote:
Quoted 8 lines · Kim Phillips

When enabling NAND support for a board, one must also define CONFIG_SYS_64BIT_VSPRINTF because this is needed in nand_util.c for correct output.

Cc Dave Liu <[email protected]>
Cc Ron Madrid <[email protected]>
Cc Anton Vorontsov <[email protected]>
Quoted 6 lines

---

include/configs/MPC8313ERDB.h |    1 +
include/configs/MPC8315ERDB.h |    1 +
include/configs/MPC8360ERDK.h |    1 +
include/configs/SIMPC8313.h   |    1 +
4 files changed, 4 insertions(+), 0 deletions(-)
Quoted 1 line

what about putting this dependency in include/asm-*/config.h

In this case, I'm following the leader's example:

http://lists.denx.de/pipermail/u-boot/2009-June/054195.html

...but if this is something that people feel should be being done on an arch basis, I'll give asm-ppc a shot.

Kim