Skip to contentSkip to conversation

net: CNIC depends on PCI.

PATCH In review Paul Mundt 2 participants 2 messages Jun 15, 2009

Subsystems (2)
lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 net: CNIC depends on PCI.

Even though this driver does shifty things with UIO to make it less obvious, it is still PCI dependent:

drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get' make[3]: *** [drivers/net/cnic.o] Error 1
make[2]: *** [drivers/net] Error 2

This fixes up the CONFIG_PCI=n case, primarily triggered on allmodconfig/allyesconfig builds:

---

 drivers/net/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/Kconfig +1 -2
index 3b63831..f6d6888 100644
@@ -2272,8 +2272,7 @@ config BNX2
 
 config CNIC
 	tristate "Broadcom CNIC support"
-	depends on BNX2
-	depends on UIO
+	depends on PCI && BNX2 && UIO
 	help
 	  This driver supports offload features of Broadcom NetXtremeII
 	  gigabit Ethernet cards.
#1 lore raw
Quoted 7 lines · Paul Mundt

Even though this driver does shifty things with UIO to make it less obvious, it is still PCI dependent:

drivers/net/cnic.c:2395: error: implicit declaration of function 'pci_dev_get' make[3]: *** [drivers/net/cnic.o] Error 1
make[2]: *** [drivers/net] Error 2

Quoted 5 lines

This fixes up the CONFIG_PCI=n case, primarily triggered on allmodconfig/allyesconfig builds:

A similar patch is already in James' tree:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=babdb788f7ec1a782a52240a5f6dae568f32565f

Quoted 21 lines

---

 drivers/net/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/Kconfig +1 -2
index 3b63831..f6d6888 100644
@@ -2272,8 +2272,7 @@ config BNX2
 
 config CNIC
 	tristate "Broadcom CNIC support"
-	depends on BNX2
-	depends on UIO
+	depends on PCI && BNX2 && UIO
 	help
 	  This driver supports offload features of Broadcom NetXtremeII
 	  gigabit Ethernet cards.