Skip to contentSkip to conversation

OMAP: Zoom2: Fix file system loading issue

PATCH In review Vikram Pandita 3 participants 11 messages Jun 12, 2009 – Jun 22, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 OMAP: Zoom2: Fix file system loading issue

IRQ for 8250 driver is not working on zoom2 as IRQ HIGH level setting is requried

This setting was not possible in 8250 driver

---
 arch/arm/mach-omap2/board-zoom-debugboard.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-zoom-debugboard.c +2 -1
index bac5c43..a8c45dc 100644
@@ -83,7 +83,8 @@ static struct plat_serial8250_port serial_platform_data[] = {
 	{
 		.mapbase	= 0x10000000,
 		.irq		= OMAP_GPIO_IRQ(102),
-		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ,
+		.flags		= UPF_BOOT_AUTOCONF|UPF_IOREMAP|UPF_SHARE_IRQ|
+					UPF_IRQ_TRIG_HIGH,
 		.iotype		= UPIO_MEM,
 		.regshift	= 1,
 		.uartclk	= QUART_CLK,
Signature · 1 line
1.6.0.3.613.g9f8f13
maintainer
#1 lore raw

PATCH 2/2 OMAP: Zoom2: Fix file system loading issue

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

#2 lore raw

Tony

Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Tony Lindgren
Sent: Wednesday, June 17, 2009 8:57 AM
To: [email protected]
Subject: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Quoted 6 lines

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

This patch breaks the zoom2 build.
...

	arch/arm/mach-omap2/board-zoom-debugboard.c:87: error: 'UPF_IRQ_TRIG_HIGH' undeclared here (not 	in a function)
	make[1]: *** [arch/arm/mach-omap2/board-zoom-debugboard.o] Error 1
	make: *** [arch/arm/mach-omap2] Error 2

...

There is a dependency on 8250 patch:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

how do you want to address this issue?

Quoted 10 lines

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-
2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 15 lines · Vikram
Quoted 9 lines

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

This patch breaks the zoom2 build.
...

	arch/arm/mach-omap2/board-zoom-debugboard.c:87: error: 'UPF_IRQ_TRIG_HIGH' undeclared here (not 	in a function)
	make[1]: *** [arch/arm/mach-omap2/board-zoom-debugboard.o] Error 1
	make: *** [arch/arm/mach-omap2] Error 2
Quoted 8 lines

...

There is a dependency on 8250 patch:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

how do you want to address this issue?

Tony,

IMO, We should probably stage the 8250 UPF_* change in l-o as well while we wait for the linux-serial lag.

Kevin

#4 lore raw
In reply to Tony Lindgren
Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Kevin

#5 lore raw
Quoted 25 lines

-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, June 17, 2009 10:55 AM
To: Tony Lindgren; Pandita, Vikram
Cc: [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-

2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Quoted 7 lines

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Yes that should have been the subject and
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

It's learning for next time.

Quoted 4 lines

Kevin

maintainer
#6 lore raw
Quoted 31 lines · Pandita, Vikram
Quoted 31 lines

-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, June 17, 2009 10:55 AM
To: Tony Lindgren; Pandita, Vikram
Cc: [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-

2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

Quoted 7 lines
Quoted 1 line

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Yes that should have been the subject and
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

It's learning for next time.

Will revert. I guess we now need two 8250 patches upstream? One for the omap register define, and one for the interrupt flags?

Tony

#7 lore raw
Quoted 43 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Thursday, June 18, 2009 12:27 AM
To: Pandita, Vikram
Cc: Kevin Hilman; [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 33 lines · Pandita, Vikram
Quoted 32 lines

-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, June 17, 2009 10:55 AM
To: Tony Lindgren; Pandita, Vikram
Cc: [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-

2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Quoted 8 lines
Quoted 5 lines

Yes that should have been the subject and
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

It's learning for next time.

Will revert. I guess we now need two 8250 patches upstream? One for the omap register define, and one for the interrupt flags?

Would be very helpful if you could host these 8250 patches on l-o till we get someone to respond to these. This is a critical dependency.

Quoted 2 lines

Tony

#8 lore raw
Quoted 7 lines · Vikram
Quoted 3 lines

Will revert. I guess we now need two 8250 patches upstream? One for the omap register define, and one for the interrupt flags?

Would be very helpful if you could host these 8250 patches on l-o till we get someone to respond to these. This is a critical dependency.

FYI... I have these staged in the 'pm-upstream/backports' branch of my linux-omap-pm repo, since they are needed for PM testing on Zoom2.

Kevin

#9 lore raw
In reply to Tony Lindgren
Quoted 34 lines · Tony Lindgren
Quoted 33 lines · Pandita, Vikram
Quoted 32 lines

-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, June 17, 2009 10:55 AM
To: Tony Lindgren; Pandita, Vikram
Cc: [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-

2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Quoted 8 lines
Quoted 5 lines

Yes that should have been the subject and
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

It's learning for next time.

Will revert. I guess we now need two 8250 patches upstream? One for the omap register define, and one for the interrupt flags?

Yes, both of these are pending on LKML, and still no word from Alan.

To get it upstream, I defined wake-up register locally in mach-omap2/serial.c until the patch gets merged, but for the interrupt flags there isn't an easy solution.

Kevin

maintainer
#10 lore raw
Quoted 42 lines · Kevin Hilman
Quoted 40 lines · Tony Lindgren
Quoted 38 lines · Pandita, Vikram
Quoted 25 lines

-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, June 17, 2009 10:55 AM
To: Tony Lindgren; Pandita, Vikram
Cc: [email protected]
Subject: Re: [APPLIED] [PATCH 2/2] OMAP: Zoom2: Fix file system loading issue

Quoted 5 lines · Tony Lindgren

This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Branch in linux-omap: omap-fixes

Quoted 7 lines

Initial commit ID (Likely to change): f84eca35d44fd64cdde542f12d08eb04ca534954

PatchWorks
http://patchwork.kernel.org/patch/29668/

Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-

2.6.git;a=commit;h=f84eca35d44fd64cdde542f12d08eb04ca534954

Quoted 7 lines

Sorry, I didn't get to this beforethe merge, but $SUBJECT for this patch is wrong and not terribly helpful. It refers to the symptom, bu tnot the root cause.

It should be something like:

OMAP3: Zoom2: pass IRQ triggering flags for serial driver

Yes that should have been the subject and
is put that way for the 8250 driver:
http://lists.arm.linux.org.uk/lurker/attach/[email protected]

It's learning for next time.

Quoted 8 lines
Quoted 2 lines

Will revert. I guess we now need two 8250 patches upstream? One for the omap register define, and one for the interrupt flags?

Yes, both of these are pending on LKML, and still no word from Alan.

To get it upstream, I defined wake-up register locally in mach-omap2/serial.c until the patch gets merged, but for the interrupt flags there isn't an easy solution.

OK, so it's the irqflags that we still need. I took a look and commented that we should rather have irqflags field in struct uart_port instead.. So let's just wait and see until we have some ack from Alan.

Regards,

Tony