Skip to contentSkip to conversation

kbuild docs regression

DISCUSSION Randy Dunlap 3 participants 4 messages Jun 15, 2009 – Jun 18, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

make htmldocs
without using "O=dir" now (as of 2.6.30-git8) fails with

  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/basic/docproc
  HOSTCC  scripts/basic/hash

DOCPROC Documentation/DocBook/alsa-driver-api.xml DOCPROC Documentation/DocBook/debugobjects.xml
exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory make[1]: *** [Documentation/DocBook/debugobjects.xml] Error 1 make[1]: *** Waiting for unfinished jobs....
DOCPROC Documentation/DocBook/deviceiobook.xml DOCPROC Documentation/DocBook/device-drivers.xml
exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1

(+ more)

Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:

make -f scripts/Makefile.build obj=scripts/basic
make -f scripts/Makefile.build obj=Documentation/DocBook htmldocs
SRCTREE=/lnx/src/TMP/linux-2.6.30-git8/ /lnx/src/TMP/linux-2.6.30-git8/scripts/basic/docproc doc Documentation/DocBook/alsa-driver-api.tmpl >Documentation/DocBook/alsa-driver-api.xml
exec /scripts/kernel-doc: No such file or directory

and one additional fprintf() in docproc.c shows that kernsrctree is empty:

docproc: srctree='/lnx/src/TMP/linux-2.6.30-git8/', kernsrctree=''

Signature · 3 lines
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
#1 lore raw
Quoted 9 lines · Randy Dunlap

make htmldocs
without using "O=dir" now (as of 2.6.30-git8) fails with

DOCPROC Documentation/DocBook/deviceiobook.xml DOCPROC Documentation/DocBook/device-drivers.xml
exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1

Quoted 3 lines

(+ more)

Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:

Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is it a build-sys bug?

#2 lore raw
Quoted 10 lines · Jiri Slaby
Quoted 9 lines · Randy Dunlap

make htmldocs
without using "O=dir" now (as of 2.6.30-git8) fails with

DOCPROC Documentation/DocBook/deviceiobook.xml DOCPROC Documentation/DocBook/device-drivers.xml
exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1

Quoted 6 lines
Quoted 3 lines

(+ more)

Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:

Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is it a build-sys bug?

No, it is a bug of docproc. Patch below fixes it.

---

scripts/basic/docproc.c +1 -1
index 4c9523e..99ca7a6 100644
@@ -385,7 +385,7 @@ int main(int argc, char *argv[])
 	if (!srctree)
 		srctree = getcwd(NULL, 0);
 	kernsrctree = getenv("KBUILD_SRC");
-	if (!kernsrctree)
+	if (!kernsrctree || !*kernsrctree)
 		kernsrctree = srctree;
 	if (argc != 3) {
 		usage();
author Acked-by
#3 lore raw
Quoted 13 lines · Amerigo Wang
Quoted 12 lines · Jiri Slaby
Quoted 11 lines · Randy Dunlap

make htmldocs
without using "O=dir" now (as of 2.6.30-git8) fails with

DOCPROC Documentation/DocBook/deviceiobook.xml DOCPROC Documentation/DocBook/device-drivers.xml
exec /scripts/kernel-doc: No such file or directory exec /scripts/kernel-doc: No such file or directory make[1]: *** [Documentation/DocBook/deviceiobook.xml] Error 1

(+ more)

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Using V=1 shows that SRCTREE is set but KBUILD_SRC is not set:

Hmm, thanks, actually it's set, but it's empty :(. Is it expected, or is it a build-sys bug?

No, it is a bug of docproc. Patch below fixes it.

Quoted 14 lines

---

scripts/basic/docproc.c +1 -1
index 4c9523e..99ca7a6 100644
@@ -385,7 +385,7 @@ int main(int argc, char *argv[])
 	if (!srctree)
 		srctree = getcwd(NULL, 0);
 	kernsrctree = getenv("KBUILD_SRC");
-	if (!kernsrctree)
+	if (!kernsrctree || !*kernsrctree)
 		kernsrctree = srctree;
 	if (argc != 3) {
 		usage();
Signature · 3 lines
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/