More i8042-reset quirks for MSI Wind-clone netbooks
Subsystems (2)
PATCH 1/1 More i8042-reset quirks for MSI Wind-clone netbooks
When testing Moblin on various netbooks, we've got reports that many MSI Wind clones need the i8042 reset quirks for the keyboard and/or touchpad's proper function.
--- drivers/input/serio/i8042-x86ia64io.h | 28 ++++++++++++++++++++++++++++ 1 files changed, 28 insertions(+), 0 deletions(-)
drivers/input/serio/i8042-x86ia64io.h +28 -0
@@ -392,6 +392,34 @@ static struct dmi_system_id __initdata i8042_dmi_reset_table[] = { DMI_MATCH(DMI_BOARD_VENDOR, "LG Electronics Inc."), }, }, + { + .ident = "Acer Aspire One 150", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Acer"), + DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"), + }, + }, + { + .ident = "Advent 4211", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "DIXONSXP"), + DMI_MATCH(DMI_PRODUCT_NAME, "Advent 4211"), + }, + }, + { + .ident = "Medion Akoya Mini E1210", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "MEDION"), + DMI_MATCH(DMI_PRODUCT_NAME, "E1210"), + }, + }, + { + .ident = "Mivvy M310", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "VIOOO"), + DMI_MATCH(DMI_PRODUCT_NAME, "N10"), + }, + }, { } };
Signature · 11 lines
1.6.3.1 -- Best regards, Li, Yan Moblin Team, Opensource Technology Center, SSG, Intel Office tel.: +86-10-82171695 (inet: 8-758-1695) OpenPGP key: 5C6C31EF IRC: yanli on network irc.freenode.net
Quoted 3 lines · Yan Li
When testing Moblin on various netbooks, we've got reports that many MSI Wind clones need the i8042 reset quirks for the keyboard and/or touchpad's proper function.
Why are we not doing this unconditionally?
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 6 lines · Matthew Garrett
Quoted 3 lines · Yan Li
When testing Moblin on various netbooks, we've got reports that many MSI Wind clones need the i8042 reset quirks for the keyboard and/or touchpad's proper function.
Why are we not doing this unconditionally?
For the majority of sane machines this is not necessary.
Signature · 1 line
Li, Yan
Quoted 9 lines · Yan
Quoted 6 lines · Matthew Garrett
Quoted 3 lines · Yan Li
When testing Moblin on various netbooks, we've got reports that many MSI Wind clones need the i8042 reset quirks for the keyboard and/or touchpad's proper function.
Why are we not doing this unconditionally?
For the majority of sane machines this is not necessary.
So? If the alternative is machines that don't work until they're added to a blacklist, then the correct thing to do is to do it unconditionally.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 3 lines
So? If the alternative is machines that don't work until they're added to a blacklist, then the correct thing to do is to do it unconditionally.
I would disagree: that breaks a whole pile of other machines
Alan
Quoted 5 lines · Alan Cox
Quoted 3 lines
So? If the alternative is machines that don't work until they're added to a blacklist, then the correct thing to do is to do it unconditionally.
I would disagree: that breaks a whole pile of other machines
I was under the impression that this was the reset path that Windows followed. If not then that suggests that we're fixing it wrong in the first place?
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 10 lines · On Tue, 16 Jun 2009 17:43:51 +0100 Matthew Garrett <[email protected]> wrote:
Quoted 5 lines · Alan Cox
Quoted 3 lines
So? If the alternative is machines that don't work until they're added to a blacklist, then the correct thing to do is to do it unconditionally.
I would disagree: that breaks a whole pile of other machines
I was under the impression that this was the reset path that Windows followed. If not then that suggests that we're fixing it wrong in the first place?
You need to magically divine what various random windows driver patches do and also allow for the fact that your i8042 may be completely faked SMM, partially faked, or just randomly confused. Resetting loses various bits of config/status that get put back by windows drivers we don't have enough info on and in machine specific ways.
Alan
Quoted 14 lines · Alan Cox
Quoted 10 lines · On Tue, 16 Jun 2009 17:43:51 +0100 Matthew Garrett <[email protected]> wrote:
Quoted 5 lines · Alan Cox
Quoted 3 lines
So? If the alternative is machines that don't work until they're added to a blacklist, then the correct thing to do is to do it unconditionally.
I would disagree: that breaks a whole pile of other machines
I was under the impression that this was the reset path that Windows followed. If not then that suggests that we're fixing it wrong in the first place?
Quoted 5 lines
You need to magically divine what various random windows driver patches do and also allow for the fact that your i8042 may be completely faked SMM, partially faked, or just randomly confused. Resetting loses various bits of config/status that get put back by windows drivers we don't have enough info on and in machine specific ways.
So the touchpad on these machines doesn't work with generic Windows? I'm interested in the specifics, not general issues with i8042 implementations. We've repeatedly seen that these quirk tables end up inadequately comprehensive and in several cases have masked the actual problem.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 5 lines · Matthew Garrett
So the touchpad on these machines doesn't work with generic Windows? I'm interested in the specifics, not general issues with i8042 implementations. We've repeatedly seen that these quirk tables end up inadequately comprehensive and in several cases have masked the actual problem.
Now we have more than 99% machines work well with current i8042 code path, and less than 1% of machines (those MSI Wind & clones) that don't work unless being added to this list.
If we do multiple-resetting unconditionally (for all machines), we are effectively:
1. fixing things that works well
2. make >99% machines (the good citizens) untested
This seems a change too aggressive for me. Do we have a good reason for taking this risk?
Of course if we found the "actual problem" we'd conjure up a better fix. But before that, I'd prefer the conservative way.
Signature · 7 lines
Best regards, Li, Yan Moblin Team, Opensource Technology Center, SSG, Intel Office tel.: +86-10-82171695 (inet: 8-758-1695) OpenPGP key: 5C6C31EF IRC: yanli on network irc.freenode.net
Quoted 2 lines · Yan I
This seems a change too aggressive for me. Do we have a good reason for taking this risk?
It's generally much easier to find regressions (people complain) than it is to find things that have never worked (people just assume Linux is broken).
Quoted 2 lines
Of course if we found the "actual problem" we'd conjure up a better fix. But before that, I'd prefer the conservative way.
Does stock Windows work on the machine? I think this really ought to be a pretty obvious minimal test before adding quirks to the kernel.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 7 lines · Matthew Garrett
Quoted 2 lines · Yan I
This seems a change too aggressive for me. Do we have a good reason for taking this risk?
It's generally much easier to find regressions (people complain) than it is to find things that have never worked (people just assume Linux is broken).
That's true. But we are not sure how many regressions we'll meet and whether the efforts devoted to handle them is worthy. (How to handle regressions? Perhaps, ironically, we'll need another 'whitelist' for them!)
Quoted 5 lines
Quoted 2 lines
Of course if we found the "actual problem" we'd conjure up a better fix. But before that, I'd prefer the conservative way.
Does stock Windows work on the machine? I think this really ought to be a pretty obvious minimal test before adding quirks to the kernel.
Does this matter? Does whether Windows fail or not affect our decision here? (Worse that I have no "stock Windows XP" for testing. All I have are those companion Windows Recovery CDs that include all drivers).
Signature · 1 line
Li, Yan
Quoted 5 lines · Yan
Quoted 4 lines · Matthew Garrett
Quoted 2 lines · Yan I
This seems a change too aggressive for me. Do we have a good reason for taking this risk?
Quoted 8 lines
Quoted 3 lines
It's generally much easier to find regressions (people complain) than it is to find things that have never worked (people just assume Linux is broken).
That's true. But we are not sure how many regressions we'll meet and whether the efforts devoted to handle them is worthy. (How to handle regressions? Perhaps, ironically, we'll need another 'whitelist' for them!)
If we hit regressions then it's the wrong fix and would have to be reverted. Better a small blacklist than a large whitelist (though, in the general case, the presence of either is an indication of a bug)
Quoted 10 lines
Quoted 5 lines
Quoted 2 lines
Of course if we found the "actual problem" we'd conjure up a better fix. But before that, I'd prefer the conservative way.
Does stock Windows work on the machine? I think this really ought to be a pretty obvious minimal test before adding quirks to the kernel.
Does this matter? Does whether Windows fail or not affect our decision here? (Worse that I have no "stock Windows XP" for testing. All I have are those companion Windows Recovery CDs that include all drivers).
Yes. If Windows works without hardware specific drivers then there's a flaw in our i8042 setup code that's affecting an unknown number of machines, and adding more entries to a static table tells us nothing about what proportion of those machines are now fixed - it just tells us that we've worked around the issue for the ones that Intel happen to be testing.
Signature · 1 line
Matthew Garrett | [email protected]
Quoted 8 lines · Matthew Garrett
Quoted 4 lines · Yan
That's true. But we are not sure how many regressions we'll meet and whether the efforts devoted to handle them is worthy. (How to handle regressions? Perhaps, ironically, we'll need another 'whitelist' for them!)
If we hit regressions then it's the wrong fix and would have to be reverted.
Still, I don't think we have enough reason to enable multi-reset of i8042 for all machines: the old code (sane and following specs) has been working well since long ago for most machines, and not until recently we have seen special cases, no more than half a dozen machines that needs special treating. These few glitches can't justify a global move.
Without a good reason, your move (try and revert if hit regressions) seems to be the trial-and-error approach, and not very good for the stable release (though perfectly safe for some testing branches).
Quoted 2 lines
Better a small blacklist than a large whitelist (though, in
the general case, the presence of either is an indication of a bug)
We have no way to know which one is smaller one, the current list is very small (5 entries). I'll change my mind if this i8042_dmi_reset_table[] keeps growing.
The presence of {black,white}list (or more generally, quirks) is the software reflection of the complexity of the world, not necessarily a bug. They are popular (if not ubiquitous) among the kernel.
Quoted 11 lines
Quoted 4 lines
Does this matter? Does whether Windows fail or not affect our decision here? (Worse that I have no "stock Windows XP" for testing. All I have are those companion Windows Recovery CDs that include all drivers).
Yes. If Windows works without hardware specific drivers then there's a flaw in our i8042 setup code that's affecting an unknown number of machines, and adding more entries to a static table tells us nothing about what proportion of those machines are now fixed - it just tells us that we've worked around the issue for the ones that Intel happen to be testing.
Not necessarily if we had followed the spec (I'm not sure of this) of using i8042.
Hope someone can help us do this test. I have already found loads of touchpad drivers on net so I guess Windows can't drive a touchpad until a driver is installed. Pure guess.
Signature · 7 lines
Best regards, Li, Yan Moblin Team, Opensource Technology Center, SSG, Intel Office tel.: +86-10-82171695 (inet: 8-758-1695) OpenPGP key: 5C6C31EF IRC: yanli on network irc.freenode.net
Quoted 2 lines · Yan I
Not necessarily if we had followed the spec (I'm not sure of this) of using i8042.
The spec is irrelevant. What matters is what's implemented. Canonical found a case where our i8042 setup code varied from Windows and which fixed some hardware. Our ACPI implementation deviates wildly from the spec in some places because that's what the implemented platforms expect. The kernel exists to drive hardware, not adhere to some platonic ideal of how the hardware should behave.
Quoted 3 lines
Hope someone can help us do this test. I have already found loads of touchpad drivers on net so I guess Windows can't drive a touchpad until a driver is installed. Pure guess.
Touchpads typically present as a PS/2 mouse until a specific driver is loaded, at which point they switch to a protocol that provides absolute cooirdinates and pressure. It would be virtually impossible to install most operating systems otherwise.
Signature · 1 line
Matthew Garrett | [email protected]
Would now be a good time to trollishly point at
http://bugzilla.kernel.org/show_bug.cgi?id=13540 ?
We broke "an old Pentium 90 machine" some time after 2.6.18.