Skip to contentSkip to conversation

reiserfs: remove stray unlock_super in reiserfs_resize

PATCH In review Christoph Hellwig 2 participants 5 messages Apr 23, 2009 – Jun 19, 2009 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reiserfs: remove stray unlock_super in reiserfs_resize

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.

fs/reiserfs/resize.c +0 -1
Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
 		if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
 			printk
 			    ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
-			unlock_super(s);
 			return -ENOMEM;
 		}
 		/* the new journal bitmaps are zero filled, now we copy in the bitmap
#1 lore raw
Quoted 7 lines · Christoph Hellwig

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.

Acked by Edward Shishkin <[email protected]>

Quoted 18 lines

Index: linux-2.6/fs/reiserfs/resize.c
===================================================================

fs/reiserfs/resize.c +0 -2
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
 		if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
 			printk
 			    ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
-			unlock_super(s);
 			return -ENOMEM;
 		}
 		/* the new journal bitmaps are zero filled, now we copy in the bitmap
--

To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 10 lines · Edward Shishkin
Quoted 7 lines · Christoph Hellwig

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.

Acked by Edward Shishkin <[email protected]>

Do you plan to push this to Linus?

#3 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 7 lines · Edward Shishkin
Quoted 5 lines · Christoph Hellwig

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Acked by Edward Shishkin <[email protected]>

Do you plan to push this to Linus?

Nup.
Please, send..

Thanks,
Edward.

#4 lore raw

PATCH 1/1 reiserfs: remove stray unlock_super in reiserfs_resize

In reply to Christoph Hellwig

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.

Acked by Edward Shishkin <[email protected]>

fs/reiserfs/resize.c +0 -1
Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
 		if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
 			printk
 			    ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
-			unlock_super(s);
 			return -ENOMEM;
 		}
 		/* the new journal bitmaps are zero filled, now we copy in the bitmap