reiserfs: remove stray unlock_super in reiserfs_resize
PATCH 1/1 reiserfs: remove stray unlock_super in reiserfs_resize
Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.
fs/reiserfs/resize.c +0 -1
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *if (reiserfs_allocate_list_bitmaps (s, jbitmap, bmap_nr_new) <0 ) {printk ("reiserfs_resize: unable to allocate memory for journal bitmaps\n" ); -unlock_super (s);return -ENOMEM ; }/* the new journal bitmaps are zero filled, now we copy in the bitmap
Quoted 7 lines · Christoph Hellwig
Reiserfs doesn't use
lock_superanywhere internally, and ->remount_fs which callsreiserfs_resizedoes have it currently but also expects it to be held on return, so there's no business for theunlock_superhere.Signed-off-by Christoph Hellwig <[email protected]>
Acked by Edward Shishkin <[email protected]>
Quoted 18 lines
Index:
linux-2.6/fs/reiserfs/resize.c
===================================================================fs/reiserfs/resize.c +0
-2@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *if (reiserfs_allocate_list_bitmaps (s, jbitmap, bmap_nr_new) <0 ) {printk ("reiserfs_resize: unable to allocate memory for journal bitmaps\n" ); -unlock_super (s);return -ENOMEM ; }/* the new journal bitmaps are zero filled, now we copy in the bitmap -- To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 10 lines · Edward Shishkin
Quoted 7 lines · Christoph Hellwig
Reiserfs doesn't use
lock_superanywhere internally, and ->remount_fs which callsreiserfs_resizedoes have it currently but also expects it to be held on return, so there's no business for theunlock_superhere.Signed-off-by Christoph Hellwig <[email protected]>Acked by Edward Shishkin <[email protected]>
Do you plan to push this to Linus?
Quoted 9 lines · Christoph Hellwig
Quoted 7 lines · Edward Shishkin
Quoted 5 lines · Christoph Hellwig
Reiserfs doesn't use
lock_superanywhere internally, and ->remount_fs which callsreiserfs_resizedoes have it currently but also expects it to be held on return, so there's no business for theunlock_superhere.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Signed-off-by Christoph Hellwig <[email protected]>Acked by Edward Shishkin <[email protected]>
Do you plan to push this to Linus?
Nup.
Please, send..
Thanks,
Edward.
PATCH 1/1 reiserfs: remove stray unlock_super in reiserfs_resize
In reply to Christoph HellwigReiserfs doesn't use lock_super anywhere internally, and ->remount_fs which calls reiserfs_resize does have it currently but also expects it to be held on return, so there's no business for the unlock_super here.
Acked by Edward Shishkin <[email protected]>
fs/reiserfs/resize.c +0 -1
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *if (reiserfs_allocate_list_bitmaps (s, jbitmap, bmap_nr_new) <0 ) {printk ("reiserfs_resize: unable to allocate memory for journal bitmaps\n" ); -unlock_super (s);return -ENOMEM ; }/* the new journal bitmaps are zero filled, now we copy in the bitmap