Skip to contentSkip to conversation

fix checkpoint header exports

PATCH In review Nathan Lynch 3 participants 4 messages Jun 15, 2009 – Jun 20, 2009 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix checkpoint header exports

checkpoint_types.h is not useful to userspace. Unexport it.

checkpoint.h contains definitions that userspace needs. Export it.

user-cr can now be built against exported headers.

---

(against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu appears unresponsive atm)

 include/linux/Kbuild |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/Kbuild +1 -1
index 25b7c0e..df43556 100644
@@ -44,7 +44,7 @@ header-y += bpqether.h
 header-y += bsg.h
 header-y += can.h
 header-y += cdk.h
-header-y += checkpoint_types.h
+header-y += checkpoint.h
 header-y += checkpoint_hdr.h
 header-y += chio.h
 header-y += coda_psdev.h
Signature · 1 line
1.6.0.6

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Thanks, will apply.

git.ncl.cs.columbia.edu was down due to departmental network issues. It's back to life.

Oren.

Quoted 29 lines · Nathan Lynch

checkpoint_types.h is not useful to userspace. Unexport it.

checkpoint.h contains definitions that userspace needs. Export it.

user-cr can now be built against exported headers.

---

(against ckpt-v16-x86 as of a couple days ago; git.ncl.cs.columbia.edu appears unresponsive atm)

 include/linux/Kbuild |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/Kbuild +1 -1
index 25b7c0e..df43556 100644
@@ -44,7 +44,7 @@ header-y += bpqether.h
 header-y += bsg.h
 header-y += can.h
 header-y += cdk.h
-header-y += checkpoint_types.h
+header-y += checkpoint.h
 header-y += checkpoint_hdr.h
 header-y += chio.h
 header-y += coda_psdev.h
#3 lore raw
In reply to a message not in the archive

Nathan Lynch [[email protected]] wrote:
| checkpoint_types.h is not useful to userspace. Unexport it.

Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86

home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included file 'linux/checkpoint_types.h' is not exported

(did not get this error on another machine).

A message that is not in the archive (sent off-list or not yet received): 20090620011005.GA3890-r/[email protected]

#5 lore raw
Quoted 7 lines · Sukadev Bhattiprolu

Nathan Lynch [[email protected]] wrote:
| checkpoint_types.h is not useful to userspace. Unexport it.

Hmm, I get this error when compiling ckpt-v16-dev when compiling for x86

home/suka/containers/build/linux-cr/usr/include/linux/fs.h:11: included file 'linux/checkpoint_types.h' is not exported

Sorry. I neglected to run make headers_check with this change, which would have caught this. Will fix this soon -- you can add checkpoint_types.h back to headers-y to work around this, I think.