Skip to contentSkip to conversation

ar9170usb and module link in sysfs?

PATCH New Andrey Yurovsky 2 participants 2 messages Jun 19, 2009 – Jun 20, 2009

lore
Share & tools
lore
#0 lore raw

I'm curious about the ar9170usb driver and its 'module' links (or rather, lack there of) in sysfs. For other drivers, I can look up a wlanN interface's module by doing looking at device/driver/module/drivers:

# ls /sys/class/net/wlan0/device/driver/module/drivers/
pci:ath5k
# ls /sys/class/net/wlan1/device/driver/module/drivers/
usb:zd1211rw

For ar9170usb, the driver directory doesn't have a module subdirectory and I can't seem to find a link to /sys/bus/usb/drivers/ar9170usb via /sys/class/wlanN like I'd expect to. Is this normal or does ar9170usb do something different with respect to sysfs that I'm missing? Thanks,

-Andrey

#1 lore raw

PATCH 1/1 ar9170usb: module link in sysfs

Andrey Yurovsky reported that the driver forwarded erroneously the parent device structure instead of the real thing, which of course led to some dodgy sysfs links (at least?).

---
your usb(core) subsystem is probably built-in (rather than a module?), so you won't have a "module" entry there.

BTW: currently, I don't have a device, please test!
---

drivers/net/wireless/ath/ar9170/usb.c +1 -1
index 754b1f8..1aec7af 100644
@@ -779,7 +779,7 @@ static int ar9170_usb_probe(struct usb_interface *intf,
 	aru->req_one_stage_fw = ar9170_requires_one_stage(id);
 
 	usb_set_intfdata(intf, aru);
-	SET_IEEE80211_DEV(ar->hw, &udev->dev);
+	SET_IEEE80211_DEV(ar->hw, &intf->dev);
 
 	init_usb_anchor(&aru->rx_submitted);
 	init_usb_anchor(&aru->tx_pending);