Skip to contentSkip to conversation

Bluetooth: Kill session whenever VIRTUAL_CABLE_UNPLUG is passed.

PATCH In review Vikram Kandukuri 3 participants 3 messages Jun 19, 2009 – Jun 25, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: Kill session whenever VIRTUAL_CABLE_UNPLUG is passed.

Whenever the remote device sends VIRTUAL CABLE UNPLUG, the device should be disconnected.

---
 net/bluetooth/hidp/core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/bluetooth/hidp/core.c +1 -0
index b186768..a9f7afb 100644
@@ -374,6 +374,7 @@ static void hidp_process_hid_control(struct hidp_session *session,
 
 		/* Kill session thread */
 		atomic_inc(&session->terminate);
+		hidp_schedule(session);
 	}
 }
 
Signature · 1 line
1.6.0.4
maintainer
#1 lore raw

Hi Vikram,

Quoted 13 lines

Whenever the remote device sends VIRTUAL CABLE UNPLUG, the device should be disconnected.

---
 net/bluetooth/hidp/core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/bluetooth/hidp/core.c +0 -0
index b186768..a9f7afb 100644

net/bluetooth/hidp/core.c static void hidp_process_hid_control(struct hidp_session *session, · line 379

Quoted 6 lines
net/bluetooth/hidp/core.c +1 -0
@@ -374,6 +374,7 @@ static void hidp_process_hid_control(struct hidp_session *session,
 
 		/* Kill session thread */
 		atomic_inc(&session->terminate);
+		hidp_schedule(session);
 	}
 }

the patch is correct, but the commit message could be a little bit more verbose. It should explain why this fixes it.

Regards

Marcel

#2 lore raw

-----Original Message-----
From: [email protected] [mailto:linux-bluetooth-owner@v= ger.kernel.org] On Behalf Of Marcel Holtmann
Sent: Friday, June 19, 2009 3:06 PM
To: Vikram Kandukuri
Cc: [email protected]
Subject: Re: [PATCH] Bluetooth: Kill session whenever VIRTUAL_CABLE_UNPLUG = is passed.

Hi Vikram,

net/bluetooth/hidp/core.c static void hidp_process_hid_control(struct hidp_sess=

Quoted 13 lines

Whenever the remote device sends VIRTUAL CABLE UNPLUG, the device should be disconnected.

---
 net/bluetooth/hidp/core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
net/bluetooth/hidp/core.c +0 -0
index b186768..a9f7afb 100644
@@ -374,6 +374,7 @@ static void hidp_process_hid_control(struct hidp_sess=

ion *session,

net/bluetooth/hidp/core.c static void hidp_process_hid_control(struct hidp_session *session, · line 379

Quoted 6 lines
net/bluetooth/hidp/core.c +1 -0
              /* Kill session thread */
              atomic_inc(&session->terminate);
+             hidp_schedule(session);
      }
 }

the patch is correct, but the commit message could be a little bit more verbose. It should explain why this fixes it.

Regards

Marcel

Hi Marcel,
We were facing this issue while running HID BQB test cases.

There is a test case in PTS tool; PTS will send the VIRTUAL_CABLE_UNPLUG co= mmand to IUT. IUT should disconnect the channel and kill the session when i= t receives VIRTUAL_CABLE_UNPLUG command.
VIRTUAL_CABLE_UNPLUG is parsed by hidp.ko but it is not scheduled to do so = (There is no schedule code). So I have added hidp_schedule to kill the sess= ion.

I feel following description gives more information.

Bluetooth: Scheduled to kill the session whenever VIRTUAL_CABLE_UNPLUG is r= eceived by IUT.

Thanks,
Jothi