econet: failed calls to skb_share_check() and pskb_may_pull() are kernel errors, so return NET_RX_BAD
Subsystems (2)
PATCH 1/1 econet: failed calls to skb_share_check() and pskb_may_pull() are kernel errors, so return NET_RX_BAD
As per the following #define and comment in netdevice.h,
#define NET_RX_BAD 5 /* packet dropped due to kernel error */
return NET_RX_BAD when skb_share_check() or pskb_may_pull() fail in econet_rcv().
Signed-off-by Mark Smith <[email protected]>
net/econet/af_econet.c +5 -3
@@ -1072,10 +1072,12 @@ static int econet_rcv(struct sk_buff *skb, struct net_device *dev, struct packet goto drop;if ((skb =skb_share_check (skb,GFP_ATOMIC )) ==NULL ) -return NET_RX_DROP ; +return NET_RX_BAD ; -if (!pskb_may_pull (skb,sizeof (struct ec_framehdr ))) - goto drop; +if (!pskb_may_pull (skb,sizeof (struct ec_framehdr ))) { +kfree_skb (skb); +return NET_RX_BAD ; + } hdr = (struct ec_framehdr *) skb->data;