Skip to contentSkip to conversation

usb: musb: drop old musb read/write prototypes

PATCH New Mike Frysinger 2 participants 12 messages Jun 16, 2009 – Sep 2, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: musb: drop old musb read/write prototypes

These functions are no longer defined, so remove their prototypes.

---
 drivers/usb/musb/musb_core.h |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
drivers/usb/musb/musb_core.h +0 -6
index b81c536..f9da3f0 100644
@@ -307,10 +307,4 @@ extern void musb_configure_ep(struct musb_epinfo *epinfo, u8 cnt);
 extern void write_fifo(u8 ep, u32 length, void *fifo_data);
 extern void read_fifo(u8 ep, u32 length, void *fifo_data);
 
-/* extern functions */
-extern inline void musb_writew(u32 offset, u16 value);
-extern inline void musb_writeb(u32 offset, u8 value);
-extern inline u16 musb_readw(u32 offset);
-extern inline u8 musb_readb(u32 offset);
-
 #endif	/* __MUSB_HDRC_DEFS_H__ */
Signature · 1 line
1.6.3.1
#1 lore raw

PATCH 1/1 usb: musb: add support for Blackfin MUSB

From: Bryan Wu <[email protected]>

---
 drivers/usb/musb/Makefile                   |    1 +
 drivers/usb/musb/blackfin_usb.c             |  152 +++++++++++++++
 drivers/usb/musb/blackfin_usb.h             |   27 +++
 drivers/usb/musb/musb_core.h                |   73 +++++++
 include/asm-blackfin/mach-common/bits/usb.h |  280 +++++++++++++++++++++++++++
 include/usb.h                               |    3 +-
 6 files changed, 535 insertions(+), 1 deletions(-)
 create mode 100644 drivers/usb/musb/blackfin_usb.c
 create mode 100644 drivers/usb/musb/blackfin_usb.h
 create mode 100644 include/asm-blackfin/mach-common/bits/usb.h
drivers/usb/musb/Makefile +1 -0
index 09e0a5f..40caf9b 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	:= $(obj)libusb_musb.a
 
 COBJS-$(CONFIG_MUSB_HCD) += musb_hcd.o musb_core.o
+COBJS-$(CONFIG_USB_BLACKFIN) += blackfin_usb.o
 COBJS-$(CONFIG_USB_DAVINCI) += davinci.o
 
 COBJS	:= $(COBJS-y)
drivers/usb/musb/blackfin_usb.c new file +152 -0

152 lines not on this page · raw message

drivers/usb/musb/blackfin_usb.h new file +27 -0
new file mode 100644
index 0000000..fe7623c
@@ -0,0 +1,27 @@
+/*
+ * Blackfin MUSB HCD (Host Controller Driver) for u-boot
+ *
+ * Copyright (c) 2008-2009 Analog Devices Inc.
+ *
+ * Licensed under the GPL-2 or later.
+ */
+
+#ifndef __BLACKFIN_USB_H__
+#define __BLACKFIN_USB_H__
+
+#include "musb_core.h"
+
+/* Base address of Blackfin musb core */
+#define MENTOR_USB_BASE		(USB_FADDR)
+
+/* Blackfin uses DMA polling method of FIFO read/write */
+#define USB_DMA_BASE		USB_DMA_INTERRUPT
+#define USB_DMAx_CTRL		0x04
+#define USB_DMAx_ADDR_LOW	0x08
+#define USB_DMAx_ADDR_HIGH	0x0C
+#define USB_DMAx_COUNT_LOW	0x10
+#define USB_DMAx_COUNT_HIGH	0x14
+
+#define USB_DMA_REG(ep, reg)	(USB_DMA_BASE + 0x20 * ep + reg)
+
+#endif
drivers/usb/musb/musb_core.h +73 -0

89 lines not on this page · raw message

include/asm-blackfin/mach-common/bits/usb.h new file +280 -0

280 lines not on this page · raw message

include/usb.h +2 -1
index 7c47098..b398cc0 100644
@@ -183,7 +183,8 @@ struct usb_device {
 #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
 	defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
 	defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \
-	defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI)
+	defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \
+	defined(CONFIG_USB_BLACKFIN)
 
 int usb_lowlevel_init(void);
 int usb_lowlevel_stop(void);
Signature · 1 line
1.6.3.1
#2 lore raw

PATCH 1/1 usb: musb: add support for Blackfin MUSB

Hello Mike,

I got a remark about this patch:

2009/6/16 Mike Frysinger <[email protected]>:

Quoted 85 lines

From: Bryan Wu <[email protected]>

---

?drivers/usb/musb/Makefile ? ? ? ? ? ? ? ? ? | ? ?1 +
?drivers/usb/musb/blackfin_usb.c ? ? ? ? ? ? | ?152 +++++++++++++++
?drivers/usb/musb/blackfin_usb.h ? ? ? ? ? ? | ? 27 +++
?drivers/usb/musb/musb_core.h ? ? ? ? ? ? ? ?| ? 73 +++++++
?include/asm-blackfin/mach-common/bits/usb.h | ?280 +++++++++++++++++++++++++++
?include/usb.h ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?3 +-

?6 files changed, 535 insertions(+), 1 deletions(-)

drivers/usb/musb/musb_core.h +0 -0
@@ -42,6 +42,68 @@
 

?/* Mentor USB core register overlay structure */
?struct musb_regs {

drivers/usb/musb/musb_core.h +62 -0
+#if defined(CONFIG_USB_BLACKFIN)
+ ? ? ? /* Every register is 32bit aligned, but only 16bits in size */
+# define ureg(name) u16 name; u16 __pad_##name;
+ ? ? ? /* common registers */
+ ? ? ? ureg(faddr)
+ ? ? ? ureg(power)
+ ? ? ? ureg(intrtx)
+ ? ? ? ureg(intrrx)
+ ? ? ? ureg(intrtxe)
+ ? ? ? ureg(intrrxe)
+ ? ? ? ureg(intrusb)
+ ? ? ? ureg(intrusbe)
+ ? ? ? ureg(frame)
+ ? ? ? ureg(index)
+ ? ? ? ureg(testmode)
+ ? ? ? ureg(globintr)
+ ? ? ? ureg(global_ctl)
+ ? ? ? u32 ? ? reserved0[3];
+ ? ? ? /* indexed registers */
+ ? ? ? ureg(txmaxp)
+ ? ? ? ureg(txcsr)
+ ? ? ? ureg(rxmaxp)
+ ? ? ? ureg(rxcsr)
+ ? ? ? ureg(rxcount)
+ ? ? ? ureg(txtype)
+ ? ? ? ureg(txinterval)
+ ? ? ? ureg(rxtype)
+ ? ? ? ureg(rxinterval)
+ ? ? ? u32 ? ? reserved1;
+ ? ? ? ureg(txcount)
+ ? ? ? u32 ? ? reserved2[5];
+ ? ? ? /* fifo */
+ ? ? ? u16 ? ? fifox[32];
+ ? ? ? /* OTG, dynamic FIFO, version & vendor registers */
+ ? ? ? u32 ? ? reserved3[16];
+ ? ? ? ureg(devctl)
+ ? ? ? ureg(vbus_irq)
+ ? ? ? ureg(vbus_mask)
+ ? ? ? u32 reserved4[15];
+ ? ? ? ureg(linkinfo)
+ ? ? ? ureg(vplen)
+ ? ? ? ureg(hseof1)
+ ? ? ? ureg(fseof1)
+ ? ? ? ureg(lseof1)
+ ? ? ? u32 reserved5[41];
+ ? ? ? /* target address registers */
+ ? ? ? struct musb_tar_regs {
+ ? ? ? ? ? ? ? ureg(txmaxp)
+ ? ? ? ? ? ? ? ureg(txcsr)
+ ? ? ? ? ? ? ? ureg(rxmaxp)
+ ? ? ? ? ? ? ? ureg(rxcsr)
+ ? ? ? ? ? ? ? ureg(rxcount)
+ ? ? ? ? ? ? ? ureg(txtype)
+ ? ? ? ? ? ? ? ureg(txinternal)
+ ? ? ? ? ? ? ? ureg(rxtype)
+ ? ? ? ? ? ? ? ureg(rxinternal)
+ ? ? ? ? ? ? ? u32 ? ? reserved6;
+ ? ? ? ? ? ? ? ureg(txcount)
+ ? ? ? ? ? ? ? u32 reserved7[5];
+ ? ? ? } tar[8];
+# undef ureg
+#else

? ? ? ?/* common registers */
? ? ? ?u8 ? ? ?faddr;
? ? ? ?u8 ? ? ?power;

drivers/usb/musb/musb_core.h struct musb_regs { · line 162

Quoted 4 lines
drivers/usb/musb/musb_core.h +1 -0
@@ -97,6 +159,7 @@ struct musb_regs {
 ? ? ? ? ? ? ? ?u8 ? ? ?rxhubaddr;
 ? ? ? ? ? ? ? ?u8 ? ? ?rxhubport;
 ? ? ? ?} tar[16];
+#endif

Can both branches of this ifdef be merged somehow, such that the ifdef is much smaller?
Both branches seem to contain the same elements, only type differs ( which could maybe be handled with ureg() constructions also)

drivers/usb/musb/musb_core.h struct musb_regs { · line 163

Quoted 1 line
drivers/usb/musb/musb_core.h +0 -0
 } __attribute__((aligned(32)));

Shouldn't this be '__attribute__((packed))' too?

Kind Regards,

Remy

#3 lore raw

PATCH 1/1 usb: musb: add support for Blackfin MUSB

Quoted 99 lines · On Sunday 21 June 2009 15:54:13 Remy Bohmer wrote:

Hello Mike,

I got a remark about this patch:

2009/6/16 Mike Frysinger <[email protected]>:

Quoted 86 lines

From: Bryan Wu <[email protected]>

---
 drivers/usb/musb/Makefile                   |    1 +
 drivers/usb/musb/blackfin_usb.c             |  152 +++++++++++++++
 drivers/usb/musb/blackfin_usb.h             |   27 +++
 drivers/usb/musb/musb_core.h                |   73 +++++++
 include/asm-blackfin/mach-common/bits/usb.h |  280
+++++++++++++++++++++++++++ include/usb.h                               |
   3 +-
 6 files changed, 535 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_core.h +62 -0
@@ -42,6 +42,68 @@
 
 /* Mentor USB core register overlay structure */
 struct musb_regs {
+#if defined(CONFIG_USB_BLACKFIN)
+       /* Every register is 32bit aligned, but only 16bits in size */
+# define ureg(name) u16 name; u16 __pad_##name;
+       /* common registers */
+       ureg(faddr)
+       ureg(power)
+       ureg(intrtx)
+       ureg(intrrx)
+       ureg(intrtxe)
+       ureg(intrrxe)
+       ureg(intrusb)
+       ureg(intrusbe)
+       ureg(frame)
+       ureg(index)
+       ureg(testmode)
+       ureg(globintr)
+       ureg(global_ctl)
+       u32     reserved0[3];
+       /* indexed registers */
+       ureg(txmaxp)
+       ureg(txcsr)
+       ureg(rxmaxp)
+       ureg(rxcsr)
+       ureg(rxcount)
+       ureg(txtype)
+       ureg(txinterval)
+       ureg(rxtype)
+       ureg(rxinterval)
+       u32     reserved1;
+       ureg(txcount)
+       u32     reserved2[5];
+       /* fifo */
+       u16     fifox[32];
+       /* OTG, dynamic FIFO, version & vendor registers */
+       u32     reserved3[16];
+       ureg(devctl)
+       ureg(vbus_irq)
+       ureg(vbus_mask)
+       u32 reserved4[15];
+       ureg(linkinfo)
+       ureg(vplen)
+       ureg(hseof1)
+       ureg(fseof1)
+       ureg(lseof1)
+       u32 reserved5[41];
+       /* target address registers */
+       struct musb_tar_regs {
+               ureg(txmaxp)
+               ureg(txcsr)
+               ureg(rxmaxp)
+               ureg(rxcsr)
+               ureg(rxcount)
+               ureg(txtype)
+               ureg(txinternal)
+               ureg(rxtype)
+               ureg(rxinternal)
+               u32     reserved6;
+               ureg(txcount)
+               u32 reserved7[5];
+       } tar[8];
+# undef ureg
+#else
       /* common registers */
       u8      faddr;
       u8      power;

drivers/usb/musb/musb_core.h struct musb_regs { · line 162

Quoted 4 lines
drivers/usb/musb/musb_core.h +1 -0
@@ -97,6 +159,7 @@ struct musb_regs {
               u8      rxhubaddr;
               u8      rxhubport;
       } tar[16];
+#endif

Can both branches of this ifdef be merged somehow, such that the ifdef is much smaller?

Quoted 2 lines

Both branches seem to contain the same elements, only type differs ( which could maybe be handled with ureg() constructions also)

the layout isnt exactly the same, the sizes arent uniform enough for ureg(), and the registers available dont match either. we'd still have ifdefs, but interleaved, and i think that'd be much more likely to lead to breakage for architectures invovled.

Quoted 3 lines

drivers/usb/musb/musb_core.h struct musb_regs { · line 163

Quoted 1 line
drivers/usb/musb/musb_core.h +0 -0
 } __attribute__((aligned(32)));

Shouldn't this be '__attribute__((packed))' too?

i didnt add that, but adding packed would probably make sense
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090621/14e8dc34/attachment-0001.pgp

#4 lore raw

PATCH 1/1 usb: musb: add support for Blackfin MUSB

Hello Mike,

Quoted 1 line

ping ... should still apply (or at least git-am should be able to handle it)

Well, this comment at least gave me the impression that you would update your patch...

Quoted 2 lines

i didnt add that, but adding packed would probably make sense -mike

Remy

2009/6/21 Mike Frysinger <[email protected]>:

Quoted 115 lines · On Sunday 21 June 2009 15:54:13 Remy Bohmer wrote:
Quoted 99 lines

Hello Mike,

I got a remark about this patch:

2009/6/16 Mike Frysinger <[email protected]>:

Quoted 86 lines

From: Bryan Wu <[email protected]>

---

?drivers/usb/musb/Makefile ? ? ? ? ? ? ? ? ? | ? ?1 +
?drivers/usb/musb/blackfin_usb.c ? ? ? ? ? ? | ?152 +++++++++++++++
?drivers/usb/musb/blackfin_usb.h ? ? ? ? ? ? | ? 27 +++
?drivers/usb/musb/musb_core.h ? ? ? ? ? ? ? ?| ? 73 +++++++
?include/asm-blackfin/mach-common/bits/usb.h | ?280

+++++++++++++++++++++++++++ include/usb.h ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?3 +-
?6 files changed, 535 insertions(+), 1 deletions(-)

drivers/usb/musb/musb_core.h +0 -0
@@ -42,6 +42,68 @@
 

?/* Mentor USB core register overlay structure */
?struct musb_regs {

drivers/usb/musb/musb_core.h +62 -0
+#if defined(CONFIG_USB_BLACKFIN)
+ ? ? ? /* Every register is 32bit aligned, but only 16bits in size */
+# define ureg(name) u16 name; u16 __pad_##name;
+ ? ? ? /* common registers */
+ ? ? ? ureg(faddr)
+ ? ? ? ureg(power)
+ ? ? ? ureg(intrtx)
+ ? ? ? ureg(intrrx)
+ ? ? ? ureg(intrtxe)
+ ? ? ? ureg(intrrxe)
+ ? ? ? ureg(intrusb)
+ ? ? ? ureg(intrusbe)
+ ? ? ? ureg(frame)
+ ? ? ? ureg(index)
+ ? ? ? ureg(testmode)
+ ? ? ? ureg(globintr)
+ ? ? ? ureg(global_ctl)
+ ? ? ? u32 ? ? reserved0[3];
+ ? ? ? /* indexed registers */
+ ? ? ? ureg(txmaxp)
+ ? ? ? ureg(txcsr)
+ ? ? ? ureg(rxmaxp)
+ ? ? ? ureg(rxcsr)
+ ? ? ? ureg(rxcount)
+ ? ? ? ureg(txtype)
+ ? ? ? ureg(txinterval)
+ ? ? ? ureg(rxtype)
+ ? ? ? ureg(rxinterval)
+ ? ? ? u32 ? ? reserved1;
+ ? ? ? ureg(txcount)
+ ? ? ? u32 ? ? reserved2[5];
+ ? ? ? /* fifo */
+ ? ? ? u16 ? ? fifox[32];
+ ? ? ? /* OTG, dynamic FIFO, version & vendor registers */
+ ? ? ? u32 ? ? reserved3[16];
+ ? ? ? ureg(devctl)
+ ? ? ? ureg(vbus_irq)
+ ? ? ? ureg(vbus_mask)
+ ? ? ? u32 reserved4[15];
+ ? ? ? ureg(linkinfo)
+ ? ? ? ureg(vplen)
+ ? ? ? ureg(hseof1)
+ ? ? ? ureg(fseof1)
+ ? ? ? ureg(lseof1)
+ ? ? ? u32 reserved5[41];
+ ? ? ? /* target address registers */
+ ? ? ? struct musb_tar_regs {
+ ? ? ? ? ? ? ? ureg(txmaxp)
+ ? ? ? ? ? ? ? ureg(txcsr)
+ ? ? ? ? ? ? ? ureg(rxmaxp)
+ ? ? ? ? ? ? ? ureg(rxcsr)
+ ? ? ? ? ? ? ? ureg(rxcount)
+ ? ? ? ? ? ? ? ureg(txtype)
+ ? ? ? ? ? ? ? ureg(txinternal)
+ ? ? ? ? ? ? ? ureg(rxtype)
+ ? ? ? ? ? ? ? ureg(rxinternal)
+ ? ? ? ? ? ? ? u32 ? ? reserved6;
+ ? ? ? ? ? ? ? ureg(txcount)
+ ? ? ? ? ? ? ? u32 reserved7[5];
+ ? ? ? } tar[8];
+# undef ureg
+#else

? ? ? ?/* common registers */
? ? ? ?u8 ? ? ?faddr;
? ? ? ?u8 ? ? ?power;

drivers/usb/musb/musb_core.h struct musb_regs { · line 162

Quoted 4 lines
drivers/usb/musb/musb_core.h +1 -0
@@ -97,6 +159,7 @@ struct musb_regs {
 ? ? ? ? ? ? ? ?u8 ? ? ?rxhubaddr;
 ? ? ? ? ? ? ? ?u8 ? ? ?rxhubport;
 ? ? ? ?} tar[16];
+#endif

Can both branches of this ifdef be merged somehow, such that the ifdef is much smaller?

Quoted 2 lines

Both branches seem to contain the same elements, only type differs ( which could maybe be handled with ureg() constructions also)

the layout isnt exactly the same, the sizes arent uniform enough for ureg(), and the registers available dont match either. ?we'd still have ifdefs, but interleaved, and i think that'd be much more likely to lead to breakage for architectures invovled.

Quoted 3 lines

drivers/usb/musb/musb_core.h struct musb_regs { · line 163

Quoted 1 line
drivers/usb/musb/musb_core.h +0 -0
 ?} __attribute__((aligned(32)));

Shouldn't this be '__attribute__((packed))' too?

i didnt add that, but adding packed would probably make sense -mike

#5 lore raw

PATCH 1/1 usb: musb: add support for Blackfin MUSB

Quoted 8 lines · On Wednesday 02 September 2009 06:43:45 Remy Bohmer wrote:

Hello Mike,

Quoted 2 lines

ping ... should still apply (or at least git-am should be able to handle it)

Well, this comment at least gave me the impression that you would update your patch...

Quoted 1 line

i didnt add that, but adding packed would probably make sense

i'd prefer to send it as a sep changeset as that will affect more than just the Blackfin platform ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090902/89e37614/attachment.pgp

#7 lore raw

PATCH 1/1 usb: musb: add timeout via CONFIG_MUSB_TIMEOUT

In reply to Mike Frysinger

From: Bryan Wu <[email protected]>

---
 drivers/usb/musb/musb_hcd.c |   31 +++++++++++++++++++++++++++++++
 drivers/usb/musb/musb_hcd.h |    4 ++++
 2 files changed, 35 insertions(+), 0 deletions(-)
drivers/usb/musb/musb_hcd.c +31 -0
index 352a0d4..19d978b 100644
@@ -111,6 +111,7 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
 {
 	u16 csr;
 	int result = 1;
+	int timeout = CONFIG_MUSB_TIMEOUT;
 
 	while (result > 0) {
 		csr = readw(&musbr->txcsr);
@@ -152,7 +153,17 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
 			}
 			break;
 		}
+
+		/* Check the timeout */
+		if (--timeout)
+			udelay(1);
+		else {
+			dev->status = USB_ST_CRC_ERR;
+			result = -1;
+			break;
+		}
 	}
+
 	return result;
 }
 
@@ -162,6 +173,7 @@ static int wait_until_ep0_ready(struct usb_device *dev, u32 bit_mask)
 static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
 {
 	u16 csr;
+	int timeout = CONFIG_MUSB_TIMEOUT;
 
 	do {
 		if (check_stall(ep, 1)) {
@@ -174,6 +186,15 @@ static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
 			dev->status = USB_ST_CRC_ERR;
 			return 0;
 		}
+
+		/* Check the timeout */
+		if (--timeout)
+			udelay(1);
+		else {
+			dev->status = USB_ST_CRC_ERR;
+			return -1;
+		}
+
 	} while (csr & MUSB_TXCSR_TXPKTRDY);
 	return 1;
 }
@@ -184,6 +205,7 @@ static u8 wait_until_txep_ready(struct usb_device *dev, u8 ep)
 static u8 wait_until_rxep_ready(struct usb_device *dev, u8 ep)
 {
 	u16 csr;
+	int timeout = CONFIG_MUSB_TIMEOUT;
 
 	do {
 		if (check_stall(ep, 0)) {
@@ -196,6 +218,15 @@ static u8 wait_until_rxep_ready(struct usb_device *dev, u8 ep)
 			dev->status = USB_ST_CRC_ERR;
 			return 0;
 		}
+
+		/* Check the timeout */
+		if (--timeout)
+			udelay(1);
+		else {
+			dev->status = USB_ST_CRC_ERR;
+			return -1;
+		}
+
 	} while (!(csr & MUSB_RXCSR_RXPKTRDY));
 	return 1;
 }
drivers/usb/musb/musb_hcd.h +4 -0
index bb83311..b7f571d 100644
@@ -30,6 +30,10 @@
 extern unsigned char new[];
 #endif
 
+#ifndef CONFIG_MUSB_TIMEOUT
+# define CONFIG_MUSB_TIMEOUT 100000
+#endif
+
 /* This defines the endpoint number used for control transfers */
 #define MUSB_CONTROL_EP 0
 
Signature · 1 line
1.6.3.1
#10 lore raw

PATCH 1/1 usb: musb: add timeout via CONFIG_MUSB_TIMEOUT

Quoted 8 lines · On Sunday 21 June 2009 16:05:43 Remy Bohmer wrote:

2009/6/16 Mike Frysinger <[email protected]>:

Quoted 3 lines

From: Bryan Wu <[email protected]>

I get permanent delivery errors on this email address. Are you sure it is correct?
If not, can you please provide me a correct address?

it isnt anymore as Bryan has changed jobs
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090621/4354c365/attachment.pgp