sound: fix check for return value in snd_pcm_hw_refine
PATCH 1/1 sound: fix check for return value in snd_pcm_hw_refine
Hello,
'params' is a pointer and looking at the code this probably should be a check for ioctl return value.
Mariusz
Signed-off-by Mariusz Kozlowski <[email protected]>
sound/core/pcm_native.c +1 -1
@@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream, snd_mask_max(¶ms->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) { changed = substream->ops->ioctl (substream,SNDRV_PCM_IOCTL1_FIFO_SIZE , params); -if (params <0 ) +if (changed <0 )return changed; } }
At Sun, 21 Jun 2009 20:26:59 +0200,
Quoted 10 lines · Mariusz Kozlowski
Hello,
'params' is a pointer and looking at the code this probably should be a check for ioctl return value.
Mariusz
Signed-off-by Mariusz Kozlowski <[email protected]>
Applied now. Thanks!
Takashi
Quoted 15 lines
sound/core/pcm_native.c +1
-1@@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream, snd_mask_max(¶ms->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) { changed = substream->ops->ioctl (substream,SNDRV_PCM_IOCTL1_FIFO_SIZE , params); -if (params <0 ) +if (changed <0 )return changed; } }