Skip to contentSkip to conversation

Revert "power_supply: remove capacity_level from list of sysfs attributes"

PATCH In review Andres Salomon 2 participants 2 messages Jun 23, 2009 – Jun 24, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 5/5 Revert "power_supply: remove capacity_level from list of sysfs attributes"

This reverts commit 4cbc76eadf56399cd11fb736b33c53aec9caab8c.

This is part of the CAPACITY_LEVEL re-add.

---
 drivers/power/power_supply_sysfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/power/power_supply_sysfs.c +1 -0
index fef37b2..d22d9c9 100644
@@ -116,6 +116,7 @@ static struct device_attribute power_supply_attrs[] = {
 	POWER_SUPPLY_ATTR(energy_now),
 	POWER_SUPPLY_ATTR(energy_avg),
 	POWER_SUPPLY_ATTR(capacity),
+	POWER_SUPPLY_ATTR(capacity_level),
 	POWER_SUPPLY_ATTR(temp),
 	POWER_SUPPLY_ATTR(temp_ambient),
 	POWER_SUPPLY_ATTR(time_to_empty_now),
Signature · 1 line
1.5.6.5
#1 lore raw
Quoted 4 lines · Andres Salomon

This reverts commit 4cbc76eadf56399cd11fb736b33c53aec9caab8c.

This is part of the CAPACITY_LEVEL re-add.

The two patches (4/5 and 5/5) looks OK, but could you merge them together? Title them "Re-add capacity_level ...".

And place them somewhere in the beginning of this series, i.e. before 2/5 and 3/5. That way we can apply 1/5, 4/5, and 5/5, without depending on 2/5 and 3/5.

Thanks,

Quoted 20 lines
---
 drivers/power/power_supply_sysfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/power/power_supply_sysfs.c +1 -0
index fef37b2..d22d9c9 100644
@@ -116,6 +116,7 @@ static struct device_attribute power_supply_attrs[] = {
 	POWER_SUPPLY_ATTR(energy_now),
 	POWER_SUPPLY_ATTR(energy_avg),
 	POWER_SUPPLY_ATTR(capacity),
+	POWER_SUPPLY_ATTR(capacity_level),
 	POWER_SUPPLY_ATTR(temp),
 	POWER_SUPPLY_ATTR(temp_ambient),
 	POWER_SUPPLY_ATTR(time_to_empty_now),
Signature · 1 line
1.5.6.5
Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2