asm-generic/vmlinux.lds.h: Fix up RW_DATA_SECTION definition.
PATCH 1/1 asm-generic/vmlinux.lds.h: Fix up RW_DATA_SECTION definition.
RW_DATA_SECTION is defined to take 4 different alignment parameters, while NOSAVE_DATA currently uses a fixed PAGE_SIZE alignment as noted in the comments.
There are presently no in-tree users of this at present, and I just stumbled across this while implementing the simplified script on a new architecture port, which subsequently resulted in a syntax error.
---
include/asm-generic/vmlinux.lds.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/asm-generic/vmlinux.lds.h +2 -2
@@ -704,7 +704,7 @@* matches the requirment of PAGE_ALIGNED_DATA. * * use 0 as page_align if page_aligned data is not used */ -#define RW_DATA_SECTION (cacheline, nosave, pagealigned, inittask) \ +#define RW_DATA_SECTION (cacheline, pagealigned, inittask) \ . = ALIGN(PAGE_SIZE); \ .data : AT(ADDR(.data) - LOAD_OFFSET) { \ INIT_TASK(inittask) \
@@ -712,7 +712,7 @@READ_MOSTLY_DATA (cacheline) \ DATA_DATA \CONSTRUCTORS \ - NOSAVE_DATA(nosave) \ + NOSAVE_DATA \ PAGE_ALIGNED_DATA(pagealigned) \ }
Quoted 9 lines · Paul Mundt
RW_DATA_SECTIONis defined to take 4 different alignment parameters, whileNOSAVE_DATAcurrently uses a fixedPAGE_SIZEalignment as noted in the comments.There are presently no in-tree users of this at present, and I just stumbled across this while implementing the simplified script on a new architecture port, which subsequently resulted in a syntax error.
Signed-off-by Paul Mundt <[email protected]>
Thanks - applied.
And I'm glad this is used.
Sam