Kirkwood: add Marvell Sheevaplug gpio support
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 Kirkwood: add Marvell Sheevaplug gpio support
Quoted 22 lines
Quoted 22 lines
-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Monday, June 29, 2009 1:33 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar
Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio supportHi List,
this if my first patch which goes to the wild. So please don't be croos with me if I made some stupid thing :) Any comments or feedback would be very welcome!
Is it common that the patch writer gives his Signed-off-by or who is responsible for that?
Cheers,
Dieter
Quoted 6 lines
Quoted 4 lines
From
e89ebedf1528e821e504c91af802687efb21533bMon Sep 17 00:00:00 2001
From: Dieter Kiermaier <[email protected]>
Date: Fri, 26 Jun 2009 14:45:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio supportSigned-off-by is MUST
Ok
Quoted 8 lines
Quoted 7 lines
--- board/Marvell/sheevaplug/sheevaplug.c | 1 + cpu/arm926ejs/kirkwood/Makefile | 1 + cpu/arm926ejs/kirkwood/gpio.c | 144 +++++++++++++++++++++++++++++++++ include/asm-arm/arch-kirkwood/gpio.h | 43 ++++++++++Spilt this patch into two, 1. gpio support for Kirkwood SOC and 2. Sheevaplug updates
You think about the change in sheevaplug.c for "2. Sheevaplug updates" , right?
Quoted 1 line
Move gpio stuff to
drivers/gpio/
ok
Quoted 24 lines
Quoted 24 lines
4 files changed, 189 insertions(+), 0 deletions(-) createmode 100644
cpu/arm926ejs/kirkwood/gpio.ccreate mode 100644include/asm-arm/arch-kirkwood/gpio.hboard/Marvell/sheevaplug/sheevaplug.c +1
-0@@ -26,6 +26,7 @@#include <miiphy.h> #include <asm/arch/kirkwood.h> #include <asm/arch/mpp.h> +#include <asm/arch/gpio.h> #include "sheevaplug.h" DECLARE_GLOBAL_DATA_PTR ;(quoted diff) +0
-0b/cpu/arm926ejs/kirkwood/Makefile index d73e210..bd6e773 100644
cpu/arm926ejs/kirkwood/Makefile +0
-0@@ -28,6 +28,7 @@ LIB = $(obj)lib$(SOC).a
Quoted 5 lines
cpu/arm926ejs/kirkwood/Makefile LIB = $(obj)lib$(SOC).a · line 31
Quoted 3 lines
cpu/arm926ejs/kirkwood/Makefile +1
-0COBJS-y = dram.o COBJS-y += cpu.o +COBJS-y += gpio.oIt would be good if you use
CONFIG_KIRKWOOD_GPIOto enable this, since gpio support may not be required on other platforms
OK
Quoted 19 lines
Quoted 9 lines
cpu/arm926ejs/kirkwood/Makefile +0
-0COBJS-y += mpp.o COBJS-y += timer.o(quoted diff) +0
-0
b/cpu/arm926ejs/kirkwood/gpio.cnew file mode 100644 index 0000000..2cf1eb2cpu/arm926ejs/kirkwood/gpio.c line 9
Quoted 9 lines
cpu/arm926ejs/kirkwood/gpio.c new file +9
-0@@ -0,0 +1,144 @@ +/* +* arch/arm/plat-orion/gpio.c +* +* Marvell Orion SoC GPIO handling. +* +* This file is licensed under the terms of the GNU General Public +* License version 2. This program is licensed "as is" without any +* warranty of any kind, whether express or implied. +*/ Have you created this file or fetched from kernel?
I've fetched it from kernel - how should i document this? Is the kernel revision also needed?
Thanks,
Dieter
Quoted 4 lines
Regards..
Prafulla . .
PATCH 1/1 Kirkwood: add Marvell Sheevaplug gpio support
In reply to a message not in the archiveAm Montag 29 Juni 2009 10:15:22 schrieb Prafulla Wadaskar:
Quoted 28 lines
Quoted 17 lines
-----Original Message-----
From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de]
Sent: Monday, June 29, 2009 1:33 PM
To: u-boot at lists.denx.de
Cc: Prafulla Wadaskar
Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio supportHi List,
this if my first patch which goes to the wild. So please don't be croos with me if I made some stupid thing :) Any comments or feedback would be very welcome!
Is it common that the patch writer gives his Signed-off-by or who is responsible for that?
Quoted 8 lines
Cheers,
DieterFrom
e89ebedf1528e821e504c91af802687efb21533bMon Sep 17 00:00:00 2001
From: Dieter Kiermaier <[email protected]>
Date: Fri, 26 Jun 2009 14:45:13 +0200
Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio supportSigned-off-by is MUST
Quoted 1 line
Quoted 9 lines
Quoted 6 lines
--- board/Marvell/sheevaplug/sheevaplug.c | 1 + cpu/arm926ejs/kirkwood/Makefile | 1 + cpu/arm926ejs/kirkwood/gpio.c | 144 +++++++++++++++++++++++++++++++++ include/asm-arm/arch-kirkwood/gpio.h | 43 ++++++++++Spilt this patch into two, 1. gpio support for Kirkwood SOC and 2. Sheevaplug updates Move gpio stuff to
drivers/gpio/
Is it ok to leave gpio.h file in include/asm-arm/arch-kirkwood/ ?
Thanks,
Dieter