HTC Dream camera support for staging
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 8 lines · Pavel Machek
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
when this patch will be leaving the "staging" state, it will have to be converted to use v4l2-subdev API and submitted to linux-media.
Quoted 2 lines
Signed-off-by Pavel Machek <[email protected]>Cc Brian Swetland <[email protected]>
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Quoted 8 lines · Guennadi Liakhovetski
Quoted 6 lines · Pavel Machek
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
Quoted 5 lines
Quoted 2 lines
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
when this patch will be leaving the "staging" state, it will have to be converted to use v4l2-subdev API and submitted to linux-media.
Sounds reasonable. All staging patches are submitted to the respective subsystems for inclusion in order to move out of them. So that's nothing new.
thanks,
greg k-h
Quoted 11 lines · Pavel Machek
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
Signed-off-by Pavel Machek <[email protected]>Cc Brian Swetland <[email protected]>
Can you resubmit it with the original author descriptions? It's not fair to them to have it shown up as coming from you.
thanks,
greg k-h
Quoted 7 lines · Greg KH
Quoted 6 lines · Pavel Machek
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
Quoted 8 lines
Quoted 5 lines
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
Signed-off-by Pavel Machek <[email protected]>Cc Brian Swetland <[email protected]>Can you resubmit it with the original author descriptions? It's not fair to them to have it shown up as coming from you.
Yes, done... and thanks.
Brian... I'd like to submit qdsp5 and smd code, too. Who should be listed as their authors?
Oh and... thanks for the serial debugging cable. After short fight (using ttyMSM2, not ttyS0 took me a while to figure), it seems to work.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 14 lines · Pavel Machek
Quoted 13 lines · Greg KH
Quoted 11 lines · Pavel Machek
This patch adds driver for HTC Dream camera. I guess driver is slightly higher quality than usual for staging/ , but it is fairly big and I don't feel like doing all the cleanups myself. Also some parts can probably be removed, as they did not end up in shipping hardware..
The driver is actually so big that I'll attach it gzipped, otherwise it would not pass maillist limits.
Signed-off-by Pavel Machek <[email protected]>Cc Brian Swetland <[email protected]>
Quoted 7 lines
Quoted 2 lines
Can you resubmit it with the original author descriptions? It's not fair to them to have it shown up as coming from you.
Yes, done... and thanks.
Brian... I'd like to submit qdsp5 and smd code, too. Who should be listed as their authors?
smd is pretty much my fault at this point, though Arve hacks on the PM-related bits.
The latest incarnation of the rpcrouter is me, with a lot of the original work by Iliyan, based heavily on the work Qualcomm did (thus their copyright on it as well as Google's).
qdsp5 is Iliyan.
Might be worth breaking these into at least three pieces (smd, rpcrouter, qdsp5)?
Are you highly opposed to having smd and rpcrouter under arch/arm/mach-msm? They're (for better or worse) pretty integral to the core operation of the platform (suspend/resume and a lot of other core SoC functions require coordination with the modem core).
The qdsp5 stuff could exist elsewhere easily (though I'm not sure where the logical place is), and stuff on top of it like the v4l2 camera stuff has obvious homes in the usual driver hierarchy.
Brian
Hi!
Quoted 11 lines
Quoted 7 lines
Quoted 2 lines
Can you resubmit it with the original author descriptions? It's not fair to them to have it shown up as coming from you.
Yes, done... and thanks.
Brian... I'd like to submit qdsp5 and smd code, too. Who should be listed as their authors?
smd is pretty much my fault at this point, though Arve hacks on the PM-related bits.
Quoted 8 lines
The latest incarnation of the rpcrouter is me, with a lot of the original work by Iliyan, based heavily on the work Qualcomm did (thus their copyright on it as well as Google's).
qdsp5 is Iliyan.
Might be worth breaking these into at least three pieces (smd, rpcrouter, qdsp5)?
Sorry, I already submitted the patch. I just listed everyone I could find in the sources in From: ; that included san@google but not Arve. I hope that's not too bad.
Quoted 4 lines
Are you highly opposed to having smd and rpcrouter under
arch/arm/mach-msm? They're (for better or worse) pretty integral to the core operation of the platform (suspend/resume and a lot of other core SoC functions require coordination with the modem core).
I am not opposed to having the code under mach-msm/ ... it would be actually preffered. But it is quite a lot of code, and I guess it makes sense to clean it up in staging/ then move it to the proper place.
Alternatively if you can create nice git series for rmk/-next; that would work, too.
But I guess that staging/ stuff is quite easy to remove, and useful for people that want to use the phones in the meantime :-).
Quoted 3 lines
The qdsp5 stuff could exist elsewhere easily (though I'm not sure where the logical place is), and stuff on top of it like the v4l2 camera stuff has obvious homes in the usual driver hierarchy.
Ack.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 17 lines · Pavel Machek
Hi!
Quoted 15 lines
Quoted 7 lines
Quoted 2 lines
Can you resubmit it with the original author descriptions? It's not fair to them to have it shown up as coming from you.
Yes, done... and thanks.
Brian... I'd like to submit qdsp5 and smd code, too. Who should be listed as their authors?
smd is pretty much my fault at this point, though Arve hacks on the PM-related bits.
The latest incarnation of the rpcrouter is me, with a lot of the original work by Iliyan, based heavily on the work Qualcomm did (thus their copyright on it as well as Google's).
Quoted 8 lines
Quoted 4 lines
qdsp5 is Iliyan.
Might be worth breaking these into at least three pieces (smd, rpcrouter, qdsp5)?
Sorry, I already submitted the patch. I just listed everyone I could find in the sources in From: ; that included san@google but not Arve. I hope that's not too bad.
Please split the patch up into the different pieces, with the different authors. You shouldn't be sending patches that do more than one thing at a time anyway :)
thanks,
greg k-h
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 1 line · Brian Swetland
(arve -- see below about matrix driver)
Arve, can you help?
Quoted 10 lines · Pavel Machek
Quoted 4 lines
Quoted 2 lines
The NAND and USB support is much more contained.
Well.. NAND scares me a bit -- and I'm happy with SD card for now.
Well, you actually can't overwrite the bootloader with the way the NAND partitions are protected and made visible to the arm11, and the bootloader can reflash the boot/recovery/system/user partitions via usb using fastboot.
Ok, good to know.
Quoted 8 lines
Quoted 1 line
USB support seems complex because it duplicates USB gadget framework :-(.
Actually we have both. We did the function framework before the gadget framework had multifunction/composite support, but we're now moving away from that since the necessary functionality is in gadget now. The latest 2.6.29 tree on our side has a gadget driver for the USB client controller and an "android" gadget that handles the adb protocol function and ums function.
ums == mass storage? What is adb? ... aha, adb is the debugger.
Quoted 5 lines
Quoted 2 lines
gpio_matrix: I thought in-tree zaurus keypad driver has recently became generic enough to almost replace this?Looping Arve in. I think he had issues with lack of phantom key detection, etc with that.
Arve, can you help?
Quoted 8 lines
Quoted 5 lines
+config
TOUCHSCREEN_ELAN_I2C_8232
/
+configTOUCHSCREEN_SYNAPTICS_I2C_RMI...which one is it on Dream?
Both, possibly. HTC used elan as a second source, so some devices will use elan, some use synaptics.
Is there easy way to tell the machines apart? Are there any hardware differences (besides case color and touchscreen chip)?
Quoted 1 line
Dream is definitely not the last Android device with a keyboard.
Cool.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 11 lines
Quoted 9 lines
Quoted 6 lines
+config
TOUCHSCREEN_ELAN_I2C_8232
/
+configTOUCHSCREEN_SYNAPTICS_I2C_RMI...which one is it on Dream?
Both, possibly. HTC used elan as a second source, so some devices will use elan, some use synaptics.
Is there easy way to tell the machines apart?
cat /sys/class/input/*/name seems to work; I have synaptics here.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Mon, Jul 13, 2009 at 1:27 PM, Pavel Machek<[email protected]> wrote:
...
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
gpio_matrix: I thought in-tree zaurus keypad driver has recently became generic enough to almost replace this?
I would recommend using our driver since it allows multiple input types in the same device. The generic matrix driver may work, but you will not get the power and camera keys in the same device. The generic driver also does not yet handle phantom keys, so if you for instance press right-alt+right-shift+p you will also get 9. Our gpio input driver also handles the trackball.
I have also seen devices that put the trackball click in the keypad matrix which means we have to change our gpio input driver to create multiple input devices. That change would also allow the two keypads on the G1 to be separate input devices which would allow both menu keys to report KEY_MENU.
Signature · 1 line
Arve Hjønnevåg
Quoted 6 lines · Arve Hj?nnev?g
On Mon, Jul 13, 2009 at 1:27 PM, Pavel Machek<[email protected]> wrote:
...Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
gpio_matrix: I thought in-tree zaurus keypad driver has recently became generic enough to almost replace this?
Quoted 6 lines
I would recommend using our driver since it allows multiple input types in the same device. The generic matrix driver may work, but you will not get the power and camera keys in the same device. The generic driver also does not yet handle phantom keys, so if you for instance press right-alt+right-shift+p you will also get 9. Our gpio input driver also handles the trackball.
Well, matrix_keypad.c will need to be improved, then... Merging duplicate code is not really an option.
Quoted 5 lines
I have also seen devices that put the trackball click in the keypad matrix which means we have to change our gpio input driver to create multiple input devices. That change would also allow the two keypads on the G1 to be separate input devices which would allow both menu keys to report
KEY_MENU.
Ok, I guess we should discuss this on linux-input.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html