Skip to contentSkip to conversation

Move of_node_to_nid to generic location

DISCUSSION Michal Simek 4 participants 5 messages Jun 29, 2009

lore
Share & tools
lore
#0 lore raw

Hi All,

I have on my list one task which needs to be discuss with you. I look at of_node_to_nid for non NUMA systems. I think we should move this function to asm-generic/topology.h.

This function is used for powerpc, sparc, microblaze (and maybe future arm?)

Arnd what do you think?

Michal

Signature · 2 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
#1 lore raw
Quoted 5 lines · Michal Simek

Hi All,

I have on my list one task which needs to be discuss with you. I look at of_node_to_nid for non NUMA systems. I think we should move this function to asm-generic/topology.h.

I'm in the process of moving a bunch of stuff out of the various prom.c files and into drivers/of/*.c. If this is a common function, then I think it should go there.

Quoted 1 line

This function is used for powerpc, sparc, microblaze (and maybe future arm?)

PowerPC uses it. Other than that I don't know.

g.

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
#2 lore raw
Quoted 10 lines · Grant Likely
Quoted 5 lines · Michal Simek

Hi All,

I have on my list one task which needs to be discuss with you. I look at of_node_to_nid for non NUMA systems. I think we should move this function to asm-generic/topology.h.

I'm in the process of moving a bunch of stuff out of the various prom.c files and into drivers/of/*.c. If this is a common function, then I think it should go there.

I agree, it fits better into one of the 'of' headers than the topology header. Maybe include/linux/of_device.h or include/linux/of.h?

	Arnd <><
#3 lore raw
In reply to Grant Likely

From: Grant Likely <[email protected]>
Date: Mon, 29 Jun 2009 09:52:44 -0600

Quoted 4 lines · Michal Simek
Quoted 1 line

This function is used for powerpc, sparc, microblaze (and maybe future arm?)

PowerPC uses it. Other than that I don't know.

Sparc64 definitely uses it.

#4 lore raw
Quoted 8 lines · David Miller

From: Grant Likely <[email protected]>
Date: Mon, 29 Jun 2009 09:52:44 -0600

Quoted 3 lines · Michal Simek
Quoted 1 line

This function is used for powerpc, sparc, microblaze (and maybe future arm?)

PowerPC uses it. Other than that I don't know.

Sparc64 definitely uses it.

of_node_nid is called from of_device_register function and could be used by all "fdt" arch. Anyway I think that we found a solution for it.
Grant can you please incorporate this changes to your patches (just move implementation for non NUMA systems)?
IMHO of_device.h is the best one.

Thanks,
Michal

Signature · 2 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854