Skip to contentSkip to conversation

hwmon: Add support for TI's

PATCH Applied Andre Prendel 3 participants 8 messages Jun 26, 2009 – Jun 30, 2009

lore
Share & tools
lore
#0 lore raw

v2 cover hwmon: Add support for TI's

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Jean, I know you're on vacation, so take your time :)

BTW I spend some time with my girlfriend at the Cote d'Azur last year. Probably the best vacation I've ever had. But speaking french is very difficult :)

Thanks,
Andre

---
 Documentation/hwmon/tmp421 |   36 ++++
 drivers/hwmon/Kconfig      |   10 +
 drivers/hwmon/Makefile     |    1 
 drivers/hwmon/tmp421.c     |  349 +++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 396 insertions(+)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Hi,

Quoted 7 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

looks good to me,

Regards,

Hans

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw
In reply to Andre Prendel
Quoted 8 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Quoted 3 lines

BTW I spend some time with my girlfriend at the Cote d'Azur last year. Probably the best vacation I've ever had. But speaking french is very difficult :)

Yes French is indeed very difficult :( but we have beautiful landscapes and excellent cuisine :)

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#3 lore raw
In reply to Andre Prendel
Quoted 11 lines · Jean Delvare
Quoted 8 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Is the driver scheduled for 2.6.32 or the next rc?

Quoted 6 lines
Quoted 3 lines

BTW I spend some time with my girlfriend at the Cote d'Azur last year. Probably the best vacation I've ever had. But speaking french is very difficult :)

Yes French is indeed very difficult :( but we have beautiful landscapes and excellent cuisine :)

You're right :)

Thanks,
Andre

Quoted 2 lines
Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Andre Prendel
Quoted 9 lines · Andre Prendel
Quoted 8 lines · Jean Delvare
Quoted 7 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Is the driver scheduled for 2.6.32 or the next rc?

2.6.32.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#5 lore raw
In reply to Andre Prendel
Quoted 5 lines · Jean Delvare
Quoted 4 lines · Andre Prendel
Quoted 3 lines · Jean Delvare
Quoted 2 lines · Andre Prendel

Hello Jean, Hans,

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Done.

Quoted 3 lines
Quoted 1 line

Is the driver scheduled for 2.6.32 or the next rc?

2.6.32.

Thanks,
Andre

Quoted 2 lines
Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#6 lore raw
In reply to Andre Prendel
Quoted 11 lines · Andre Prendel
Quoted 10 lines · Jean Delvare
Quoted 9 lines · Andre Prendel
Quoted 8 lines · Jean Delvare
Quoted 7 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Done.

Thanks. Care to add support to sensors-detect too?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#7 lore raw
In reply to Andre Prendel
Quoted 12 lines · Jean Delvare
Quoted 11 lines · Andre Prendel
Quoted 10 lines · Jean Delvare
Quoted 9 lines · Andre Prendel
Quoted 8 lines · Jean Delvare
Quoted 7 lines · Andre Prendel

Hello Jean, Hans,

Here is an updated version of the tmp421 driver. I've fixed the issues according to your review. Please take a closer look at the is_visible() callback of the sysfs group. I'm using the attributes' index to decide whether the file is visible or not.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

Jean, I know you're on vacation, so take your time :)

Now that the wiki is back, please update the TMP421 etc. entry.

Done.

Thanks. Care to add support to sensors-detect too?

I will have a look at it. But as I said, no time at the moment. I will move 550km back to my hometown for a new job.

Quoted 2 lines
Signature · 1 line
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors