power_supply: add an 'error' sysfs device that displays raw errors OLPC battery
PATCH 3/5 power_supply: add an 'error' sysfs device that displays raw errors OLPC battery
Grab the error code from EC_BAT_ERRCODE and let the user see it (rather than attempting to decode it as we do with PROP_HEALTH) with a separate error sysfs file.
Signed-off-by Andres Salomon <[email protected]>
--- drivers/power/olpc_battery.c | 31 +++++++++++++++++++++++++++++++ 1 files changed, 31 insertions(+), 0 deletions(-)
drivers/power/olpc_battery.c +31 -0
@@ -373,6 +373,30 @@ static struct bin_attribute olpc_bat_eeprom = { .read = olpc_bat_eeprom_read, }; +/* Allow userspace to see the specific error value pulled from the EC */ + +static ssize_t olpc_bat_error_read (struct device *dev, +struct device_attribute *attr,char *buf) +{ +uint8_t ec_byte; +ssize_t ret; + + ret =olpc_ec_cmd (EC_BAT_ERRCODE ,NULL ,0 , &ec_byte,1 ); +if (ret <0 ) +return ret; + +return sprintf (buf,"%d\n" , ec_byte); +} + +static struct device_attribute olpc_bat_error = { + .attr = { + .name ="error" , + .mode =S_IRUGO , + }, + .show = olpc_bat_error_read, + .store =NULL , +}; +/********************************************************************* * Initialisation *********************************************************************/
@@ -436,8 +460,14 @@ static int __init olpc_bat_init(void)if (ret) goto eeprom_failed; + ret =device_create_file (olpc_bat.dev, &olpc_bat_error); +if (ret) + goto error_failed; + goto success; +error_failed: +device_remove_bin_file (olpc_bat.dev, &olpc_bat_eeprom); eeprom_failed:power_supply_unregister (&olpc_bat); battery_failed:
@@ -450,6 +480,7 @@ success: static void __exit olpc_bat_exit(void) { +device_remove_file (olpc_bat.dev, &olpc_bat_error);device_remove_bin_file (olpc_bat.dev, &olpc_bat_eeprom);power_supply_unregister (&olpc_bat);power_supply_unregister (&olpc_ac);
Signature · 1 line
1.5.6.5