configure: don't assume presence of sdl-config
PATCH 1/1 configure: don't assume presence of sdl-config
Hi!
Don't assume sdl-config is present when checking if SDL is there. If sdl is not installed, configure prints this error:
sdl-config: No such file or directory
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
configure +10 -1
@@ -863,8 +863,17 @@ fi sdl_too_old=no +# Before we use sdl-config, check if it is there if test "$sdl" = "yes" ; then - sdl_config="sdl-config" + sdl_config=`which sdl-config` + if test $? -ne 0 ; then + # Clear content if sdl isn't installed. + # For example, Solaris 'which' prints "no sdl-config in $PATH" + sdl_config="" + sdl="no" + fi +fi +if test "$sdl" = "yes" -a -n "$sdl_config" ; then sdl=no sdl_static=no
Quoted 10 lines · Christoph Egger
Hi!
Don't assume sdl-config is present when checking if SDL is there. If sdl is not installed, configure prints this error:
sdl-config: No such file or directory
Signed-off-by Christoph Egger <[email protected]>
which sdl-config will result in an error message going to stderr if sdl-config is not found.
Regards,
Anthony Liguori
Quoted 6 lines · On Thursday 09 July 2009 21:55:29 Anthony Liguori wrote:
Quoted 5 lines · Christoph Egger
Hi!
Don't assume sdl-config is present when checking if SDL is there. If sdl is not installed, configure prints this error:
Quoted 6 lines
Quoted 3 lines
sdl-config: No such file or directory
Signed-off-by Christoph Egger <[email protected]>
which sdl-configwill result in an error message going to stderr if sdl-config is not found.
Right. The intention of the patch is to suppress this. It is enough when configure prints "sdl: no"
Christoph
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 11 lines · Christoph Egger
Quoted 9 lines · On Thursday 09 July 2009 21:55:29 Anthony Liguori wrote:
Quoted 7 lines · Christoph Egger
Hi!
Don't assume sdl-config is present when checking if SDL is there. If sdl is not installed, configure prints this error:
sdl-config: No such file or directory
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Christoph Egger <[email protected]>
which sdl-configwill result in an error message going to stderr if sdl-config is not found.Right. The intention of the patch is to suppress this. It is enough when configure prints "sdl: no"
Right, so the patch is unsuccessful in doing that :-)
You need something like which sdl-config 2> /dev/null
Regards,
Anthony Liguori
Quoted 3 lines
Christoph