Skip to contentSkip to conversation

buildfix: unknown option "-Wno-error=uninitialized"

PATCH In review Christoph Egger 2 participants 4 messages Jun 30, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 buildfix: unknown option "-Wno-error=uninitialized"

Hi!

Attached patch fixes the build error I get on NetBSD:
(NetBSD comes with gcc 4.1.3)

cc1: error: unrecognized command line option "-Wno-error=uninitialized"

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
rules.mak +1 -1
index defee1d..8561289 100644
@@ -1,6 +1,6 @@
 
 %.o: %.c
-	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
+	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
 
 %.o: %.S
 	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS    $(TARGET_DIR)$@")
#1 lore raw
Quoted 7 lines · Christoph Egger
rules.mak +0 -0
index defee1d..8561289 100644

rules.mak line 6

Quoted 7 lines
rules.mak +1 -1
@@ -1,6 +1,6 @@
 
  %.o: %.c
-	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
+	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
 
  %.o: %.S
  	$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,"  AS    $(TARGET_DIR)$@")

Should remove the -Werror too, it's set by ./configure.

Signature · 1 line
error compiling committee.c: too many arguments to function
#2 lore raw
Quoted 13 lines · On Tuesday 30 June 2009 12:05:25 Avi Kivity wrote:
Quoted 12 lines · Christoph Egger
rules.mak +0 -2
index defee1d..8561289 100644
@@ -1,6 +1,6 @@
 
  %.o: %.c
-	$(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror
-Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@") +	$(call

quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -c -o $@ $<," CC $(TARGET_DIR)$@")

Quoted 5 lines
Quoted 3 lines

%.o: %.S
$(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<," AS
$(TARGET_DIR)$@")

Should remove the -Werror too, it's set by ./configure.

Will you do this between applying the patch and 'git commit' or should I resend a diff ?

Christoph

Signature · 6 lines
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#3 lore raw
Quoted 7 lines · Christoph Egger
Quoted 2 lines

Should remove the -Werror too, it's set by ./configure.

Will you do this between applying the patch and 'git commit' or should I resend a diff ?

I'm not a qemu maintainer, so I can't commit the patch.

Signature · 1 line
error compiling committee.c: too many arguments to function