MMC driver for HTC Dream
From: San Mehat <[email protected]>
MMC Driver for HTC Dream. I picked the code up from Google git trees, removed stuff not strictly neccessary, and did a bit of cleanups. It still works :-).
drivers/mmc/host/Kconfig +7 -0
@@ -212,3 +212,10 @@ config MMC_TMIO help This provides support for the SD/MMC cell found in TC6393XB, T7L66XB and also ipaq ASIC3 + +config MMC_MSM7X00A + tristate "Qualcomm MSM 7X00A SDCC Controller Support" + depends on MMC && ARCH_MSM + help + This provides support for the SD/MMC cell found in the + MSM 7X00A controllers from Qualcomm.
drivers/mmc/host/Makefile +1 -0
@@ -27,4 +27,5 @@ endif obj-$(CONFIG_MMC_S3C) += s3cmci.o obj-$(CONFIG_MMC_SDRICOH_CS) += sdricoh_cs.o obj-$(CONFIG_MMC_TMIO) += tmio_mmc.o +obj-$(CONFIG_MMC_MSM7X00A) += msm_sdcc.o
drivers/mmc/host/msm_sdcc.c new file +1301 -0
1,301 lines not on this page · raw message
drivers/mmc/host/msm_sdcc.h new file +238 -0
238 lines not on this page · raw message
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[Pavel Machek <[email protected]>]
Quoted 5 lines
From: San Mehat <[email protected]>
MMC Driver for HTC Dream. I picked the code up from Google git trees, removed stuff not strictly neccessary, and did a bit of cleanups. It still works :-).
Hi Pavel,
I'm looping in San, who wrote the driver. Thanks a ton for doing all this work to help clean stuff up and push toward mainline. Could you include the original driver authors (the git history should show them and often they're mentioned in an Author: line under the copyright/ license banners) on to: or cc: when you send out patches?
I forwarded the original mail to San so he should have this patch intact.
Thanks!
Brian
Quoted 7 lines · Brian Swetland
[Pavel Machek <[email protected]>]
Quoted 5 lines
From: San Mehat <[email protected]>
MMC Driver for HTC Dream. I picked the code up from Google git trees, removed stuff not strictly neccessary, and did a bit of cleanups. It still works :-).
Quoted 7 lines
Hi Pavel,
I'm looping in San, who wrote the driver. Thanks a ton for doing all this work to help clean stuff up and push toward mainline. Could you include the original driver authors (the git history should show them and often they're mentioned in an Author: line under the copyright/ license banners) on to: or cc: when you send out patches?
Oops, I put San in From: (which should give him proper credit) but forgot to add him to Cc list. Sorry.
Quoted 2 lines
I forwarded the original mail to San so he should have this patch intact.
Thanks!
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
cover msm_sdcc: A few more cleanups
In reply to Pavel MachekPerhaps these are appropriate as well. Uncompiled, I haven't set up an ARM cross compiler yet.
Joe Perches (3):
msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( msm_sdcc.c: stylistic cleaning
msm_sdcc.c: Move overly indented code to separate function
drivers/mmc/host/msm_sdcc.c | 274 ++++++++++++++++++++----------------------- 1 files changed, 129 insertions(+), 145 deletions(-)
PATCH 1/3 msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>(
--- drivers/mmc/host/msm_sdcc.c | 105 +++++++++++++++++++------------------------ 1 files changed, 46 insertions(+), 59 deletions(-)
drivers/mmc/host/msm_sdcc.c +46 -59
@@ -58,8 +58,6 @@ static unsigned int msmsdcc_sdioirq;#define PIO_SPINMAX 30#define CMD_SPINMAX 20 - -static void msmsdcc_start_command (struct msmsdcc_host *host,struct mmc_command *cmd,u32 c);
@@ -127,7 +125,7 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,BUG_ON (!mrq);if (!(result &DMOV_RSLT_VALID )) { -printk (KERN_ERR "msmsdcc: Invalid DataMover result\n" ); +pr_err ("msmsdcc: Invalid DataMover result\n" ); goto out; }
@@ -136,14 +134,13 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd, }else {/* Error or flush */ if (result &DMOV_RSLT_ERROR ) -printk (KERN_ERR "%s: DMA error (0x%.8x)\n" , +pr_err ("%s: DMA error (0x%.8x)\n" ,mmc_hostname (host->mmc), result);if (result &DMOV_RSLT_FLUSH ) -printk (KERN_ERR "%s: DMA channel flushed (0x%.8x)\n" , +pr_err ("%s: DMA channel flushed (0x%.8x)\n" ,mmc_hostname (host->mmc), result);if (err) -printk (KERN_ERR -"Flush data: %.8x %.8x %.8x %.8x %.8x %.8x\n" , +pr_err ("Flush data: %.8x %.8x %.8x %.8x %.8x %.8x\n" , err->flush[0 ], err->flush[1 ], err->flush[2 ], err->flush[3 ], err->flush[4 ], err->flush[5 ]);if (!mrq->data->error)
@@ -248,7 +245,7 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) host->dma.num_ents, host->dma.dir);if (n != host->dma.num_ents) { -printk (KERN_ERR "%s: Unable to map in all sg elements\n" , +pr_err ("%s: Unable to map in all sg elements\n" ,mmc_hostname (host->mmc)); host->dma.sg =NULL ; host->dma.num_ents =0 ;
@@ -393,24 +390,23 @@ msmsdcc_data_err(struct msmsdcc_host *host, struct mmc_data *data, unsigned int status) {if (status &MCI_DATACRCFAIL ) { -printk (KERN_ERR "%s: Data CRC error\n" , -mmc_hostname (host->mmc)); -printk (KERN_ERR "%s: opcode 0x%.8x\n" , __func__, +pr_err ("%s: Data CRC error\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: opcode 0x%.8x\n" , __func__, data->mrq->cmd->opcode); -printk (KERN_ERR "%s: blksz %d, blocks %d\n" , __func__, +pr_err ("%s: blksz %d, blocks %d\n" , __func__, data->blksz, data->blocks); data->error = -EILSEQ ; }else if (status &MCI_DATATIMEOUT ) { -printk (KERN_ERR "%s: Data timeout\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: Data timeout\n" ,mmc_hostname (host->mmc)); data->error = -ETIMEDOUT ; }else if (status &MCI_RXOVERRUN ) { -printk (KERN_ERR "%s: RX overrun\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: RX overrun\n" ,mmc_hostname (host->mmc)); data->error = -EIO ; }else if (status &MCI_TXUNDERRUN ) { -printk (KERN_ERR "%s: TX underrun\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: TX underrun\n" ,mmc_hostname (host->mmc)); data->error = -EIO ; }else { -printk (KERN_ERR "%s: Unknown error (0x%.8x)\n" , +pr_err ("%s: Unknown error (0x%.8x)\n" ,mmc_hostname (host->mmc), status); data->error = -EIO ; }
@@ -566,8 +562,7 @@ static void msmsdcc_do_cmdirq(struct msmsdcc_host *host, uint32_t status) cmd->error = -ETIMEDOUT ; }else if (status &MCI_CMDCRCFAIL && cmd->flags &MMC_RSP_CRC ) { -printk (KERN_ERR "%s: Command CRC error\n" , -mmc_hostname (host->mmc)); +pr_err ("%s: Command CRC error\n" ,mmc_hostname (host->mmc)); cmd->error = -EILSEQ ; }
@@ -759,8 +754,8 @@ msmsdcc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)if (ios->clock != host->clk_rate) { rc =clk_set_rate (host->clk, ios->clock);if (rc <0 ) -printk (KERN_ERR -"Error setting clock rate (%d)\n" , rc); +pr_err ("%s: Error setting clock rate (%d)\n" , +mmc_hostname (host->mmc), rc);else host->clk_rate = ios->clock; }
@@ -848,9 +843,8 @@ msmsdcc_check_status(unsigned long data) status = host->plat->status (mmc_dev (host->mmc)); host->eject = !status;if (status ^ host->oldstat) { -printk (KERN_INFO -"%s: Slot status change detected (%d -> %d)\n" , -mmc_hostname (host->mmc), host->oldstat, status); +pr_info ("%s: Slot status change detected (%d -> %d)\n" , +mmc_hostname (host->mmc), host->oldstat, status);if (status)mmc_detect_change (host->mmc, (5 *HZ ) /2 );else
@@ -900,13 +894,13 @@ msmsdcc_command_expired(unsigned long _data) mrq = host->curr.mrq;if (!mrq) { -printk (KERN_INFO "%s: Command expiry misfire\n" , -mmc_hostname (host->mmc)); +pr_info ("%s: Command expiry misfire\n" , +mmc_hostname (host->mmc));spin_unlock_irqrestore (&host->lock, flags);return ; } -printk (KERN_ERR "%s: Command timeout (%p %p %p %p)\n" , +pr_err ("%s: Command timeout (%p %p %p %p)\n" ,mmc_hostname (host->mmc), mrq, mrq->cmd, mrq->data, host->dma.sg);
@@ -937,7 +931,7 @@ msmsdcc_init_dma(struct msmsdcc_host *host) &host->dma.nc_busaddr, GFP_KERNEL);if (host->dma.nc ==NULL ) { -printk (KERN_ERR "Unable to allocate DMA buffer\n" ); +pr_err ("Unable to allocate DMA buffer\n" );return -ENOMEM ; }memset (host->dma.nc,0x00 ,sizeof (struct msmsdcc_nc_dmadata ));
@@ -980,7 +974,7 @@ msmsdcc_probe(struct platform_device *pdev)/* must have platform data */ if (!plat) { -printk (KERN_ERR "%s: Platform data not available\n" , __func__); +pr_err ("%s: Platform data not available\n" , __func__); ret = -EINVAL ; goto out; }
@@ -989,7 +983,7 @@ msmsdcc_probe(struct platform_device *pdev)return -EINVAL ;if (pdev->resource ==NULL || pdev->num_resources <2 ) { -printk (KERN_ERR "%s: Invalid resource\n" , __func__); +pr_err ("%s: Invalid resource\n" , __func__);return -ENXIO ; }
@@ -1003,7 +997,7 @@ msmsdcc_probe(struct platform_device *pdev) "status_irq");if (!cmd_irqres || !pio_irqres || !memres) { -printk (KERN_ERR "%s: Invalid resource\n" , __func__); +pr_err ("%s: Invalid resource\n" , __func__);return -ENXIO ; }
@@ -1071,8 +1065,7 @@ msmsdcc_probe(struct platform_device *pdev) ret =clk_set_rate (host->clk, msmsdcc_fmin);if (ret) { -printk (KERN_ERR "%s: Clock rate set failed (%d)\n" , - __func__, ret); +pr_err ("%s: Clock rate set failed (%d)\n" , __func__, ret); goto clk_disable; }
@@ -1125,14 +1118,14 @@ msmsdcc_probe(struct platform_device *pdev)DRIVER_NAME " (slot)" , host);if (ret) { -printk (KERN_ERR "Unable to get slot IRQ %d (%d)\n" , - host->stat_irq, ret); +pr_err ("%s: Unable to get slot IRQ %d (%d)\n" , +mmc_hostname (mmc), host->stat_irq, ret); goto clk_disable; } }else if (plat->register_status_notify) { plat->register_status_notify (msmsdcc_status_notify_cb, host); }else if (!plat->status) -printk (KERN_ERR "%s: No card detect facilities available\n" , +pr_err ("%s: No card detect facilities available\n" ,mmc_hostname (mmc));else {init_timer (&host->timer);
@@ -1168,34 +1161,28 @@ msmsdcc_probe(struct platform_device *pdev)mmc_set_drvdata (pdev, mmc);mmc_add_host (mmc); -printk (KERN_INFO -"%s: Qualcomm MSM SDCC at 0x%016llx irq %d,%d dma %d\n" , -mmc_hostname (mmc), (unsigned long long )memres->start, - (unsigned int ) cmd_irqres->start, - (unsigned int ) host->stat_irq, host->dma.channel); -printk (KERN_INFO "%s: 4 bit data mode %s\n" ,mmc_hostname (mmc), - (mmc->caps &MMC_CAP_4_BIT_DATA ?"enabled" :"disabled" )); -printk (KERN_INFO "%s: MMC clock %u -> %u Hz, PCLK %u Hz\n" , -mmc_hostname (mmc), msmsdcc_fmin, msmsdcc_fmax, host->pclk_rate); -printk (KERN_INFO "%s: Slot eject status = %d\n" ,mmc_hostname (mmc), - host->eject); -printk (KERN_INFO "%s: Power save feature enable = %d\n" , -mmc_hostname (mmc), msmsdcc_pwrsave); +pr_info ("%s: Qualcomm MSM SDCC at 0x%016llx irq %d,%d dma %d\n" , +mmc_hostname (mmc), (unsigned long long )memres->start, + (unsigned int ) cmd_irqres->start, + (unsigned int ) host->stat_irq, host->dma.channel); +pr_info ("%s: 4 bit data mode %s\n" ,mmc_hostname (mmc), + (mmc->caps &MMC_CAP_4_BIT_DATA ?"enabled" :"disabled" )); +pr_info ("%s: MMC clock %u -> %u Hz, PCLK %u Hz\n" , +mmc_hostname (mmc), msmsdcc_fmin, msmsdcc_fmax, host->pclk_rate); +pr_info ("%s: Slot eject status = %d\n" ,mmc_hostname (mmc), host->eject); +pr_info ("%s: Power save feature enable = %d\n" , +mmc_hostname (mmc), msmsdcc_pwrsave);if (host->dma.channel !=-1 ) { -printk (KERN_INFO -"%s: DM non-cached buffer at %p, dma_addr 0x%.8x\n" , -mmc_hostname (mmc), host->dma.nc, host->dma.nc_busaddr); -printk (KERN_INFO -"%s: DM cmd busaddr 0x%.8x, cmdptr busaddr 0x%.8x\n" , -mmc_hostname (mmc), host->dma.cmd_busaddr, - host->dma.cmdptr_busaddr); +pr_info ("%s: DM non-cached buffer at %p, dma_addr 0x%.8x\n" , +mmc_hostname (mmc), host->dma.nc, host->dma.nc_busaddr); +pr_info ("%s: DM cmd busaddr 0x%.8x, cmdptr busaddr 0x%.8x\n" , +mmc_hostname (mmc), host->dma.cmd_busaddr, + host->dma.cmdptr_busaddr); }else -printk (KERN_INFO -"%s: PIO transfer enabled\n" ,mmc_hostname (mmc)); +pr_info ("%s: PIO transfer enabled\n" ,mmc_hostname (mmc));if (host->timer.function) -printk (KERN_INFO "%s: Polling status mode enabled\n" , -mmc_hostname (mmc)); +pr_info ("%s: Polling status mode enabled\n" ,mmc_hostname (mmc));return 0 ; cmd_irq_free:
Signature · 1 line
1.6.3.1.10.g659a0.dirty
PATCH 2/3 msm_sdcc.c: stylistic cleaning
In reply to Joe PerchesMake a bit more like typical kernel style
--- drivers/mmc/host/msm_sdcc.c | 43 ++++++++++++++++++++++++------------------- 1 files changed, 24 insertions(+), 19 deletions(-)
drivers/mmc/host/msm_sdcc.c +24 -19
@@ -43,7 +43,6 @@#include <mach/dma.h> #include <mach/htc_pwrsink.h> -#include "msm_sdcc.h" #define DRIVER_NAME "msm-sdcc"
@@ -96,16 +95,17 @@ msmsdcc_stop_data(struct msmsdcc_host *host)uint32_t msmsdcc_fifo_addr (struct msmsdcc_host *host) { -if (host->pdev_id ==1 ) +switch (host->pdev_id) { +case 1 :return MSM_SDC1_PHYS +MMCIFIFO ; -else if (host->pdev_id ==2 ) +case 2 :return MSM_SDC2_PHYS +MMCIFIFO ; -else if (host->pdev_id ==3 ) +case 3 :return MSM_SDC3_PHYS +MMCIFIFO ; -else if (host->pdev_id ==4 ) +case 4 :return MSM_SDC4_PHYS +MMCIFIFO ; -else -BUG (); + } +BUG ();return 0 ; }
@@ -154,8 +154,8 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,struct scatterlist *sg = host->dma.sg;int i; -for (i =0 ; i < host->dma.num_ents; i++, sg++) -flush_dcache_page (sg_page (sg)); +for (i =0 ; i < host->dma.num_ents; i++) +flush_dcache_page (sg_page (sg++)); } host->dma.sg =NULL ;
@@ -220,15 +220,20 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) nc = host->dma.nc; -if (host->pdev_id ==1 ) +switch (host->pdev_id) { +case 1 : crci =MSMSDCC_CRCI_SDC1 ; -else if (host->pdev_id ==2 ) +break ; +case 2 : crci =MSMSDCC_CRCI_SDC2 ; -else if (host->pdev_id ==3 ) +break ; +case 3 : crci =MSMSDCC_CRCI_SDC3 ; -else if (host->pdev_id ==4 ) +break ; +case 4 : crci =MSMSDCC_CRCI_SDC4 ; -else { +break ; +default : host->dma.sg =NULL ; host->dma.num_ents =0 ;return -ENOENT ;
@@ -242,7 +247,7 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) host->curr.user_pages =0 ; n =dma_map_sg (mmc_dev (host->mmc), host->dma.sg, - host->dma.num_ents, host->dma.dir); + host->dma.num_ents, host->dma.dir);if (n != host->dma.num_ents) { pr_err("%s: Unable to map in all sg elements\n",
@@ -316,7 +321,7 @@ msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data)memset (&host->pio,0 ,sizeof (host->pio)); clks = (unsigned long long )data->timeout_ns * host->clk_rate; -do_div (clks,1000000000UL ); +do_div (clks,NSECS_PER_SEC ); timeout = data->timeout_clks + (unsigned int )clks;writel (timeout, base +MMCIDATATIMER );
@@ -369,9 +374,9 @@ msmsdcc_start_command(struct msmsdcc_host *host, struct mmc_command *cmd, u32 c) c |=MCI_CPSM_RESPONSE ; } -if ((((cmd->opcode ==17 ) || (cmd->opcode ==18 )) || - ((cmd->opcode ==24 ) || (cmd->opcode ==25 ))) || - (cmd->opcode ==53 )) +if (cmd->opcode ==17 || cmd->opcode ==18 || + cmd->opcode ==24 || cmd->opcode ==25 || + cmd->opcode ==53 ) c |=MCI_CSPM_DATCMD ;if (cmd == cmd->mrq->stop)
Signature · 1 line
1.6.3.1.10.g659a0.dirty
PATCH 3/3 msm_sdcc.c: Move overly indented code to separate function
In reply to Joe Perches--- drivers/mmc/host/msm_sdcc.c | 126 ++++++++++++++++++++----------------------- 1 files changed, 59 insertions(+), 67 deletions(-)
drivers/mmc/host/msm_sdcc.c +59 -67
@@ -584,6 +584,62 @@ static void msmsdcc_do_cmdirq(struct msmsdcc_host *host, uint32_t status)msmsdcc_start_data (host, cmd->data); } +static void +msmsdcc_handle_irq_data (struct msmsdcc_host *host,struct mmc_data *data, +u32 status) +{ +/* Check for data errors */ +if (status & (MCI_DATACRCFAIL |MCI_DATATIMEOUT | +MCI_TXUNDERRUN |MCI_RXOVERRUN )) { +msmsdcc_data_err (host, data, status); + host->curr.data_xfered =0 ; +if (host->dma.sg) +msm_dmov_stop_cmd (host->dma.channel, + &host->dma.hdr,0 ); +else { +msmsdcc_stop_data (host); +if (!data->stop) +msmsdcc_request_end (host, data->mrq); +else +msmsdcc_start_command (host, data->stop,0 ); + } + } + +/* Check for data done */ +if (!host->curr.got_dataend && (status &MCI_DATAEND )) + host->curr.got_dataend =1 ; + +if (!host->curr.got_datablkend && (status &MCI_DATABLOCKEND )) + host->curr.got_datablkend =1 ; + +/* +* If DMA is still in progress, we complete via the completion handler +*/ +if (host->curr.got_dataend && host->curr.got_datablkend && + !host->dma.busy) { +/* +* There appears to be an issue in the controller where +* if you request a small block transfer (< fifo size), +* you may get your DATAEND/DATABLKEND irq without the +* PIO data irq. +* +* Check to see if there is still data to be read, +* and simulate a PIO irq. +*/ +if (readl (base +MMCISTATUS ) &MCI_RXDATAAVLBL ) +msmsdcc_pio_irq (1 , host); + +msmsdcc_stop_data (host); +if (!data->error) + host->curr.data_xfered = host->curr.xfer_size; + +if (!data->stop) +msmsdcc_request_end (host, data->mrq); +else +msmsdcc_start_command (host, data->stop,0 ); + } +} +static irqreturn_t msmsdcc_irq (int irq,void *dev_id) {
@@ -599,76 +655,12 @@ msmsdcc_irq(int irq, void *dev_id)struct mmc_data *data; status =readl (base +MMCISTATUS ); - status &= (readl (base +MMCIMASK0 ) | -MCI_DATABLOCKENDMASK ); + status &= (readl (base +MMCIMASK0 ) |MCI_DATABLOCKENDMASK );writel (status, base +MMCICLEAR ); data = host->curr.data; -if (data) { -/* Check for data errors */ -if (status & (MCI_DATACRCFAIL |MCI_DATATIMEOUT | -MCI_TXUNDERRUN |MCI_RXOVERRUN )) { -msmsdcc_data_err (host, data, status); - host->curr.data_xfered =0 ; -if (host->dma.sg) -msm_dmov_stop_cmd (host->dma.channel, - &host->dma.hdr,0 ); -else { -msmsdcc_stop_data (host); -if (!data->stop) -msmsdcc_request_end (host, - data->mrq); -else -msmsdcc_start_command (host, - data->stop, -0 ); - } - } - -/* Check for data done */ -if (!host->curr.got_dataend && (status &MCI_DATAEND )) - host->curr.got_dataend =1 ; - -if (!host->curr.got_datablkend && - (status &MCI_DATABLOCKEND )) { - host->curr.got_datablkend =1 ; - } - -if (host->curr.got_dataend && - host->curr.got_datablkend) { -/* -* If DMA is still in progress, we complete -* via the completion handler -*/ -if (!host->dma.busy) { -/* -* There appears to be an issue in the -* controller where if you request a -* small block transfer (< fifo size), -* you may get your DATAEND/DATABLKEND -* irq without the PIO data irq. -* -* Check to see if theres still data -* to be read, and simulate a PIO irq. -*/ -if (readl (base +MMCISTATUS ) & -MCI_RXDATAAVLBL ) -msmsdcc_pio_irq (1 , host); - -msmsdcc_stop_data (host); -if (!data->error) - host->curr.data_xfered = - host->curr.xfer_size; - -if (!data->stop) -msmsdcc_request_end (host, - data->mrq); -else -msmsdcc_start_command (host, - data->stop,0 ); - } - } - } +if (data) +msmsdcc_handle_irq_data (host, data, status);if (status & (MCI_CMDSENT |MCI_CMDRESPEND |MCI_CMDCRCFAIL |MCI_CMDTIMEOUT ) && host->curr.cmd) {
Signature · 1 line
1.6.3.1.10.g659a0.dirty
Re: [PATCH 0/3] msm_sdcc: A few more cleanups
In reply to Joe PerchesHi!
Quoted 9 lines
Perhaps these are appropriate as well. Uncompiled, I haven't set up an ARM cross compiler yet.
Signed-off-by Joe Perches <[email protected]>Joe Perches (3):
msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>(msm_sdcc.c: stylistic cleaning
msm_sdcc.c: Move overly indented code to separate function
They look good, but break compilation. With these fixes, it compiles & boots. Thanks!
drivers/mmc/host/msm_sdcc.c +3 -1
@@ -321,7 +321,7 @@ msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data)memset (&host->pio,0 ,sizeof (host->pio)); clks = (unsigned long long )data->timeout_ns * host->clk_rate; -do_div (clks,NSECS_PER_SEC ); +do_div (clks,NSEC_PER_SEC ); timeout = data->timeout_clks + (unsigned int )clks;writel (timeout, base +MMCIDATATIMER );
@@ -588,6 +588,8 @@ static void msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data, u32 status) { + void __iomem *base = host->base; +/* Check for data errors */ if (status & (MCI_DATACRCFAIL |MCI_DATATIMEOUT |MCI_TXUNDERRUN |MCI_RXOVERRUN )) {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH 0/3] msm_sdcc: A few more cleanups
drivers/mmc/host/msm_sdcc.c msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data) · line 324
Quoted 3 lines · Pavel Machek
drivers/mmc/host/msm_sdcc.c +1
-1-do_div (clks,NSECS_PER_SEC ); +do_div (clks,NSEC_PER_SEC );
Compiling is good. Submitting uncompiled patches not so good...
drivers/mmc/host/msm_sdcc.c static void · line 592
Quoted 6 lines
drivers/mmc/host/msm_sdcc.c +2
-0@@ -588,6 +588,8 @@ static void msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data, u32 status) { + void __iomem *base = host->base; +
I don't know how performance sensitive this is.
Maybe it should be inline and have base passed
as an argument.
Re: [PATCH 0/3] msm_sdcc: A few more cleanups
Quoted 6 lines · Joe Perches
drivers/mmc/host/msm_sdcc.c msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data) · line 324
Quoted 3 lines · Pavel Machek
drivers/mmc/host/msm_sdcc.c +1
-1-do_div (clks,NSECS_PER_SEC ); +do_div (clks,NSEC_PER_SEC );Compiling is good. Submitting uncompiled patches not so good...
:-) Thanks for doing the cleanups. You know, fixing two compile problems is easy compared to cleanups you did.
Can you fold those two fixups to your patches, or how to proceed?
Quoted 11 lines
drivers/mmc/host/msm_sdcc.c static void · line 592
Quoted 6 lines
drivers/mmc/host/msm_sdcc.c +2
-0@@ -588,6 +588,8 @@ static void msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data, u32 status) { + void __iomem *base = host->base; +I don't know how performance sensitive this is.
Maybe it should be inline and have base passed
as an argument.
I don't think it is _that_ performance critical.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
v2 cover msm_sdcc: cleanups
Hi Pavel.
Here's another slightly redone pass with your compile fixes.
In patch 3/3 I changed the argument list of handle_irq_data for a bit better localization of variable use.
Joe Perches (3):
msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>( msm_sdcc.c: stylistic cleaning
msm_sdcc.c: Move overly indented code to separate function
drivers/mmc/host/msm_sdcc.c | 282 ++++++++++++++++++++---------------------- 1 files changed, 134 insertions(+), 148 deletions(-)
PATCH v2 1/3 msm_sdcc.c: Convert printk(KERN_<level> to pr_<level>(
--- drivers/mmc/host/msm_sdcc.c | 105 +++++++++++++++++++------------------------ 1 files changed, 47 insertions(+), 58 deletions(-)
drivers/mmc/host/msm_sdcc.c +47 -58
@@ -127,7 +127,7 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,BUG_ON (!mrq);if (!(result &DMOV_RSLT_VALID )) { -printk (KERN_ERR "msmsdcc: Invalid DataMover result\n" ); +pr_err ("msmsdcc: Invalid DataMover result\n" ); goto out; }
@@ -136,14 +136,13 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd, }else {/* Error or flush */ if (result &DMOV_RSLT_ERROR ) -printk (KERN_ERR "%s: DMA error (0x%.8x)\n" , +pr_err ("%s: DMA error (0x%.8x)\n" ,mmc_hostname (host->mmc), result);if (result &DMOV_RSLT_FLUSH ) -printk (KERN_ERR "%s: DMA channel flushed (0x%.8x)\n" , +pr_err ("%s: DMA channel flushed (0x%.8x)\n" ,mmc_hostname (host->mmc), result);if (err) -printk (KERN_ERR -"Flush data: %.8x %.8x %.8x %.8x %.8x %.8x\n" , +pr_err ("Flush data: %.8x %.8x %.8x %.8x %.8x %.8x\n" , err->flush[0 ], err->flush[1 ], err->flush[2 ], err->flush[3 ], err->flush[4 ], err->flush[5 ]);if (!mrq->data->error)
@@ -248,7 +247,7 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) host->dma.num_ents, host->dma.dir);if (n != host->dma.num_ents) { -printk (KERN_ERR "%s: Unable to map in all sg elements\n" , +pr_err ("%s: Unable to map in all sg elements\n" ,mmc_hostname (host->mmc)); host->dma.sg =NULL ; host->dma.num_ents =0 ;
@@ -393,25 +392,24 @@ msmsdcc_data_err(struct msmsdcc_host *host, struct mmc_data *data, unsigned int status) {if (status &MCI_DATACRCFAIL ) { -printk (KERN_ERR "%s: Data CRC error\n" , -mmc_hostname (host->mmc)); -printk (KERN_ERR "%s: opcode 0x%.8x\n" , __func__, +pr_err ("%s: Data CRC error\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: opcode 0x%.8x\n" , __func__, data->mrq->cmd->opcode); -printk (KERN_ERR "%s: blksz %d, blocks %d\n" , __func__, +pr_err ("%s: blksz %d, blocks %d\n" , __func__, data->blksz, data->blocks); data->error = -EILSEQ ; }else if (status &MCI_DATATIMEOUT ) { -printk (KERN_ERR "%s: Data timeout\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: Data timeout\n" ,mmc_hostname (host->mmc)); data->error = -ETIMEDOUT ; }else if (status &MCI_RXOVERRUN ) { -printk (KERN_ERR "%s: RX overrun\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: RX overrun\n" ,mmc_hostname (host->mmc)); data->error = -EIO ; }else if (status &MCI_TXUNDERRUN ) { -printk (KERN_ERR "%s: TX underrun\n" ,mmc_hostname (host->mmc)); +pr_err ("%s: TX underrun\n" ,mmc_hostname (host->mmc)); data->error = -EIO ; }else { -printk (KERN_ERR "%s: Unknown error (0x%.8x)\n" , -mmc_hostname (host->mmc), status); +pr_err ("%s: Unknown error (0x%.8x)\n" , +mmc_hostname (host->mmc), status); data->error = -EIO ; } }
@@ -566,8 +564,7 @@ static void msmsdcc_do_cmdirq(struct msmsdcc_host *host, uint32_t status) cmd->error = -ETIMEDOUT ; }else if (status &MCI_CMDCRCFAIL && cmd->flags &MMC_RSP_CRC ) { -printk (KERN_ERR "%s: Command CRC error\n" , -mmc_hostname (host->mmc)); +pr_err ("%s: Command CRC error\n" ,mmc_hostname (host->mmc)); cmd->error = -EILSEQ ; }
@@ -759,8 +756,8 @@ msmsdcc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)if (ios->clock != host->clk_rate) { rc =clk_set_rate (host->clk, ios->clock);if (rc <0 ) -printk (KERN_ERR -"Error setting clock rate (%d)\n" , rc); +pr_err ("%s: Error setting clock rate (%d)\n" , +mmc_hostname (host->mmc), rc);else host->clk_rate = ios->clock; }
@@ -848,9 +845,8 @@ msmsdcc_check_status(unsigned long data) status = host->plat->status (mmc_dev (host->mmc)); host->eject = !status;if (status ^ host->oldstat) { -printk (KERN_INFO -"%s: Slot status change detected (%d -> %d)\n" , -mmc_hostname (host->mmc), host->oldstat, status); +pr_info ("%s: Slot status change detected (%d -> %d)\n" , +mmc_hostname (host->mmc), host->oldstat, status);if (status)mmc_detect_change (host->mmc, (5 *HZ ) /2 );else
@@ -900,13 +896,13 @@ msmsdcc_command_expired(unsigned long _data) mrq = host->curr.mrq;if (!mrq) { -printk (KERN_INFO "%s: Command expiry misfire\n" , -mmc_hostname (host->mmc)); +pr_info ("%s: Command expiry misfire\n" , +mmc_hostname (host->mmc));spin_unlock_irqrestore (&host->lock, flags);return ; } -printk (KERN_ERR "%s: Command timeout (%p %p %p %p)\n" , +pr_err ("%s: Command timeout (%p %p %p %p)\n" ,mmc_hostname (host->mmc), mrq, mrq->cmd, mrq->data, host->dma.sg);
@@ -937,7 +933,7 @@ msmsdcc_init_dma(struct msmsdcc_host *host) &host->dma.nc_busaddr, GFP_KERNEL);if (host->dma.nc ==NULL ) { -printk (KERN_ERR "Unable to allocate DMA buffer\n" ); +pr_err ("Unable to allocate DMA buffer\n" );return -ENOMEM ; }memset (host->dma.nc,0x00 ,sizeof (struct msmsdcc_nc_dmadata ));
@@ -980,7 +976,7 @@ msmsdcc_probe(struct platform_device *pdev)/* must have platform data */ if (!plat) { -printk (KERN_ERR "%s: Platform data not available\n" , __func__); +pr_err ("%s: Platform data not available\n" , __func__); ret = -EINVAL ; goto out; }
@@ -989,7 +985,7 @@ msmsdcc_probe(struct platform_device *pdev)return -EINVAL ;if (pdev->resource ==NULL || pdev->num_resources <2 ) { -printk (KERN_ERR "%s: Invalid resource\n" , __func__); +pr_err ("%s: Invalid resource\n" , __func__);return -ENXIO ; }
@@ -1003,7 +999,7 @@ msmsdcc_probe(struct platform_device *pdev) "status_irq");if (!cmd_irqres || !pio_irqres || !memres) { -printk (KERN_ERR "%s: Invalid resource\n" , __func__); +pr_err ("%s: Invalid resource\n" , __func__);return -ENXIO ; }
@@ -1071,8 +1067,7 @@ msmsdcc_probe(struct platform_device *pdev) ret =clk_set_rate (host->clk, msmsdcc_fmin);if (ret) { -printk (KERN_ERR "%s: Clock rate set failed (%d)\n" , - __func__, ret); +pr_err ("%s: Clock rate set failed (%d)\n" , __func__, ret); goto clk_disable; }
@@ -1125,14 +1120,14 @@ msmsdcc_probe(struct platform_device *pdev)DRIVER_NAME " (slot)" , host);if (ret) { -printk (KERN_ERR "Unable to get slot IRQ %d (%d)\n" , - host->stat_irq, ret); +pr_err ("%s: Unable to get slot IRQ %d (%d)\n" , +mmc_hostname (mmc), host->stat_irq, ret); goto clk_disable; } }else if (plat->register_status_notify) { plat->register_status_notify (msmsdcc_status_notify_cb, host); }else if (!plat->status) -printk (KERN_ERR "%s: No card detect facilities available\n" , +pr_err ("%s: No card detect facilities available\n" ,mmc_hostname (mmc));else {init_timer (&host->timer);
@@ -1168,34 +1163,28 @@ msmsdcc_probe(struct platform_device *pdev)mmc_set_drvdata (pdev, mmc);mmc_add_host (mmc); -printk (KERN_INFO -"%s: Qualcomm MSM SDCC at 0x%016llx irq %d,%d dma %d\n" , -mmc_hostname (mmc), (unsigned long long )memres->start, - (unsigned int ) cmd_irqres->start, - (unsigned int ) host->stat_irq, host->dma.channel); -printk (KERN_INFO "%s: 4 bit data mode %s\n" ,mmc_hostname (mmc), - (mmc->caps &MMC_CAP_4_BIT_DATA ?"enabled" :"disabled" )); -printk (KERN_INFO "%s: MMC clock %u -> %u Hz, PCLK %u Hz\n" , -mmc_hostname (mmc), msmsdcc_fmin, msmsdcc_fmax, host->pclk_rate); -printk (KERN_INFO "%s: Slot eject status = %d\n" ,mmc_hostname (mmc), - host->eject); -printk (KERN_INFO "%s: Power save feature enable = %d\n" , -mmc_hostname (mmc), msmsdcc_pwrsave); +pr_info ("%s: Qualcomm MSM SDCC at 0x%016llx irq %d,%d dma %d\n" , +mmc_hostname (mmc), (unsigned long long )memres->start, + (unsigned int ) cmd_irqres->start, + (unsigned int ) host->stat_irq, host->dma.channel); +pr_info ("%s: 4 bit data mode %s\n" ,mmc_hostname (mmc), + (mmc->caps &MMC_CAP_4_BIT_DATA ?"enabled" :"disabled" )); +pr_info ("%s: MMC clock %u -> %u Hz, PCLK %u Hz\n" , +mmc_hostname (mmc), msmsdcc_fmin, msmsdcc_fmax, host->pclk_rate); +pr_info ("%s: Slot eject status = %d\n" ,mmc_hostname (mmc), host->eject); +pr_info ("%s: Power save feature enable = %d\n" , +mmc_hostname (mmc), msmsdcc_pwrsave);if (host->dma.channel !=-1 ) { -printk (KERN_INFO -"%s: DM non-cached buffer at %p, dma_addr 0x%.8x\n" , -mmc_hostname (mmc), host->dma.nc, host->dma.nc_busaddr); -printk (KERN_INFO -"%s: DM cmd busaddr 0x%.8x, cmdptr busaddr 0x%.8x\n" , -mmc_hostname (mmc), host->dma.cmd_busaddr, - host->dma.cmdptr_busaddr); +pr_info ("%s: DM non-cached buffer at %p, dma_addr 0x%.8x\n" , +mmc_hostname (mmc), host->dma.nc, host->dma.nc_busaddr); +pr_info ("%s: DM cmd busaddr 0x%.8x, cmdptr busaddr 0x%.8x\n" , +mmc_hostname (mmc), host->dma.cmd_busaddr, + host->dma.cmdptr_busaddr); }else -printk (KERN_INFO -"%s: PIO transfer enabled\n" ,mmc_hostname (mmc)); +pr_info ("%s: PIO transfer enabled\n" ,mmc_hostname (mmc));if (host->timer.function) -printk (KERN_INFO "%s: Polling status mode enabled\n" , -mmc_hostname (mmc)); +pr_info ("%s: Polling status mode enabled\n" ,mmc_hostname (mmc));return 0 ; cmd_irq_free:
Signature · 1 line
1.6.3.1.10.g659a0.dirty
PATCH v2 2/3 msm_sdcc.c: stylistic cleaning
In reply to Joe PerchesMake a bit more like typical kernel style
--- drivers/mmc/host/msm_sdcc.c | 45 ++++++++++++++++++++++-------------------- 1 files changed, 24 insertions(+), 21 deletions(-)
drivers/mmc/host/msm_sdcc.c +24 -21
@@ -43,7 +43,6 @@#include <mach/dma.h> #include <mach/htc_pwrsink.h> -#include "msm_sdcc.h" #define DRIVER_NAME "msm-sdcc"
@@ -58,8 +57,6 @@ static unsigned int msmsdcc_sdioirq;#define PIO_SPINMAX 30#define CMD_SPINMAX 20 - -static void msmsdcc_start_command (struct msmsdcc_host *host,struct mmc_command *cmd,u32 c);
@@ -98,16 +95,17 @@ msmsdcc_stop_data(struct msmsdcc_host *host)uint32_t msmsdcc_fifo_addr (struct msmsdcc_host *host) { -if (host->pdev_id ==1 ) +switch (host->pdev_id) { +case 1 :return MSM_SDC1_PHYS +MMCIFIFO ; -else if (host->pdev_id ==2 ) +case 2 :return MSM_SDC2_PHYS +MMCIFIFO ; -else if (host->pdev_id ==3 ) +case 3 :return MSM_SDC3_PHYS +MMCIFIFO ; -else if (host->pdev_id ==4 ) +case 4 :return MSM_SDC4_PHYS +MMCIFIFO ; -else -BUG (); + } +BUG ();return 0 ; }
@@ -156,8 +154,8 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,struct scatterlist *sg = host->dma.sg;int i; -for (i =0 ; i < host->dma.num_ents; i++, sg++) -flush_dcache_page (sg_page (sg)); +for (i =0 ; i < host->dma.num_ents; i++) +flush_dcache_page (sg_page (sg++)); } host->dma.sg =NULL ;
@@ -222,15 +220,20 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) nc = host->dma.nc; -if (host->pdev_id ==1 ) +switch (host->pdev_id) { +case 1 : crci =MSMSDCC_CRCI_SDC1 ; -else if (host->pdev_id ==2 ) +break ; +case 2 : crci =MSMSDCC_CRCI_SDC2 ; -else if (host->pdev_id ==3 ) +break ; +case 3 : crci =MSMSDCC_CRCI_SDC3 ; -else if (host->pdev_id ==4 ) +break ; +case 4 : crci =MSMSDCC_CRCI_SDC4 ; -else { +break ; +default : host->dma.sg =NULL ; host->dma.num_ents =0 ;return -ENOENT ;
@@ -244,7 +247,7 @@ static int msmsdcc_config_dma(struct msmsdcc_host *host, struct mmc_data *data) host->curr.user_pages =0 ; n =dma_map_sg (mmc_dev (host->mmc), host->dma.sg, - host->dma.num_ents, host->dma.dir); + host->dma.num_ents, host->dma.dir);if (n != host->dma.num_ents) { pr_err("%s: Unable to map in all sg elements\n",
@@ -318,7 +321,7 @@ msmsdcc_start_data(struct msmsdcc_host *host, struct mmc_data *data)memset (&host->pio,0 ,sizeof (host->pio)); clks = (unsigned long long )data->timeout_ns * host->clk_rate; -do_div (clks,1000000000UL ); +do_div (clks,NSEC_PER_SEC ); timeout = data->timeout_clks + (unsigned int )clks;writel (timeout, base +MMCIDATATIMER );
@@ -371,9 +374,9 @@ msmsdcc_start_command(struct msmsdcc_host *host, struct mmc_command *cmd, u32 c) c |=MCI_CPSM_RESPONSE ; } -if ((((cmd->opcode ==17 ) || (cmd->opcode ==18 )) || - ((cmd->opcode ==24 ) || (cmd->opcode ==25 ))) || - (cmd->opcode ==53 )) +if (cmd->opcode ==17 || cmd->opcode ==18 || + cmd->opcode ==24 || cmd->opcode ==25 || + cmd->opcode ==53 ) c |=MCI_CSPM_DATCMD ;if (cmd == cmd->mrq->stop)
Signature · 1 line
1.6.3.1.10.g659a0.dirty
PATCH v2 3/3 msm_sdcc.c: Move overly indented code to separate function
In reply to Joe Perches--- drivers/mmc/host/msm_sdcc.c | 132 ++++++++++++++++++++---------------------- 1 files changed, 63 insertions(+), 69 deletions(-)
drivers/mmc/host/msm_sdcc.c +63 -69
@@ -584,6 +584,67 @@ static void msmsdcc_do_cmdirq(struct msmsdcc_host *host, uint32_t status)msmsdcc_start_data (host, cmd->data); } +static void +msmsdcc_handle_irq_data (struct msmsdcc_host *host,u32 status, +void __iomem *base) +{ +struct mmc_data *data = host->curr.data; + +if (!data) +return ; + +/* Check for data errors */ +if (status & (MCI_DATACRCFAIL |MCI_DATATIMEOUT | +MCI_TXUNDERRUN |MCI_RXOVERRUN )) { +msmsdcc_data_err (host, data, status); + host->curr.data_xfered =0 ; +if (host->dma.sg) +msm_dmov_stop_cmd (host->dma.channel, + &host->dma.hdr,0 ); +else { +msmsdcc_stop_data (host); +if (!data->stop) +msmsdcc_request_end (host, data->mrq); +else +msmsdcc_start_command (host, data->stop,0 ); + } + } + +/* Check for data done */ +if (!host->curr.got_dataend && (status &MCI_DATAEND )) + host->curr.got_dataend =1 ; + +if (!host->curr.got_datablkend && (status &MCI_DATABLOCKEND )) + host->curr.got_datablkend =1 ; + +/* +* If DMA is still in progress, we complete via the completion handler +*/ +if (host->curr.got_dataend && host->curr.got_datablkend && + !host->dma.busy) { +/* +* There appears to be an issue in the controller where +* if you request a small block transfer (< fifo size), +* you may get your DATAEND/DATABLKEND irq without the +* PIO data irq. +* +* Check to see if there is still data to be read, +* and simulate a PIO irq. +*/ +if (readl (base +MMCISTATUS ) &MCI_RXDATAAVLBL ) +msmsdcc_pio_irq (1 , host); + +msmsdcc_stop_data (host); +if (!data->error) + host->curr.data_xfered = host->curr.xfer_size; + +if (!data->stop) +msmsdcc_request_end (host, data->mrq); +else +msmsdcc_start_command (host, data->stop,0 ); + } +} +static irqreturn_t msmsdcc_irq (int irq,void *dev_id) {
@@ -596,79 +657,12 @@ msmsdcc_irq(int irq, void *dev_id)spin_lock (&host->lock); do { - struct mmc_data *data; status = readl(base + MMCISTATUS); - status &= (readl(base + MMCIMASK0) | - MCI_DATABLOCKENDMASK); + status &= (readl(base + MMCIMASK0) | MCI_DATABLOCKENDMASK); writel(status, base + MMCICLEAR); - data = host->curr.data; - if (data) { - /* Check for data errors */ - if (status & (MCI_DATACRCFAIL|MCI_DATATIMEOUT| - MCI_TXUNDERRUN|MCI_RXOVERRUN)) { - msmsdcc_data_err(host, data, status); - host->curr.data_xfered = 0; - if (host->dma.sg) - msm_dmov_stop_cmd(host->dma.channel, - &host->dma.hdr, 0); - else { - msmsdcc_stop_data(host); - if (!data->stop) - msmsdcc_request_end(host, - data->mrq); - else - msmsdcc_start_command(host, - data->stop, - 0); - } - } - - /* Check for data done */ - if (!host->curr.got_dataend && (status & MCI_DATAEND)) - host->curr.got_dataend = 1; - - if (!host->curr.got_datablkend && - (status & MCI_DATABLOCKEND)) { - host->curr.got_datablkend = 1; - } - - if (host->curr.got_dataend && - host->curr.got_datablkend) { - /* - * If DMA is still in progress, we complete - * via the completion handler - */ - if (!host->dma.busy) { - /* - * There appears to be an issue in the - * controller where if you request a - * small block transfer (< fifo size), - * you may get your DATAEND/DATABLKEND - * irq without the PIO data irq. - * - * Check to see if theres still data - * to be read, and simulate a PIO irq. - */ - if (readl(base + MMCISTATUS) & - MCI_RXDATAAVLBL) - msmsdcc_pio_irq(1, host); - - msmsdcc_stop_data(host); - if (!data->error) - host->curr.data_xfered = - host->curr.xfer_size; - - if (!data->stop) - msmsdcc_request_end(host, - data->mrq); - else - msmsdcc_start_command(host, - data->stop, 0); - } - } - } + msmsdcc_handle_irq_data(host, status, base); if (status & (MCI_CMDSENT | MCI_CMDRESPEND | MCI_CMDCRCFAIL | MCI_CMDTIMEOUT) && host->curr.cmd) {
Signature · 1 line
1.6.3.1.10.g659a0.dirty