kprobes: fix kprobe selftest configuration dependency
PATCH 1/1 kprobes: fix kprobe selftest configuration dependency
Select CONFIG_KALLSYMS_ALL when CONFIG_KPROBES_SANITY_TEST=y. Kprobe selftest always fail without CONFIG_KALLSYMS_ALL=y, because kallsyms doesn't list up the target functions which are probed in this test.
---
lib/Kconfig.debug | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
lib/Kconfig.debug +1 -0
@@ -727,6 +727,7 @@ config KPROBES_SANITY_TEST bool "Kprobes sanity tests" depends on DEBUG_KERNEL depends on KPROBES + select KALLSYMS_ALL default n help This option provides for testing basic kprobes functionality on
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Andrew Morton
maintainerQuoted 17 lines · On Mon, 22 Jun 2009 17:03:02 -0400 Masami Hiramatsu <[email protected]> wrote:
Select
CONFIG_KALLSYMS_ALLwhenCONFIG_KPROBES_SANITY_TEST=y. Kprobe selftest always fail withoutCONFIG_KALLSYMS_ALL=y, because kallsyms doesn't list up the target functions which are probed in this test.Signed-off-by Masami Hiramatsu <[email protected]>Cc Ananth N Mavinakayanahalli <[email protected]>---
lib/Kconfig.debug | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)lib/Kconfig.debug +0
-0
lib/Kconfig.debug config KPROBES_SANITY_TEST · line 733
Quoted 7 lines
lib/Kconfig.debug +1
-0@@ -727,6 +727,7 @@ config KPROBES_SANITY_TEST bool "Kprobes sanity tests" depends on DEBUG_KERNEL depends on KPROBES + select KALLSYMS_ALL default n help This option provides for testing basic kprobes functionality on
KALLSYMS_ALL depends on KALLSYMS, so what happens here if KALLSYMS=n?
Ah, KPROBES depends on KALLSYMS, so that problem won't be occurring.
Still, the end result is significently more complex and fragile than a `depends on' would have been. But I suppose we've done worse. Oh well.
Quoted 3 lines · Andrew Morton
Still, the end result is significently more complex and fragile than a `depends on' would have been. But I suppose we've done worse. Oh well.
Couldn't we just limit the selftest to a set of symbols that doesn't require the "all" part?
Linus
Quoted 7 lines · Linus Torvalds
Quoted 2 lines · Andrew Morton
Still, the end result is significently more complex and fragile than a `depends on' would have been. But I suppose we've done worse. Oh well.
Couldn't we just limit the selftest to a set of symbols that doesn't require the "all" part?
OK. I'll try it.
Thank you,
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Oops, I couldn't reproduce this bug on the latest -tip tree. I'll need to dig it deeper. Andew, and Ingo, could you please drop it?
Quoted 12 lines · Masami Hiramatsu
Quoted 5 lines · Linus Torvalds
Quoted 2 lines · Andrew Morton
Still, the end result is significently more complex and fragile than a `depends on' would have been. But I suppose we've done worse. Oh well.
Couldn't we just limit the selftest to a set of symbols that doesn't require the "all" part?
OK. I'll try it.
Thank you,
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Quoted 1 line · Masami Hiramatsu
Oops, I couldn't reproduce this bug on the latest -tip tree.
maybe because i applied your fix already? ;-)
Ingo
Quoted 5 lines · Ingo Molnar
Quoted 1 line · Masami Hiramatsu
Oops, I couldn't reproduce this bug on the latest -tip tree.
maybe because i applied your fix already? ;-)
If so, I'll be happy. But I reverted that change and checked :-( Maybe, that came from a combination of configs (but I've lost it...)
Thanks,
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Quoted 8 lines · Masami Hiramatsu
Quoted 4 lines · Ingo Molnar
Quoted 1 line · Masami Hiramatsu
Oops, I couldn't reproduce this bug on the latest -tip tree.
maybe because i applied your fix already? ;-)
If so, I'll be happy. But I reverted that change and checked :-( Maybe, that came from a combination of configs (but I've lost it...)
Ok, I found.
Sorry, the problem has been fixed with below commit...
Thanks,
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Quoted 7 lines · Masami Hiramatsu
Quoted 6 lines · Masami Hiramatsu
Quoted 4 lines · Ingo Molnar
Quoted 1 line · Masami Hiramatsu
Oops, I couldn't reproduce this bug on the latest -tip tree.
maybe because i applied your fix already? ;-)
Quoted 7 lines
Quoted 2 lines
If so, I'll be happy. But I reverted that change and checked :-( Maybe, that came from a combination of configs (but I've lost it...)
Ok, I found.
Sorry, the problem has been fixed with below commit...
thx - i thus dropped this:
130c5b2 kprobes: Fix kprobe selftest configuration dependency
Kept the other two patches - one for tracing/urgent (for .31), the other for tracing/core (.32). Agreed?
Ingo
Quoted 13 lines · Ingo Molnar
Quoted 11 lines · Masami Hiramatsu
Quoted 7 lines · Masami Hiramatsu
Quoted 4 lines · Ingo Molnar
Quoted 1 line · Masami Hiramatsu
Oops, I couldn't reproduce this bug on the latest -tip tree.
maybe because i applied your fix already? ;-)
If so, I'll be happy. But I reverted that change and checked :-( Maybe, that came from a combination of configs (but I've lost it...)
Ok, I found.
Sorry, the problem has been fixed with below commit...
Quoted 8 lines
Quoted 1 line
thx - i thus dropped this:
130c5b2 kprobes: Fix kprobe selftest configuration dependency
Kept the other two patches - one for tracing/urgent (for .31), the other for tracing/core (.32). Agreed?
Yes, I agreed. :-)
Thanks!
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]