qcow1: Fix qcow_aio_writev
PATCH 1/1 qcow1: Fix qcow_aio_writev
Pass is_write = 1 to qcow_aio_setup when writing.
--- block/qcow.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
block/qcow.c +1 -1
@@ -723,7 +723,7 @@ static BlockDriverAIOCB *qcow_aio_writev(BlockDriverState *bs, s->cluster_cache_offset =-1 ;/* disable compressed cache */ - acb =qcow_aio_setup (bs, sector_num, qiov, nb_sectors, cb, opaque,0 ); + acb =qcow_aio_setup (bs, sector_num, qiov, nb_sectors, cb, opaque,1 );if (!acb)return NULL ;
Signature · 1 line
1.6.0.6
Quoted 1 line · Kevin Wolf
Pass
is_write= 1 toqcow_aio_setupwhen writing.
Looks correct, sorry for introducing this.
Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Kevin Wolf
Pass
is_write= 1 toqcow_aio_setupwhen writing.Looks correct, sorry for introducing this.
Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?
I'd expect we'll not see such things in the same place again, but symbolic constants are always better. Are you going to prepare a patch?
Kevin
Quoted 11 lines · Kevin Wolf
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Kevin Wolf
Pass
is_write= 1 toqcow_aio_setupwhen writing.Looks correct, sorry for introducing this.
Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?
I'd expect we'll not see such things in the same place again, but symbolic constants are always better. Are you going to prepare a patch?
I'll put it on my todo list, after some higher priority items :)