Skip to contentSkip to conversation

qcow1: Fix qcow_aio_writev

PATCH In review Kevin Wolf 2 participants 4 messages Jun 30, 2009 Block layer

lore
Share & tools
lore

Kevin Wolf

author
#0 lore raw

PATCH 1/1 qcow1: Fix qcow_aio_writev

Pass is_write = 1 to qcow_aio_setup when writing.

---
 block/qcow.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
block/qcow.c +1 -1
index 55a68a6..7fc85ae 100644
@@ -723,7 +723,7 @@ static BlockDriverAIOCB *qcow_aio_writev(BlockDriverState *bs,
 
     s->cluster_cache_offset = -1; /* disable compressed cache */
 
-    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
+    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
     if (!acb)
         return NULL;
 
Signature · 1 line
1.6.0.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Kevin Wolf

Pass is_write = 1 to qcow_aio_setup when writing.

Looks correct, sorry for introducing this.

Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?

author
#2 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Kevin Wolf

Pass is_write = 1 to qcow_aio_setup when writing.

Looks correct, sorry for introducing this.

Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?

I'd expect we'll not see such things in the same place again, but symbolic constants are always better. Are you going to prepare a patch?

Kevin

#3 lore raw
Quoted 11 lines · Kevin Wolf
Quoted 7 lines · Christoph Hellwig
Quoted 1 line · Kevin Wolf

Pass is_write = 1 to qcow_aio_setup when writing.

Looks correct, sorry for introducing this.

Maybe we should add symbolic names for READ/WRITE in another patch to make this more easily spottable?

I'd expect we'll not see such things in the same place again, but symbolic constants are always better. Are you going to prepare a patch?

I'll put it on my todo list, after some higher priority items :)