Skip to contentSkip to conversation

FRV: Fix a warning due to an unnecessary #include of an MTD header

PATCH In review David Howells 2 participants 2 messages Jun 30, 2009 – Jul 1, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FRV: Fix a warning due to an unnecessary #include of an MTD header

Fix a warning due to an unnecessary #inclusion of linux/mtd/partitions:

CC arch/frv/mb93090-mb00/flash.o
In file included from arch/frv/mb93090-mb00/flash.c:15:
include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list

---

 arch/frv/mb93090-mb00/flash.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
arch/frv/mb93090-mb00/flash.c +0 -1
index c0e3707..6aad117 100644
@@ -11,7 +11,6 @@
 
 #include <linux/init.h>
 #include <linux/platform_device.h>
-#include <linux/mtd/partitions.h>
 #include <linux/mtd/physmap.h>
 
 #define MB93090_BOOTROM_ADDR	0xFF000000	/* Boot ROM */
#1 lore raw
Quoted 9 lines · On Tue, 30 Jun 2009 22:24:25 +0100 David Howells <[email protected]> wrote:

Fix a warning due to an unnecessary #inclusion of linux/mtd/partitions:

CC arch/frv/mb93090-mb00/flash.o
In file included from arch/frv/mb93090-mb00/flash.c:15:
include/linux/mtd/partitions.h:50: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:50: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/mtd/partitions.h:51: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:61: warning: 'struct mtd_info' declared inside parameter list include/linux/mtd/partitions.h:67: warning: 'struct mtd_info' declared inside parameter list

hm. Maybe fix include/linux/mtd/partitions.h?

Quoted 1 line
 arch/frv/mb93090-mb00/flash.c |    1 -

That file isn't in mainline or linux-next afacit.