Skip to contentSkip to conversation

patch kvm-add-vt-x-machine-check-support.patch added to 2.6.30-stable tree

DISCUSSION Stefan Lippers-Hollmann 6 participants 16 messages Jun 30, 2009 – Jul 2, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi

Quoted 8 lines · On Wednesday 01 July 2009, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: KVM: Add VT-x machine check support

to the 2.6.30-stable tree. Its filename is

kvm-add-vt-x-machine-check-support.patch

Quoted 8 lines

A git repo of this tree can be found at
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

From a0861c02a981c943573478ea13b29b1fb958ee5b Mon Sep 17 00:00:00 2001
From: Andi Kleen <[email protected]>
Date: Mon, 8 Jun 2009 17:37:09 +0800
Subject: KVM: Add VT-x machine check support

This patch fails to compile if applied to 2.6.30 + current stable queue.

arch/x86/kvm/vmx.c: In function 'vmx_vcpu_run':
arch/x86/kvm/vmx.c:3573: error: 'exit_intr_info' undeclared (first use in this function) arch/x86/kvm/vmx.c:3573: error: (Each undeclared identifier is reported only once arch/x86/kvm/vmx.c:3573: error: for each function it appears in.)
make[4]: *** [arch/x86/kvm/vmx.o] Error 1
make[3]: *** [arch/x86/kvm] Error 2
make[3]: *** Waiting for unfinished jobs....

It seems to depend on the code refactoring introduced by

Quoted 1 line

From 7b4a25cb296e2a73d2e87a4af65361d45d450a27 Mon Sep 17 00:00:00 2001

From: Gleb Natapov <[email protected]>
Date: Mon, 30 Mar 2009 16:03:08 +0300
Subject: KVM: VMX: Fix handling of a fault during NMI unblocked due to IRET

Bit 12 is undefined in any of the following cases:
If the VM exit sets the valid bit in the IDT-vectoring information field. If the VM exit is due to a double fault.

and followed up by the code movement in

Quoted 1 line

From 20f65983e30f222e5383f77206e3f571d1d64610 Mon Sep 17 00:00:00 2001

From: Gleb Natapov <[email protected]>
Date: Mon, 11 May 2009 13:35:55 +0300
Subject: KVM: Move "exit due to NMI" handling into vmx_complete_interrupts()

To save us one reading of VM_EXIT_INTR_INFO.

Regards
Stefan Lippers-Hollmann

Quoted 26 lines

From: Andi Kleen <[email protected]>

commit a0861c02a981c943573478ea13b29b1fb958ee5b upstream.

VT-x needs an explicit MC vector intercept to handle machine checks in the hyper visor.

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Thanks to Jiang Yunhong for help and testing.

---
 arch/x86/include/asm/vmx.h          |    1 
 arch/x86/kernel/cpu/mcheck/mce_64.c |    1 
 arch/x86/kvm/vmx.c                  |   50 ++++++++++++++++++++++++++++++++++--
 3 files changed, 50 insertions(+), 2 deletions(-)
Quoted 141 lines
arch/x86/include/asm/vmx.h +1 -0
@@ -247,6 +247,7 @@ enum vmcs_field {
 #define EXIT_REASON_MSR_READ            31
 #define EXIT_REASON_MSR_WRITE           32
 #define EXIT_REASON_MWAIT_INSTRUCTION   36
+#define EXIT_REASON_MCE_DURING_VMENTRY	 41
 #define EXIT_REASON_TPR_BELOW_THRESHOLD 43
 #define EXIT_REASON_APIC_ACCESS         44
 #define EXIT_REASON_EPT_VIOLATION       48
arch/x86/kernel/cpu/mcheck/mce_64.c +1 -0
@@ -420,6 +420,7 @@ void do_machine_check(struct pt_regs * r
  out2:
 	atomic_dec(&mce_entry);
 }
+EXPORT_SYMBOL_GPL(do_machine_check);
 
 #ifdef CONFIG_X86_MCE_INTEL
 /***
arch/x86/kvm/vmx.c +48 -2
@@ -32,6 +32,7 @@
 #include <asm/desc.h>
 #include <asm/vmx.h>
 #include <asm/virtext.h>
+#include <asm/mce.h>
 
 #define __ex(x) __kvm_handle_fault_on_reboot(x)
 
@@ -97,6 +98,7 @@ struct vcpu_vmx {
 	int soft_vnmi_blocked;
 	ktime_t entry_time;
 	s64 vnmi_blocked_time;
+	u32 exit_reason;
 };
 
 static inline struct vcpu_vmx *to_vmx(struct kvm_vcpu *vcpu)
@@ -213,6 +215,13 @@ static inline int is_external_interrupt(
 		== (INTR_TYPE_EXT_INTR | INTR_INFO_VALID_MASK);
 }
 
+static inline int is_machine_check(u32 intr_info)
+{
+	return (intr_info & (INTR_INFO_INTR_TYPE_MASK | INTR_INFO_VECTOR_MASK |
+			     INTR_INFO_VALID_MASK)) ==
+		(INTR_TYPE_HARD_EXCEPTION | MC_VECTOR | INTR_INFO_VALID_MASK);
+}
+
 static inline int cpu_has_vmx_msr_bitmap(void)
 {
 	return (vmcs_config.cpu_based_exec_ctrl & CPU_BASED_USE_MSR_BITMAPS);
@@ -478,7 +487,7 @@ static void update_exception_bitmap(stru
 {
 	u32 eb;
 
-	eb = (1u << PF_VECTOR) | (1u << UD_VECTOR);
+	eb = (1u << PF_VECTOR) | (1u << UD_VECTOR) | (1u << MC_VECTOR);
 	if (!vcpu->fpu_active)
 		eb |= 1u << NM_VECTOR;
 	if (vcpu->guest_debug & KVM_GUESTDBG_ENABLE) {
@@ -2585,6 +2594,31 @@ static int handle_rmode_exception(struct
 	return 0;
 }
 
+/*
+ * Trigger machine check on the host. We assume all the MSRs are already set up
+ * by the CPU and that we still run on the same CPU as the MCE occurred on.
+ * We pass a fake environment to the machine check handler because we want
+ * the guest to be always treated like user space, no matter what context
+ * it used internally.
+ */
+static void kvm_machine_check(void)
+{
+#if defined(CONFIG_X86_MCE) && defined(CONFIG_X86_64)
+	struct pt_regs regs = {
+		.cs = 3, /* Fake ring 3 no matter what the guest ran on */
+		.flags = X86_EFLAGS_IF,
+	};
+
+	do_machine_check(&regs, 0);
+#endif
+}
+
+static int handle_machine_check(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
+{
+	/* already handled by vcpu_run */
+	return 1;
+}
+
 static int handle_exception(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
 {
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
@@ -2596,6 +2630,9 @@ static int handle_exception(struct kvm_v
 	vect_info = vmx->idt_vectoring_info;
 	intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
 
+	if (is_machine_check(intr_info))
+		return handle_machine_check(vcpu, kvm_run);
+
 	if ((vect_info & VECTORING_INFO_VALID_MASK) &&
 						!is_page_fault(intr_info))
 		printk(KERN_ERR "%s: unexpected, vectoring info 0x%x "
@@ -3150,6 +3187,7 @@ static int (*kvm_vmx_exit_handlers[])(st
 	[EXIT_REASON_WBINVD]                  = handle_wbinvd,
 	[EXIT_REASON_TASK_SWITCH]             = handle_task_switch,
 	[EXIT_REASON_EPT_VIOLATION]	      = handle_ept_violation,
+	[EXIT_REASON_MCE_DURING_VMENTRY]      = handle_machine_check,
 };
 
 static const int kvm_vmx_max_exit_handlers =
@@ -3161,8 +3199,8 @@ static const int kvm_vmx_max_exit_handle
  */
 static int kvm_handle_exit(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
 {
-	u32 exit_reason = vmcs_read32(VM_EXIT_REASON);
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
+	u32 exit_reason = vmx->exit_reason;
 	u32 vectoring_info = vmx->idt_vectoring_info;
 
 	KVMTRACE_3D(VMEXIT, vcpu, exit_reason, (u32)kvm_rip_read(vcpu),
@@ -3512,6 +3550,14 @@ static void vmx_vcpu_run(struct kvm_vcpu
 
 	intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
 
+	vmx->exit_reason = vmcs_read32(VM_EXIT_REASON);
+
+	/* Handle machine checks before interrupts are enabled */
+	if ((vmx->exit_reason == EXIT_REASON_MCE_DURING_VMENTRY)
+	    || (vmx->exit_reason == EXIT_REASON_EXCEPTION_NMI
+		&& is_machine_check(exit_intr_info)))
+		kvm_machine_check();
+
 	/* We need to handle NMIs before interrupts are enabled */
 	if ((intr_info & INTR_INFO_INTR_TYPE_MASK) == INTR_TYPE_NMI_INTR &&
 	    (intr_info & INTR_INFO_VALID_MASK)) {

Patches currently in stable-queue which might be from [email protected] are

queue-2.6.30/kvm-add-vt-x-machine-check-support.patch

#2 lore raw
Quoted 51 lines · Stefan Lippers-Hollmann

Hi

Quoted 8 lines · On Wednesday 01 July 2009, [email protected] wrote:

This is a note to let you know that we have just queued up the patch titled

Subject: KVM: Add VT-x machine check support

to the 2.6.30-stable tree. Its filename is

kvm-add-vt-x-machine-check-support.patch

Quoted 8 lines

A git repo of this tree can be found at
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

From a0861c02a981c943573478ea13b29b1fb958ee5b Mon Sep 17 00:00:00 2001
From: Andi Kleen <[email protected]>
Date: Mon, 8 Jun 2009 17:37:09 +0800
Subject: KVM: Add VT-x machine check support

This patch fails to compile if applied to 2.6.30 + current stable queue.

arch/x86/kvm/vmx.c: In function 'vmx_vcpu_run':
arch/x86/kvm/vmx.c:3573: error: 'exit_intr_info' undeclared (first use in this function) arch/x86/kvm/vmx.c:3573: error: (Each undeclared identifier is reported only once arch/x86/kvm/vmx.c:3573: error: for each function it appears in.)
make[4]: *** [arch/x86/kvm/vmx.o] Error 1
make[3]: *** [arch/x86/kvm] Error 2
make[3]: *** Waiting for unfinished jobs....

It seems to depend on the code refactoring introduced by

From 7b4a25cb296e2a73d2e87a4af65361d45d450a27 Mon Sep 17 00:00:00 2001
From: Gleb Natapov <[email protected]>
Date: Mon, 30 Mar 2009 16:03:08 +0300
Subject: KVM: VMX: Fix handling of a fault during NMI unblocked due to IRET

Bit 12 is undefined in any of the following cases:
If the VM exit sets the valid bit in the IDT-vectoring information field. If the VM exit is due to a double fault.

and followed up by the code movement in

From 20f65983e30f222e5383f77206e3f571d1d64610 Mon Sep 17 00:00:00 2001
From: Gleb Natapov <[email protected]>
Date: Mon, 11 May 2009 13:35:55 +0300
Subject: KVM: Move "exit due to NMI" handling into vmx_complete_interrupts()

Quoted 4 lines

To save us one reading of VM_EXIT_INTR_INFO.

Thanks, I was building without kvm enabled in my configs and missed this one.

I've added these two other patches and everything looks better.

greg k-h

#3 lore raw
Quoted 5 lines

Thanks, I was building without kvm enabled in my configs and missed this one.

I've added these two other patches and everything looks better.

If you prefer I also have an original patch which didn't depend on any other KVM patches. But the other ones look harmless enough and it's probably better to stay nearer mainline.

-Andi

#4 lore raw
Quoted 9 lines · Andi Kleen
Quoted 5 lines

Thanks, I was building without kvm enabled in my configs and missed this one.

I've added these two other patches and everything looks better.

If you prefer I also have an original patch which didn't depend on any other KVM patches. But the other ones look harmless enough and it's probably better to stay nearer mainline.

I'd prefer your standalone patch Andi. Patches often look harmless but aren't, and I'd hate to introduce regressions into 2.6.30.*.

Signature · 1 line
error compiling committee.c: too many arguments to function
#5 lore raw
Quoted 7 lines · Avi Kivity
Quoted 6 lines · Andi Kleen
Quoted 5 lines

Thanks, I was building without kvm enabled in my configs and missed this one.

I've added these two other patches and everything looks better.

Quoted 7 lines
Quoted 4 lines

If you prefer I also have an original patch which didn't depend on any other KVM patches. But the other ones look harmless enough and it's probably
better to stay nearer mainline.

I'd prefer your standalone patch Andi. Patches often look harmless but aren't, and I'd hate to introduce regressions into 2.6.30.*.

Here's the 2.6.30 standalone patch, slightly updated.

-Andi

---

KVM: Add VT-x machine check support v3

VT-x needs an explicit MC vector intercept to handle machine checks in the hypervisor.

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Thanks to Huang Ying and Jiang Yunhong for help and testing.

v2: Handle machine checks still in interrupt off context to avoid problems on preemptible kernels.
v3: Handle old style 32bit and make fully standalone

---
 arch/x86/include/asm/kvm_host.h     |    2 +
 arch/x86/include/asm/mce.h          |    2 +
 arch/x86/include/asm/vmx.h          |    1 
 arch/x86/kernel/cpu/mcheck/mce_32.c |    1 
 arch/x86/kernel/cpu/mcheck/mce_64.c |    1 
 arch/x86/kvm/vmx.c                  |   47 +++++++++++++++++++++++++++++++++---
 6 files changed, 51 insertions(+), 3 deletions(-)
arch/x86/include/asm/vmx.h +1 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/vmx.h
===================================================================
@@ -247,6 +247,7 @@ enum vmcs_field {
 #define EXIT_REASON_MSR_READ            31
 #define EXIT_REASON_MSR_WRITE           32
 #define EXIT_REASON_MWAIT_INSTRUCTION   36
+#define EXIT_REASON_MCE_DURING_VMENTRY	 41
 #define EXIT_REASON_TPR_BELOW_THRESHOLD 43
 #define EXIT_REASON_APIC_ACCESS         44
 #define EXIT_REASON_EPT_VIOLATION       48
arch/x86/kvm/vmx.c +44 -3

95 lines not on this page · raw message

arch/x86/include/asm/kvm_host.h +2 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/kvm_host.h
===================================================================
@@ -371,6 +371,8 @@ struct kvm_vcpu_arch {
 	unsigned long dr6;
 	unsigned long dr7;
 	unsigned long eff_db[KVM_NR_DB_REGS];
+
+	u32 exit_reason;
 };
 
 struct kvm_mem_alias {
arch/x86/include/asm/mce.h +2 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/mce.h
===================================================================
@@ -153,5 +153,7 @@ extern void mcheck_init(struct cpuinfo_x
 
 extern void (*mce_threshold_vector)(void);
 
+extern void (*machine_check_vector)(struct pt_regs *, long error_code);
+
 #endif /* __KERNEL__ */
 #endif /* _ASM_X86_MCE_H */
arch/x86/kernel/cpu/mcheck/mce_32.c +1 -0
Index: linux-2.6.30-ak/arch/x86/kernel/cpu/mcheck/mce_32.c
===================================================================
@@ -29,6 +29,7 @@ static void unexpected_machine_check(str
 
 /* Call the installed machine check handler for this CPU setup. */
 void (*machine_check_vector)(struct pt_regs *, long error_code) = unexpected_machine_check;
+EXPORT_SYMBOL_GPL(machine_check_vector);
 
 /* This has to be run for each processor */
 void mcheck_init(struct cpuinfo_x86 *c)
arch/x86/kernel/cpu/mcheck/mce_64.c +1 -0
Index: linux-2.6.30-ak/arch/x86/kernel/cpu/mcheck/mce_64.c
===================================================================
@@ -420,6 +420,7 @@ void do_machine_check(struct pt_regs * r
  out2:
 	atomic_dec(&mce_entry);
 }
+EXPORT_SYMBOL_GPL(do_machine_check);
 
 #ifdef CONFIG_X86_MCE_INTEL
 /***
Signature · 1 line
[email protected] -- Speaking for myself only.
#6 lore raw
Quoted 26 lines · Andi Kleen

KVM: Add VT-x machine check support v3

VT-x needs an explicit MC vector intercept to handle machine checks in the hypervisor.

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Thanks to Huang Ying and Jiang Yunhong for help and testing.

v2: Handle machine checks still in interrupt off context to avoid problems on preemptible kernels.
v3: Handle old style 32bit and make fully standalone

===================================================================

arch/x86/include/asm/kvm_host.h struct kvm_vcpu_arch { · line 378

Quoted 8 lines
arch/x86/include/asm/kvm_host.h +2 -0
@@ -371,6 +371,8 @@ struct kvm_vcpu_arch {
  	unsigned long dr6;
  	unsigned long dr7;
  	unsigned long eff_db[KVM_NR_DB_REGS];
+
+	u32 exit_reason;
  };
 
 

Should be in struct vmx_vcpu; otherwise ack.

Signature · 1 line
error compiling committee.c: too many arguments to function
#7 lore raw
Quoted 1 line · Avi Kivity

Should be in struct vmx_vcpu; otherwise ack.

Done

---

KVM: Add VT-x machine check support v4

VT-x needs an explicit MC vector intercept to handle machine checks in the hypervisor.

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Thanks to Huang Ying and Jiang Yunhong for help and testing.

v2: Handle machine checks still in interrupt off context to avoid problems on preemptible kernels.
v3: Handle old style 32bit and make fully standalone

---
 arch/x86/include/asm/kvm_host.h     |    2 +
 arch/x86/include/asm/mce.h          |    2 +
 arch/x86/include/asm/vmx.h          |    1 
 arch/x86/kernel/cpu/mcheck/mce_32.c |    1 
 arch/x86/kernel/cpu/mcheck/mce_64.c |    1 
 arch/x86/kvm/vmx.c                  |   49 +++++++++++++++++++++++++++++++++---
 6 files changed, 53 insertions(+), 3 deletions(-)
arch/x86/include/asm/vmx.h +1 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/vmx.h
===================================================================
@@ -247,6 +247,7 @@ enum vmcs_field {
 #define EXIT_REASON_MSR_READ            31
 #define EXIT_REASON_MSR_WRITE           32
 #define EXIT_REASON_MWAIT_INSTRUCTION   36
+#define EXIT_REASON_MCE_DURING_VMENTRY	 41
 #define EXIT_REASON_TPR_BELOW_THRESHOLD 43
 #define EXIT_REASON_APIC_ACCESS         44
 #define EXIT_REASON_EPT_VIOLATION       48
arch/x86/kvm/vmx.c +46 -3

104 lines not on this page · raw message

arch/x86/include/asm/kvm_host.h +2 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/kvm_host.h
===================================================================
@@ -371,6 +371,8 @@ struct kvm_vcpu_arch {
 	unsigned long dr6;
 	unsigned long dr7;
 	unsigned long eff_db[KVM_NR_DB_REGS];
+
+	u32 exit_reason;
 };
 
 struct kvm_mem_alias {
arch/x86/include/asm/mce.h +2 -0
Index: linux-2.6.30-ak/arch/x86/include/asm/mce.h
===================================================================
@@ -153,5 +153,7 @@ extern void mcheck_init(struct cpuinfo_x
 
 extern void (*mce_threshold_vector)(void);
 
+extern void (*machine_check_vector)(struct pt_regs *, long error_code);
+
 #endif /* __KERNEL__ */
 #endif /* _ASM_X86_MCE_H */
arch/x86/kernel/cpu/mcheck/mce_32.c +1 -0
Index: linux-2.6.30-ak/arch/x86/kernel/cpu/mcheck/mce_32.c
===================================================================
@@ -29,6 +29,7 @@ static void unexpected_machine_check(str
 
 /* Call the installed machine check handler for this CPU setup. */
 void (*machine_check_vector)(struct pt_regs *, long error_code) = unexpected_machine_check;
+EXPORT_SYMBOL_GPL(machine_check_vector);
 
 /* This has to be run for each processor */
 void mcheck_init(struct cpuinfo_x86 *c)
arch/x86/kernel/cpu/mcheck/mce_64.c +1 -0
Index: linux-2.6.30-ak/arch/x86/kernel/cpu/mcheck/mce_64.c
===================================================================
@@ -420,6 +420,7 @@ void do_machine_check(struct pt_regs * r
  out2:
 	atomic_dec(&mce_entry);
 }
+EXPORT_SYMBOL_GPL(do_machine_check);
 
 #ifdef CONFIG_X86_MCE_INTEL
 /***
Signature · 1 line
[email protected] -- Speaking for myself only.
#8 lore raw
Quoted 14 lines · Andi Kleen
Quoted 2 lines · Avi Kivity

Should be in struct vmx_vcpu; otherwise ack.

Done

---

KVM: Add VT-x machine check support v4

VT-x needs an explicit MC vector intercept to handle machine checks in the hypervisor.

Quoted 10 lines

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Thanks to Huang Ying and Jiang Yunhong for help and testing.

Ack, thanks. Stable boys, please use this instead of the patch from mainline and the two patches it dragged in.

Signature · 1 line
error compiling committee.c: too many arguments to function
#9 lore raw
Quoted 22 lines · Avi Kivity
Quoted 21 lines · Andi Kleen
Quoted 2 lines · Avi Kivity

Should be in struct vmx_vcpu; otherwise ack.

Done

---

KVM: Add VT-x machine check support v4

VT-x needs an explicit MC vector intercept to handle machine checks in the hypervisor.

It also has a special option to catch machine checks that happen during VT entry.

Do these interceptions and forward them to the Linux machine check handler. Make it always look like user space is interrupted because the machine check handler treats kernel/user space differently.

Quoted 6 lines
Quoted 3 lines

Thanks to Huang Ying and Jiang Yunhong for help and testing.

Ack, thanks. Stable boys, please use this instead of the patch from mainline and the two patches it dragged in.

So, I should use this instead of:
kvm-vmx-fix-handling-of-a-fault-during-nmi-unblocked-due-to-iret.patch kvm-move-exit-due-to-nmi-handling-into-vmx_complete_interrupts.patch kvm-add-vt-x-machine-check-support.patch

thanks,

greg k-h

#10 lore raw
Quoted 9 lines · Greg KH
Quoted 3 lines

Ack, thanks. Stable boys, please use this instead of the patch from mainline and the two patches it dragged in.

So, I should use this instead of:
kvm-vmx-fix-handling-of-a-fault-during-nmi-unblocked-due-to-iret.patch kvm-move-exit-due-to-nmi-handling-into-vmx_complete_interrupts.patch kvm-add-vt-x-machine-check-support.patch

Exactly. I'll run my regression tests on stable-queue and let you know if I encounter any trouble.

Signature · 1 line
error compiling committee.c: too many arguments to function
#11 lore raw
Quoted 5 lines · Avi Kivity
Quoted 4 lines · Greg KH
Quoted 3 lines

Ack, thanks. Stable boys, please use this instead of the patch from mainline and the two patches it dragged in.

Quoted 8 lines
Quoted 5 lines

So, I should use this instead of:
kvm-vmx-fix-handling-of-a-fault-during-nmi-unblocked-due-to-iret.patch kvm-move-exit-due-to-nmi-handling-into-vmx_complete_interrupts.patch kvm-add-vt-x-machine-check-support.patch

Exactly. I'll run my regression tests on stable-queue and let you know if I encounter any trouble.

Thanks, I've now done this, and will push out a 2.6.30.1-rc2 in a bit so you can test with that as well.

greg k-h

#12 lore raw
Quoted 3 lines · Greg KH

Thanks, I've now done this, and will push out a 2.6.30.1-rc2 in a bit so you can test with that as well.

Where will it appear? stable-queue wasn't what I thought it was.

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
#13 lore raw
Quoted 6 lines · Avi Kivity
Quoted 3 lines · Greg KH

Thanks, I've now done this, and will push out a 2.6.30.1-rc2 in a bit so you can test with that as well.

Where will it appear? stable-queue wasn't what I thought it was.

It is now at:

	kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.30.1-rc2.gz

thanks,

greg k-h

#14 lore raw
Quoted 7 lines · Greg KH
Quoted 2 lines

Where will it appear? stable-queue wasn't what I thought it was.

It is now at:

	kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.30.1-rc2.gz

What, no git?...

Signature · 2 lines
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
#15 lore raw
Quoted 10 lines · Avi Kivity
Quoted 7 lines · Greg KH
Quoted 2 lines

Where will it appear? stable-queue wasn't what I thought it was.

It is now at:

	kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.30.1-rc2.gz

What, no git?...

Sure, it's a git tree full of quilt patches:
http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=summary
apply the queue-2.6.30 patches to a clean 2.6.30 tree and you will generate the tree.

Hope this helps,

greg k-h