Skip to contentSkip to conversation

spi: omap2_mcspi supports wake events

PATCH In review David Brownell 2 participants 3 messages Jul 2, 2009 – Jul 18, 2009 2 messages not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 spi: omap2_mcspi supports wake events

Author: Jouni Hogander <[email protected]>

Currently mcspi wake-ups are not enabled. This might cause case where OMAP is not waking up on mcspi events.

---
 drivers/spi/omap2_mcspi.c |   11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/spi/omap2_mcspi.c +9 -2
@@ -59,6 +59,8 @@
 
 /* per-register bitmasks: */
 
+#define OMAP2_MCSPI_SYSCONFIG_SMARTIDLE	(2 << 3)
+#define OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP	(1 << 2)
 #define OMAP2_MCSPI_SYSCONFIG_AUTOIDLE	(1 << 0)
 #define OMAP2_MCSPI_SYSCONFIG_SOFTRESET	(1 << 1)
 
@@ -90,6 +92,7 @@
 
 #define OMAP2_MCSPI_CHCTRL_EN		(1 << 0)
 
+#define OMAP2_MCSPI_WAKEUPENABLE_WKEN	(1 << 0)
 
 /* We have 2 DMA channels per CS, one for RX and one for TX */
 struct omap2_mcspi_dma {
@@ -873,8 +876,12 @@ static int __init omap2_mcspi_reset(stru
 	} while (!(tmp & OMAP2_MCSPI_SYSSTATUS_RESETDONE));
 
 	mcspi_write_reg(master, OMAP2_MCSPI_SYSCONFIG,
-			/* (3 << 8) | (2 << 3) | */
-			OMAP2_MCSPI_SYSCONFIG_AUTOIDLE);
+			OMAP2_MCSPI_SYSCONFIG_AUTOIDLE |
+			OMAP2_MCSPI_SYSCONFIG_ENAWAKEUP |
+			OMAP2_MCSPI_SYSCONFIG_SMARTIDLE);
+
+	mcspi_write_reg(master, OMAP2_MCSPI_WAKEUPENABLE,
+			OMAP2_MCSPI_WAKEUPENABLE_WKEN);
 
 	omap2_mcspi_set_master_mode(master);
 

------------------------------------------------------------------------------

A message that is not in the archive (sent off-list or not yet received): 200907021629.33372.david-b-yBeKhBN/[email protected]

#2 lore raw
Quoted 1 line · On Thu, 2 Jul 2009 16:29:33 -0700 David Brownell…

Author: Jouni Hogander <[email protected]>

Please use From: here.

Quoted 6 lines

Currently mcspi wake-ups are not enabled. This might cause case where OMAP is not waking up on mcspi events.

For disposition of these I'm thinking

spi-omap2_mcspi-supports-wake-events.patch -> 2.6.31
spi-omap2_mcspi-use-bitn.patch -> 2.6.32
spi-omap2_mcspi-rxdma-bugfix.patch -> 2.6.31

?

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge

A message that is not in the archive (sent off-list or not yet received): 20090717160835.66ed106e.akpm-de/[email protected]

#4 lore raw
Quoted 6 lines · Andrew Morton
Quoted 1 line · On Thu, 2 Jul 2009 16:29:33 -0700 David Brownell…

Author: Jouni Hogander <[email protected]>

Please use From: here.

Sorry, I thought I'd fixed those.

Quoted 7 lines
Quoted 6 lines

Currently mcspi wake-ups are not enabled. This might cause case where OMAP is not waking up on mcspi events.

Quoted 7 lines

For disposition of these I'm thinking

spi-omap2_mcspi-supports-wake-events.patch -> 2.6.31
spi-omap2_mcspi-use-bitn.patch -> 2.6.32
spi-omap2_mcspi-rxdma-bugfix.patch -> 2.6.31

?

Sounds OK.

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge