x86: Remove useless variable disable_x2apic
PATCH 1/1 x86: Remove useless variable disable_x2apic
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by Jaswinder Singh Rajput <[email protected]>
--- arch/x86/kernel/apic/apic.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/kernel/apic/apic.c +0 -2
@@ -140,7 +140,6 @@ int x2apic_mode;#ifdef CONFIG_X86_X2APIC /* x2apic enabled before OS handover */ static int x2apic_preenabled; -static int disable_x2apic;static __init int setup_nox2apic (char *str) {if (x2apic_enabled ()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)return 0 ; } - disable_x2apic =1 ;setup_clear_cpu_cap (X86_FEATURE_X2APIC );return 0 ; }
Signature · 1 line
1.6.2.5
[Jaswinder Singh Rajput - Thu, Jul 02, 2009 at 10:33:59PM +0530]
| | setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it. | | Signed-off-by: Jaswinder Singh Rajput <[email protected]> | --- | arch/x86/kernel/apic/apic.c | 2 -- | 1 files changed, 0 insertions(+), 2 deletions(-) | | diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c | index 8c7c042..0a1c283 100644 | --- a/arch/x86/kernel/apic/apic.c | +++ b/arch/x86/kernel/apic/apic.c | @@ -140,7 +140,6 @@ int x2apic_mode; | #ifdef CONFIG_X86_X2APIC | /* x2apic enabled before OS handover */ | static int x2apic_preenabled; | -static int disable_x2apic; | static __init int setup_nox2apic(char *str) | { | if (x2apic_enabled()) { | @@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str) | return 0; | } | | - disable_x2apic = 1; | setup_clear_cpu_cap(X86_FEATURE_X2APIC); | return 0; | } | -- | 1.6.2.5 |
yes, at moment we use cpu_has_x2apic mostly.
Ack. But lets CC Suresh to be sure. Maybe
there is something in plans.
-- Cyrill
[tip:x86/urgent] x86: Remove unused variable disable_x2apic
In reply to Jaswinder Singh RajputCommit-ID: 87489b7a2be2d04432c246379484d9e030f64658 Gitweb: http://git.kernel.org/tip/87489b7a2be2d04432c246379484d9e030f64658 Author: Jaswinder Singh Rajput <[email protected]> AuthorDate: Thu, 2 Jul 2009 22:33:59 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 3 Jul 2009 11:34:07 +0200
x86: Remove unused variable disable_x2apic
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by Jaswinder Singh Rajput <[email protected]>
Cc Yinghai Lu <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- arch/x86/kernel/apic/apic.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/kernel/apic/apic.c +0 -2
@@ -140,7 +140,6 @@ int x2apic_mode;#ifdef CONFIG_X86_X2APIC /* x2apic enabled before OS handover */ static int x2apic_preenabled; -static int disable_x2apic;static __init int setup_nox2apic (char *str) {if (x2apic_enabled ()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)return 0 ; } - disable_x2apic =1 ;setup_clear_cpu_cap (X86_FEATURE_X2APIC );return 0 ; }
[tip:x86/urgent] x86: Remove unused variable disable_x2apic
In reply to Jaswinder Singh RajputCommit-ID: 23d0cd8e718723f1ddda37637bc6b7c34caec64a Gitweb: http://git.kernel.org/tip/23d0cd8e718723f1ddda37637bc6b7c34caec64a Author: Jaswinder Singh Rajput <[email protected]> AuthorDate: Thu, 2 Jul 2009 22:33:59 +0530 Committer: Ingo Molnar <[email protected]> CommitDate: Fri, 3 Jul 2009 14:34:27 +0200
x86: Remove unused variable disable_x2apic
setup_nox2apic() is writing 1 to disable_x2apic but no one is reading it.
Signed-off-by Jaswinder Singh Rajput <[email protected]>
Cc Yinghai Lu <[email protected]>
Cc Cyrill Gorcunov <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by Ingo Molnar <[email protected]>
--- arch/x86/kernel/apic/apic.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/kernel/apic/apic.c +0 -2
@@ -140,7 +140,6 @@ int x2apic_mode;#ifdef CONFIG_X86_X2APIC /* x2apic enabled before OS handover */ static int x2apic_preenabled; -static int disable_x2apic;static __init int setup_nox2apic (char *str) {if (x2apic_enabled ()) {
@@ -149,7 +148,6 @@ static __init int setup_nox2apic(char *str)return 0 ; } - disable_x2apic =1 ;setup_clear_cpu_cap (X86_FEATURE_X2APIC );return 0 ; }