Skip to contentSkip to conversation

Fix build with ./configure-bootstrap

PATCH In review Stefan Seyfried 2 participants 4 messages Jul 7, 2009 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix build with ./configure-bootstrap

hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’
without a real prototype

---
 plugins/hciops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
plugins/hciops.c +1 -1
index 659f754..6baed76 100644
@@ -725,7 +725,7 @@ static int hciops_init(void)
 }
 static void hciops_exit(void)
 {
-	btd_adapter_cleanup_ops(&hci_ops);
+	btd_adapter_cleanup_ops();
 }
 
 BLUETOOTH_PLUGIN_DEFINE(hciops, VERSION,
Signature · 1 line
1.6.3.2
maintainer
#1 lore raw

Hi Stefan,

Quoted 12 lines

hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’
without a real prototype

---
 plugins/hciops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
plugins/hciops.c +0 -0
index 659f754..6baed76 100644

plugins/hciops.c static int hciops_init(void) · line 731

Quoted 8 lines
plugins/hciops.c +1 -1
@@ -725,7 +725,7 @@ static int hciops_init(void)
 }
 static void hciops_exit(void)
 {
-	btd_adapter_cleanup_ops(&hci_ops);
+	btd_adapter_cleanup_ops();
 }
 
 BLUETOOTH_PLUGIN_DEFINE(hciops, VERSION,

the subject is not matching the patch and I have no idea what is going on here. I leave this to Johan or Alok to look at.

Regards

Marcel

#2 lore raw
Quoted 21 lines · On Tue, 07 Jul 2009 10:21:52 -0700 Marcel Holtmann <[email protected]> wrote:

Hi Stefan,

Quoted 19 lines

hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’
without a real prototype

---
 plugins/hciops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
plugins/hciops.c +1 -1
index 659f754..6baed76 100644
@@ -725,7 +725,7 @@ static int hciops_init(void)
 }
 static void hciops_exit(void)
 {
-	btd_adapter_cleanup_ops(&hci_ops);
+	btd_adapter_cleanup_ops();
 }
 
Quoted 4 lines

plugins/hciops.c static int hciops_init(void) · line 731

Quoted 1 line
plugins/hciops.c +0 -0
 BLUETOOTH_PLUGIN_DEFINE(hciops, VERSION,

the subject is not matching the patch and I have no idea what is going on here. I leave this to Johan or Alok to look at.

The build fails, because of this warning:

make[3]: Entering directory `/local/seife/src/git-repos/bluez-git/plugins'
CC libbuiltin_la-service.lo
CC libbuiltin_la-hciops.lo
cc1: warnings being treated as errors
hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’ without a real prototype ../src/adapter.h:174: note: ‘btd_adapter_cleanup_ops’ was declared here

The hci_ops are not used by btd_adapter_cleanup_ops (it takes no parameter), so I guessed that the above would be a valid fix.

It is certainly a good idea to have this reviewed by someone who actually knows the code (I don't ;)

Best regards,

Stefan

Signature · 6 lines
Stefan Seyfried
R&D Preload Department             |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
maintainer
#3 lore raw

Hi Stefan,

Quoted 34 lines
Quoted 19 lines
Quoted 19 lines

hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’
without a real prototype

---
 plugins/hciops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
plugins/hciops.c +1 -1
index 659f754..6baed76 100644
@@ -725,7 +725,7 @@ static int hciops_init(void)
 }
 static void hciops_exit(void)
 {
-	btd_adapter_cleanup_ops(&hci_ops);
+	btd_adapter_cleanup_ops();
 }
 
Quoted 4 lines

plugins/hciops.c static int hciops_init(void) · line 731

Quoted 1 line
plugins/hciops.c +0 -0
 BLUETOOTH_PLUGIN_DEFINE(hciops, VERSION,

the subject is not matching the patch and I have no idea what is going on here. I leave this to Johan or Alok to look at.

The build fails, because of this warning:

make[3]: Entering directory `/local/seife/src/git-repos/bluez-git/plugins'
CC libbuiltin_la-service.lo
CC libbuiltin_la-hciops.lo
cc1: warnings being treated as errors
hciops.c: In function ‘hciops_exit’:
hciops.c:728: error: call to function ‘btd_adapter_cleanup_ops’ without a real prototype ../src/adapter.h:174: note: ‘btd_adapter_cleanup_ops’ was declared here

Quoted 5 lines

The hci_ops are not used by btd_adapter_cleanup_ops (it takes no parameter), so I guessed that the above would be a valid fix.

It is certainly a good idea to have this reviewed by someone who actually knows the code (I don't ;)

we fixed it now with bluez-4.45 release, but your patch was actually wrong. The problems with the prototype with no argument list. Bad C programming and bad that it slipped through our review.

Regards

Marcel