Skip to contentSkip to conversation

/dev/zero: Avoid repeated access_ok() checks

PATCH New Nikanth Karthikesan 1 participant 1 message Jul 7, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 /dev/zero: Avoid repeated access_ok() checks

In read_zero, we check for access_ok() once for the count bytes. It is unnecessarily checked again in clear_user. Use __clear_user, which does not check for access_ok().

---

drivers/char/mem.c +1 -1
index afa8813..3e05b48 100644
@@ -690,7 +690,7 @@ static ssize_t read_zero(struct file * file, char __user * buf,
 
 		if (chunk > PAGE_SIZE)
 			chunk = PAGE_SIZE;	/* Just for latency reasons */
-		unwritten = clear_user(buf, chunk);
+		unwritten = __clear_user(buf, chunk);
 		written += chunk - unwritten;
 		if (unwritten)
 			break;