Add support for Embest SBC2440-II Board 1/7
Patches 1 to 4 replace "[PATCH-ARM 1/2] Add support for the Embest SBC2440-II Board 1/2" submitted on 19/06/2009.
This patch re-formats the code in cpu/arm920t and cpu/arm920t/23c24x0 in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reports
Note that usb_ohci.c still has two lines that exceed 80 characters. This is because the statements on those lines lose readability when wrapped - the Linux coding style guidleines allows for this.
This complete series of patches assumes the following patches have already been applied:
- [PATCH-ARM] Bug-fix in drivers mtd nand Makefile, sent 18/06/2009
- [PATCH-ARM] CONFIG_SYS_HZ fix for ARM920T S3C24X0 Boards, sent 21/06/2009
--- cpu/arm920t/s3c24x0/speed.c | 42 +- cpu/arm920t/s3c24x0/timer.c | 80 ++-- cpu/arm920t/s3c24x0/usb.c | 30 +- cpu/arm920t/s3c24x0/usb_ohci.c | 1268 +++++++++++++++++++++------------------- cpu/arm920t/s3c24x0/usb_ohci.h | 187 +++--- cpu/arm920t/start.S | 63 +- 6 files changed, 875 insertions(+), 795 deletions(-)
cpu/arm920t/s3c24x0/speed.c +23 -19
@@ -32,6 +32,8 @@#include <common.h> #if defined(CONFIG_S3C2400 ) || defined (CONFIG_S3C2410 ) || defined (CONFIG_TRAB ) +#include <asm/io.h> +#if defined(CONFIG_S3C2400 )#include <s3c2400.h> #elif defined(CONFIG_S3C2410 )
@@ -53,49 +55,51 @@static ulong get_PLLCLK (int pllreg) { -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); -ulong r, m, p, s; +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER (); +ulong r, m, p, s; -if (pllreg ==MPLL ) - r = clk_power->MPLLCON; -else if (pllreg ==UPLL ) - r = clk_power->UPLLCON; -else -hang (); +if (pllreg ==MPLL ) + r =readl (&clk_power->MPLLCON); +else if (pllreg ==UPLL ) + r =readl (&clk_power->UPLLCON); +else +hang (); - m = ((r &0xFF000 ) >>12 ) +8 ; - p = ((r &0x003F0 ) >>4 ) +2 ; - s = r &0x3 ; + m = ((r &0xFF000 ) >>12 ) +8 ; + p = ((r &0x003F0 ) >>4 ) +2 ; + s = r &0x3 ; -return ((CONFIG_SYS_CLK_FREQ * m) / (p << s)); +return (CONFIG_SYS_CLK_FREQ * m) / (p << s); }/* return FCLK frequency */ ulong get_FCLK (void ) { -return (get_PLLCLK (MPLL )); +return get_PLLCLK (MPLL ); }/* return HCLK frequency */ ulong get_HCLK (void ) { -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER (); -return ((clk_power->CLKDIVN &0x2 ) ?get_FCLK ()/2 :get_FCLK ()); +return (readl (&clk_power->CLKDIVN) &2 ) ?get_FCLK () /2 :get_FCLK (); }/* return PCLK frequency */ ulong get_PCLK (void ) { -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER (); -return ((clk_power->CLKDIVN &0x1 ) ?get_HCLK ()/2 :get_HCLK ()); +return (readl (&clk_power->CLKDIVN) &1 ) ?get_HCLK () /2 :get_HCLK (); }/* return UCLK frequency */ ulong get_UCLK (void ) { -return (get_PLLCLK (UPLL )); +return get_PLLCLK (UPLL ); } -#endif /* defined(CONFIG_S3C2400) || defined (CONFIG_S3C2410) || defined (CONFIG_TRAB) */ +#endif /* defined(CONFIG_S3C2400) || +defined (CONFIG_S3C2410) || +defined (CONFIG_TRAB) */
cpu/arm920t/s3c24x0/timer.c +44 -36
182 lines not on this page · raw message
cpu/arm920t/s3c24x0/usb.c +16 -14
@@ -32,41 +32,43 @@# include <s3c2410.h> #endif -int usb_cpu_init (void ) -{ +#include <asm/io.h> -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); -S3C24X0_GPIO *const gpio =S3C24X0_GetBase_GPIO (); +int usb_cpu_init (void ) +{ +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER (); +struct s3c24x0_gpio *gpio =S3C24X0_GetBase_GPIO ();/* * Set the 48 MHz UPLL clocking. Values are taken from * "PLL value selection guide", 6-23, s3c2400_UM.pdf. */ - clk_power->UPLLCON = ((40 <<12 ) + (1 <<4 ) +2 ); - gpio->MISCCR |=0x8 ;/* 1 = use pads related USB for USB host */ +writel ((40 <<12 ) + (1 <<4 ) +2 , &clk_power->UPLLCON); +/* 1 = use pads related USB for USB host */ +writel (readl (&gpio->MISCCR) |0x8 , &gpio->MISCCR);/* * Enable USB host clock. */ - clk_power->CLKCON |= (1 <<4 ); +writel (readl (&clk_power->CLKCON) | (1 <<4 ), &clk_power->CLKCON);return 0 ; } -int usb_cpu_stop (void ) +int usb_cpu_stop (void ) { -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER ();/* may not want to do this */ - clk_power->CLKCON &= ~(1 <<4 ); +writel (readl (&clk_power->CLKCON) & ~(1 <<4 ), &clk_power->CLKCON);return 0 ; } -int usb_cpu_init_fail (void ) +int usb_cpu_init_fail (void ) { -S3C24X0_CLOCK_POWER *const clk_power =S3C24X0_GetBase_CLOCK_POWER (); - clk_power->CLKCON &= ~(1 <<4 ); +struct s3c24x0_clock_power *clk_power =S3C24X0_GetBase_CLOCK_POWER (); +writel (readl (&clk_power->CLKCON) & ~(1 <<4 ), &clk_power->CLKCON);return 0 ; } -# endif /* defined(CONFIG_S3C2400) || defined(CONFIG_S3C2410) */ +# endif /* defined(CONFIG_S3C2400) || defined(CONFIG_S3C2410) */ #endif /* defined(CONFIG_USB_OHCI_NEW) && defined(CONFIG_SYS_USB_OHCI_CPU_INIT) */
cpu/arm920t/s3c24x0/usb_ohci.c +667 -601
2,032 lines not on this page · raw message
cpu/arm920t/s3c24x0/usb_ohci.h +92 -95
270 lines not on this page · raw message
cpu/arm920t/start.S +33 -30
133 lines not on this page · raw message
Signature · 1 line
1.6.1.2
Quoted 6 lines · kevin.morfitt at fearnside-systems.co.uk
Patches 1 to 4 replace "[PATCH-ARM 1/2] Add support for the Embest SBC2440-II Board 1/2" submitted on 19/06/2009.
This patch re-formats the code in cpu/arm920t and cpu/arm920t/23c24x0 in preparation for changes to add support for the Embest SBC2440-II Board.
Please use subject names that describe what each patch does, rather than 1/7, 2/7, etc (which should go inside the [PATCH] so that git strips it when committing).
-Scott
Hello Kevin,
2009/6/25 kevin.morfitt at fearnside-systems.co.uk <[email protected]>:
Quoted 25 lines
Patches 1 to 4 replace "[PATCH-ARM 1/2] Add support for the Embest SBC2440-II Board 1/2" submitted on 19/06/2009.
This patch re-formats the code in cpu/arm920t and cpu/arm920t/23c24x0 in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a ?comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case ?non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor ?functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reportsNote that
usb_ohci.cstill has two lines that exceed 80 characters. This is because the statements on those lines lose readability when wrapped - the Linux coding style guidleines allows for this.This complete series of patches assumes the following patches have already been applied:
Quoted 7 lines
- [PATCH-ARM] Bug-fix in drivers mtd nand
Makefile, sent 18/06/2009
- [PATCH-ARM]CONFIG_SYS_HZfix for ARM920T S3C24X0 Boards, sent ?21/06/2009Signed-off-by Kevin Morfitt <[email protected]>---
?cpu/arm920t/s3c24x0/usb_ohci.c | 1268 +++++++++++++++++++++-------------------
Why are these files put in the cpu section, and not in the drivers/usb section where it belongs.
Could it be merged into the existing ohci code, especially if it contains improvements compared to the existing code?
I do not think it is okay to copy similar code to different places in u-boot.
Kind regards,
Remy
Hi Remy
Quoted 32 lines · Remy Bohmer
Hello Kevin,
2009/6/25 kevin.morfitt at fearnside-systems.co.uk <[email protected]>:
Quoted 28 lines
Patches 1 to 4 replace "[PATCH-ARM 1/2] Add support for the Embest SBC2440-II Board 1/2" submitted on 19/06/2009.
This patch re-formats the code in cpu/arm920t and cpu/arm920t/23c24x0 in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reportsNote that
usb_ohci.cstill has two lines that exceed 80 characters. This is because the statements on those lines lose readability when wrapped - the Linux coding style guidleines allows for this.This complete series of patches assumes the following patches have already been applied:
- [PATCH-ARM] Bug-fix in drivers mtd nand
Makefile, sent 18/06/2009
- [PATCH-ARM]CONFIG_SYS_HZfix for ARM920T S3C24X0 Boards, sent 21/06/2009
Quoted 6 lines
Quoted 3 lines
Signed-off-by Kevin Morfitt <[email protected]>--- cpu/arm920t/s3c24x0/usb_ohci.c | 1268 +++++++++++++++++++++-------------------Why are these files put in the cpu section, and not in the
drivers/usbsection where it belongs.
This code has always been in the cpu section - this used to contain all s3c24x0 drivers but all except the usb driver were moved to the drivers directories in the last release. I'm not sure why the usb driver wasn't moved at the same time though. It could be moved to the drivers directory though it would need renaming to make it clear it specific to the s3c24x0 processors.
Quoted 3 lines
Could it be merged into the existing ohci code, especially if it contains improvements compared to the existing code?
I do not think it is okay to copy similar code to different places in u-boot.
The changes in this patch are only to make the code style meet the u-boot format more closely - they don't implement any changes in functionality, and the code is also specific to the s3c24x0 processors. The code does control a standard OHCI host controller though so it might be possible to develop a more generic version that could be used to support other processors but I guess we'd need to look at how the USB host drivers of other processors work before we could decide if it's feasible. At the moment, I just want to make the minimum changes necessary to be able to add support for the Embest SBC2440-II Board.
Regards
Kevin
Quoted 5 lines
Kind regards,
Remy
Hi Kevin,
2009/7/9 kevin.morfitt at fearnside-systems.co.uk
<[email protected]>:
Quoted 27 lines
Hi Remy
Quoted 25 lines
Quoted 25 lines
This patch re-formats the code in cpu/arm920t and cpu/arm920t/23c24x0 in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a ?comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case ?non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor ?functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reportsNote that
usb_ohci.cstill has two lines that exceed 80 characters. This is because the statements on those lines lose readability when wrapped - the Linux coding style guidleines allows for this.This complete series of patches assumes the following patches have already been applied:
- [PATCH-ARM] Bug-fix in drivers mtd nand
Makefile, sent 18/06/2009
- [PATCH-ARM]CONFIG_SYS_HZfix for ARM920T S3C24X0 Boards, sent ?21/06/2009
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Signed-off-by Kevin Morfitt <[email protected]>---
?cpu/arm920t/s3c24x0/usb_ohci.c | 1268 +++++++++++++++++++++-------------------Why are these files put in the cpu section, and not in the
drivers/usbsection where it belongs.This code has always been in the cpu section - this used to contain all
That is no excuse for keeping on doing the bad thing ;-)
Quoted 5 lines
s3c24x0 drivers but all except the usb driver were moved to the drivers directories in the last release. I'm not sure why the usb driver wasn't moved at the same time though. It could be moved to the drivers directory though it would need renaming to make it clear it specific to the s3c24x0 processors.
Moving it to the drivers section is step 1.
Merging it back to the original ohci code (where it was copied from) would be step 2.
It is clearly copied code from the code in the drivers section and I believe it could be merged pretty easy.
Quoted 3 lines
The changes in this patch are only to make the code style meet the u-boot format more closely - they don't implement any changes in functionality, and the code is also specific to the s3c24x0 processors. The code does
Well, It might contain s3c24x0 specific code, but that does not make the whole file s3c24x0 specific.
Quoted 6 lines
control a standard OHCI host controller though so it might be possible to develop a more generic version that could be used to support other processors but I guess we'd need to look at how the USB host drivers of other processors work before we could decide if it's feasible. At the moment, I just want to make the minimum changes necessary to be able to add support for the Embest SBC2440-II Board.
Minimal changes are okay, but I still would really like to see this file to be moved to the drivers section as well. (it does not have to be merged though, that can be done later.)
Kind Regards,
Remy
[U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 2/7
This patch re-formats the s3c24x0 header files in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reports
--- include/s3c2400.h | 493 ++++---------------------------------------- include/s3c2410.h | 158 ++++----------- include/s3c24x0.h | 595 +++++------------------------------------------------ 3 files changed, 130 insertions(+), 1116 deletions(-)
include/s3c2400.h +37 -456
@@ -35,12 +35,12 @@#define S3C24X0_SPI_CHANNELS 1#define PALETTE (0x14A00400)/* SJS */ -typedef enum { +enum s3c24x0_uarts_nr {S3C24X0_UART0 ,S3C24X0_UART1 , -}S3C24X0_UARTS_NR ; +}; -/* S3C2400 device base addresses */ +/*S3C2400 device base addresses */ #define S3C24X0_MEMCTL_BASE 0x14000000#define S3C24X0_USB_HOST_BASE 0x14200000#define S3C24X0_INTERRUPT_BASE 0x14400000
@@ -63,492 +63,73 @@ typedef enum {#include <s3c24x0.h> -static inline S3C24X0_MEMCTL *S3C24X0_GetBase_MEMCTL (void ) +static inline struct s3c24x0_memctl *S3C24X0_GetBase_MEMCTL (void ) { -return (S3C24X0_MEMCTL *const )S3C24X0_MEMCTL_BASE ; +return (struct s3c24x0_memctl *)S3C24X0_MEMCTL_BASE ; } -static inline S3C24X0_USB_HOST *S3C24X0_GetBase_USB_HOST (void ) +static inline struct s3c24x0_usb_host *S3C24X0_GetBase_USB_HOST (void ) { -return (S3C24X0_USB_HOST *const )S3C24X0_USB_HOST_BASE ; +return (struct s3c24x0_usb_host *)S3C24X0_USB_HOST_BASE ; } -static inline S3C24X0_INTERRUPT *S3C24X0_GetBase_INTERRUPT (void ) +static inline struct s3c24x0_interrupt *S3C24X0_GetBase_INTERRUPT (void ) { -return (S3C24X0_INTERRUPT *const )S3C24X0_INTERRUPT_BASE ; +return (struct s3c24x0_interrupt *)S3C24X0_INTERRUPT_BASE ; } -static inline S3C24X0_DMAS *S3C24X0_GetBase_DMAS (void ) +static inline struct s3c24x0_dmas *S3C24X0_GetBase_DMAS (void ) { -return (S3C24X0_DMAS *const )S3C24X0_DMA_BASE ; +return (struct s3c24x0_dmas *)S3C24X0_DMA_BASE ; } -static inline S3C24X0_CLOCK_POWER *S3C24X0_GetBase_CLOCK_POWER (void ) +static inline struct s3c24x0_clock_power *S3C24X0_GetBase_CLOCK_POWER (void ) { -return (S3C24X0_CLOCK_POWER *const )S3C24X0_CLOCK_POWER_BASE ; +return (struct s3c24x0_clock_power *)S3C24X0_CLOCK_POWER_BASE ; } -static inline S3C24X0_LCD *S3C24X0_GetBase_LCD (void ) +static inline struct s3c24x0_lcd *S3C24X0_GetBase_LCD (void ) { -return (S3C24X0_LCD *const )S3C24X0_LCD_BASE ; +return (struct s3c24x0_lcd *)S3C24X0_LCD_BASE ; } -static inline S3C24X0_UART *S3C24X0_GetBase_UART (S3C24X0_UARTS_NR nr) +static inline struct s3c24x0_uart *S3C24X0_GetBase_UART (enum s3c24x0_uarts_nr n) { -return (S3C24X0_UART *const )(S3C24X0_UART_BASE + (nr *0x4000 )); +return (struct s3c24x0_uart *)(S3C24X0_UART_BASE + (n *0x4000 )); } -static inline S3C24X0_TIMERS *S3C24X0_GetBase_TIMERS (void ) +static inline struct s3c24x0_timers *S3C24X0_GetBase_TIMERS (void ) { -return (S3C24X0_TIMERS *const )S3C24X0_TIMER_BASE ; +return (struct s3c24x0_timers *)S3C24X0_TIMER_BASE ; } -static inline S3C24X0_USB_DEVICE *S3C24X0_GetBase_USB_DEVICE (void ) +static inline struct s3c24x0_usb_device *S3C24X0_GetBase_USB_DEVICE (void ) { -return (S3C24X0_USB_DEVICE *const )S3C24X0_USB_DEVICE_BASE ; +return (struct s3c24x0_usb_device *)S3C24X0_USB_DEVICE_BASE ; } -static inline S3C24X0_WATCHDOG *S3C24X0_GetBase_WATCHDOG (void ) +static inline struct s3c24x0_watchdog *S3C24X0_GetBase_WATCHDOG (void ) { -return (S3C24X0_WATCHDOG *const )S3C24X0_WATCHDOG_BASE ; +return (struct s3c24x0_watchdog *)S3C24X0_WATCHDOG_BASE ; } -static inline S3C24X0_I2C *S3C24X0_GetBase_I2C (void ) +static inline struct s3c24x0_i2c *S3C24X0_GetBase_I2C (void ) { -return (S3C24X0_I2C *const )S3C24X0_I2C_BASE ; +return (struct s3c24x0_i2c *)S3C24X0_I2C_BASE ; } -static inline S3C24X0_I2S *S3C24X0_GetBase_I2S (void ) +static inline struct s3c24x0_i2s *S3C24X0_GetBase_I2S (void ) { -return (S3C24X0_I2S *const )S3C24X0_I2S_BASE ; +return (struct s3c24x0_i2s *)S3C24X0_I2S_BASE ; } -static inline S3C24X0_GPIO *S3C24X0_GetBase_GPIO (void ) +static inline struct s3c24x0_gpio *S3C24X0_GetBase_GPIO (void ) { -return (S3C24X0_GPIO *const )S3C24X0_GPIO_BASE ; +return (struct s3c24x0_gpio *)S3C24X0_GPIO_BASE ; } -static inline S3C24X0_RTC *S3C24X0_GetBase_RTC (void ) +static inline struct s3c24x0_rtc *S3C24X0_GetBase_RTC (void ) { -return (S3C24X0_RTC *const )S3C24X0_RTC_BASE ; +return (struct s3c24x0_rtc *)S3C24X0_RTC_BASE ; } -static inline S3C2400_ADC *S3C2400_GetBase_ADC (void ) +static inline struct s3c2400_adc *S3C2400_GetBase_ADC (void ) { -return (S3C2400_ADC *const )S3C24X0_ADC_BASE ; +return (struct s3c2400_adc *)S3C24X0_ADC_BASE ; } -static inline S3C24X0_SPI *S3C24X0_GetBase_SPI (void ) +static inline struct s3c24x0_spi *S3C24X0_GetBase_SPI (void ) { -return (S3C24X0_SPI *const )S3C24X0_SPI_BASE ; +return (struct s3c24x0_spi *)S3C24X0_SPI_BASE ; } -static inline S3C2400_MMC *S3C2400_GetBase_MMC (void ) +static inline struct s3c2400_mmc *S3C2400_GetBase_MMC (void ) { -return (S3C2400_MMC *const )S3C2400_MMC_BASE ; +return (struct s3c2400_mmc *)S3C2400_MMC_BASE ; } -#if 0 -/* Memory control */ -#define rBWSCON (*(volatile unsigned *)0x14000000) -#define rBANKCON0 (*(volatile unsigned *)0x14000004) -#define rBANKCON1 (*(volatile unsigned *)0x14000008) -#define rBANKCON2 (*(volatile unsigned *)0x1400000C) -#define rBANKCON3 (*(volatile unsigned *)0x14000010) -#define rBANKCON4 (*(volatile unsigned *)0x14000014) -#define rBANKCON5 (*(volatile unsigned *)0x14000018) -#define rBANKCON6 (*(volatile unsigned *)0x1400001C) -#define rBANKCON7 (*(volatile unsigned *)0x14000020) -#define rREFRESH (*(volatile unsigned *)0x14000024) -#define rBANKSIZE (*(volatile unsigned *)0x14000028) -#define rMRSRB6 (*(volatile unsigned *)0x1400002C) -#define rMRSRB7 (*(volatile unsigned *)0x14000030) - - -/* INTERRUPT */ -#define rSRCPND (*(volatile unsigned *)0x14400000) -#define rINTMOD (*(volatile unsigned *)0x14400004) -#define rINTMSK (*(volatile unsigned *)0x14400008) -#define rPRIORITY (*(volatile unsigned *)0x1440000C) -#define rINTPND (*(volatile unsigned *)0x14400010) -#define rINTOFFSET (*(volatile unsigned *)0x14400014) - - -/* DMA */ -#define rDISRC0 (*(volatile unsigned *)0x14600000) -#define rDIDST0 (*(volatile unsigned *)0x14600004) -#define rDCON0 (*(volatile unsigned *)0x14600008) -#define rDSTAT0 (*(volatile unsigned *)0x1460000C) -#define rDCSRC0 (*(volatile unsigned *)0x14600010) -#define rDCDST0 (*(volatile unsigned *)0x14600014) -#define rDMASKTRIG0 (*(volatile unsigned *)0x14600018) -#define rDISRC1 (*(volatile unsigned *)0x14600020) -#define rDIDST1 (*(volatile unsigned *)0x14600024) -#define rDCON1 (*(volatile unsigned *)0x14600028) -#define rDSTAT1 (*(volatile unsigned *)0x1460002C) -#define rDCSRC1 (*(volatile unsigned *)0x14600030) -#define rDCDST1 (*(volatile unsigned *)0x14600034) -#define rDMASKTRIG1 (*(volatile unsigned *)0x14600038) -#define rDISRC2 (*(volatile unsigned *)0x14600040) -#define rDIDST2 (*(volatile unsigned *)0x14600044) -#define rDCON2 (*(volatile unsigned *)0x14600048) -#define rDSTAT2 (*(volatile unsigned *)0x1460004C) -#define rDCSRC2 (*(volatile unsigned *)0x14600050) -#define rDCDST2 (*(volatile unsigned *)0x14600054) -#define rDMASKTRIG2 (*(volatile unsigned *)0x14600058) -#define rDISRC3 (*(volatile unsigned *)0x14600060) -#define rDIDST3 (*(volatile unsigned *)0x14600064) -#define rDCON3 (*(volatile unsigned *)0x14600068) -#define rDSTAT3 (*(volatile unsigned *)0x1460006C) -#define rDCSRC3 (*(volatile unsigned *)0x14600070) -#define rDCDST3 (*(volatile unsigned *)0x14600074) -#define rDMASKTRIG3 (*(volatile unsigned *)0x14600078) - - -/* CLOCK & POWER MANAGEMENT */ -#define rLOCKTIME (*(volatile unsigned *)0x14800000) -#define rMPLLCON (*(volatile unsigned *)0x14800004) -#define rUPLLCON (*(volatile unsigned *)0x14800008) -#define rCLKCON (*(volatile unsigned *)0x1480000C) -#define rCLKSLOW (*(volatile unsigned *)0x14800010) -#define rCLKDIVN (*(volatile unsigned *)0x14800014) - - -/* LCD CONTROLLER */ -#define rLCDCON1 (*(volatile unsigned *)0x14A00000) -#define rLCDCON2 (*(volatile unsigned *)0x14A00004) -#define rLCDCON3 (*(volatile unsigned *)0x14A00008) -#define rLCDCON4 (*(volatile unsigned *)0x14A0000C) -#define rLCDCON5 (*(volatile unsigned *)0x14A00010) -#define rLCDSADDR1 (*(volatile unsigned *)0x14A00014) -#define rLCDSADDR2 (*(volatile unsigned *)0x14A00018) -#define rLCDSADDR3 (*(volatile unsigned *)0x14A0001C) -#define rREDLUT (*(volatile unsigned *)0x14A00020) -#define rGREENLUT (*(volatile unsigned *)0x14A00024) -#define rBLUELUT (*(volatile unsigned *)0x14A00028) -#define rDP1_2 (*(volatile unsigned *)0x14A0002C) -#define rDP4_7 (*(volatile unsigned *)0x14A00030) -#define rDP3_5 (*(volatile unsigned *)0x14A00034) -#define rDP2_3 (*(volatile unsigned *)0x14A00038) -#define rDP5_7 (*(volatile unsigned *)0x14A0003c) -#define rDP3_4 (*(volatile unsigned *)0x14A00040) -#define rDP4_5 (*(volatile unsigned *)0x14A00044) -#define rDP6_7 (*(volatile unsigned *)0x14A00048) -#define rDITHMODE (*(volatile unsigned *)0x14A0004C) -#define rTPAL (*(volatile unsigned *)0x14A00050) -#define PALETTE (0x14A00400)/* SJS */ - - -/* UART */ -#define rULCON0 (*(volatile unsigned char *)0x15000000) -#define rUCON0 (*(volatile unsigned short *)0x15000004) -#define rUFCON0 (*(volatile unsigned char *)0x15000008) -#define rUMCON0 (*(volatile unsigned char *)0x1500000C) -#define rUTRSTAT0 (*(volatile unsigned char *)0x15000010) -#define rUERSTAT0 (*(volatile unsigned char *)0x15000014) -#define rUFSTAT0 (*(volatile unsigned short *)0x15000018) -#define rUMSTAT0 (*(volatile unsigned char *)0x1500001C) -#define rUBRDIV0 (*(volatile unsigned short *)0x15000028) - -#define rULCON1 (*(volatile unsigned char *)0x15004000) -#define rUCON1 (*(volatile unsigned short *)0x15004004) -#define rUFCON1 (*(volatile unsigned char *)0x15004008) -#define rUMCON1 (*(volatile unsigned char *)0x1500400C) -#define rUTRSTAT1 (*(volatile unsigned char *)0x15004010) -#define rUERSTAT1 (*(volatile unsigned char *)0x15004014) -#define rUFSTAT1 (*(volatile unsigned short *)0x15004018) -#define rUMSTAT1 (*(volatile unsigned char *)0x1500401C) -#define rUBRDIV1 (*(volatile unsigned short *)0x15004028) - -#ifdef __BIG_ENDIAN -#define rUTXH0 (*(volatile unsigned char *)0x15000023) -#define rURXH0 (*(volatile unsigned char *)0x15000027) -#define rUTXH1 (*(volatile unsigned char *)0x15004023) -#define rURXH1 (*(volatile unsigned char *)0x15004027) - -#define WrUTXH0 (ch) (*(volatile unsigned char *)0x15000023)=(unsigned char)(ch) -#define RdURXH0 () (*(volatile unsigned char *)0x15000027) -#define WrUTXH1 (ch) (*(volatile unsigned char *)0x15004023)=(unsigned char)(ch) -#define RdURXH1 () (*(volatile unsigned char *)0x15004027) - -#define UTXH0 (0x15000020+3)/* byte_access address by DMA */ -#define URXH0 (0x15000024+3) -#define UTXH1 (0x15004020+3) -#define URXH1 (0x15004024+3) - -#else /* Little Endian */ -#define rUTXH0 (*(volatile unsigned char *)0x15000020) -#define rURXH0 (*(volatile unsigned char *)0x15000024) -#define rUTXH1 (*(volatile unsigned char *)0x15004020) -#define rURXH1 (*(volatile unsigned char *)0x15004024) - -#define WrUTXH0 (ch) (*(volatile unsigned char *)0x15000020)=(unsigned char)(ch) -#define RdURXH0 () (*(volatile unsigned char *)0x15000024) -#define WrUTXH1 (ch) (*(volatile unsigned char *)0x15004020)=(unsigned char)(ch) -#define RdURXH1 () (*(volatile unsigned char *)0x15004024) - -#define UTXH0 (0x15000020)/* byte_access address by DMA */ -#define URXH0 (0x15000024) -#define UTXH1 (0x15004020) -#define URXH1 (0x15004024) -#endif - - -/* PWM TIMER */ -#define rTCFG0 (*(volatile unsigned *)0x15100000) -#define rTCFG1 (*(volatile unsigned *)0x15100004) -#define rTCON (*(volatile unsigned *)0x15100008) -#define rTCNTB0 (*(volatile unsigned *)0x1510000C) -#define rTCMPB0 (*(volatile unsigned *)0x15100010) -#define rTCNTO0 (*(volatile unsigned *)0x15100014) -#define rTCNTB1 (*(volatile unsigned *)0x15100018) -#define rTCMPB1 (*(volatile unsigned *)0x1510001C) -#define rTCNTO1 (*(volatile unsigned *)0x15100020) -#define rTCNTB2 (*(volatile unsigned *)0x15100024) -#define rTCMPB2 (*(volatile unsigned *)0x15100028) -#define rTCNTO2 (*(volatile unsigned *)0x1510002C) -#define rTCNTB3 (*(volatile unsigned *)0x15100030) -#define rTCMPB3 (*(volatile unsigned *)0x15100034) -#define rTCNTO3 (*(volatile unsigned *)0x15100038) -#define rTCNTB4 (*(volatile unsigned *)0x1510003C) -#define rTCNTO4 (*(volatile unsigned *)0x15100040) - - -/* USB DEVICE */ -#define rFUNC_ADDR_REG (*(volatile unsigned *)0x15200140) -#define rPWR_REG (*(volatile unsigned *)0x15200144) -#define rINT_REG (*(volatile unsigned *)0x15200148) -#define rINT_MASK_REG (*(volatile unsigned *)0x1520014C) -#define rFRAME_NUM_REG (*(volatile unsigned *)0x15200150) -#define rRESUME_CON_REG (*(volatile unsigned *)0x15200154) -#define rEP0_CSR (*(volatile unsigned *)0x15200160) -#define rEP0_MAXP (*(volatile unsigned *)0x15200164) -#define rEP0_OUT_CNT (*(volatile unsigned *)0x15200168) -#define rEP0_FIFO (*(volatile unsigned *)0x1520016C) -#define rEP1_IN_CSR (*(volatile unsigned *)0x15200180) -#define rEP1_IN_MAXP (*(volatile unsigned *)0x15200184) -#define rEP1_FIFO (*(volatile unsigned *)0x15200188) -#define rEP2_IN_CSR (*(volatile unsigned *)0x15200190) -#define rEP2_IN_MAXP (*(volatile unsigned *)0x15200194) -#define rEP2_FIFO (*(volatile unsigned *)0x15200198) -#define rEP3_OUT_CSR (*(volatile unsigned *)0x152001A0) -#define rEP3_OUT_MAXP (*(volatile unsigned *)0x152001A4) -#define rEP3_OUT_CNT (*(volatile unsigned *)0x152001A8) -#define rEP3_FIFO (*(volatile unsigned *)0x152001AC) -#define rEP4_OUT_CSR (*(volatile unsigned *)0x152001B0) -#define rEP4_OUT_MAXP (*(volatile unsigned *)0x152001B4) -#define rEP4_OUT_CNT (*(volatile unsigned *)0x152001B8) -#define rEP4_FIFO (*(volatile unsigned *)0x152001BC) -#define rDMA_CON (*(volatile unsigned *)0x152001C0) -#define rDMA_UNIT (*(volatile unsigned *)0x152001C4) -#define rDMA_FIFO (*(volatile unsigned *)0x152001C8) -#define rDMA_TX (*(volatile unsigned *)0x152001CC) -#define rTEST_MODE (*(volatile unsigned *)0x152001F4) -#define rIN_CON_REG (*(volatile unsigned *)0x152001F8) - - -/* WATCH DOG TIMER */ -#define rWTCON (*(volatile unsigned *)0x15300000) -#define rWTDAT (*(volatile unsigned *)0x15300004) -#define rWTCNT (*(volatile unsigned *)0x15300008) - - -/* IIC */ -#define rIICCON (*(volatile unsigned *)0x15400000) -#define rIICSTAT (*(volatile unsigned *)0x15400004) -#define rIICADD (*(volatile unsigned *)0x15400008) -#define rIICDS (*(volatile unsigned *)0x1540000C) - - -/* IIS */ -#define rIISCON (*(volatile unsigned *)0x15508000) -#define rIISMOD (*(volatile unsigned *)0x15508004) -#define rIISPSR (*(volatile unsigned *)0x15508008) -#define rIISFIFCON (*(volatile unsigned *)0x1550800C) - -#ifdef __BIG_ENDIAN -#define IISFIF ((volatile unsigned short *)0x15508012) - -#else /* Little Endian */ -#define IISFIF ((volatile unsigned short *)0x15508010) -#endif - - -/* I/O PORT */ -#define rPACON (*(volatile unsigned *)0x15600000) -#define rPADAT (*(volatile unsigned *)0x15600004) - -#define rPBCON (*(volatile unsigned *)0x15600008) -#define rPBDAT (*(volatile unsigned *)0x1560000C) -#define rPBUP (*(volatile unsigned *)0x15600010) - -#define rPCCON (*(volatile unsigned *)0x15600014) -#define rPCDAT (*(volatile unsigned *)0x15600018) -#define rPCUP (*(volatile unsigned *)0x1560001C) - -#define rPDCON (*(volatile unsigned *)0x15600020) -#define rPDDAT (*(volatile unsigned *)0x15600024) -#define rPDUP (*(volatile unsigned *)0x15600028) - -#define rPECON (*(volatile unsigned *)0x1560002C) -#define rPEDAT (*(volatile unsigned *)0x15600030) -#define rPEUP (*(volatile unsigned *)0x15600034) - -#define rPFCON (*(volatile unsigned *)0x15600038) -#define rPFDAT (*(volatile unsigned *)0x1560003C) -#define rPFUP (*(volatile unsigned *)0x15600040) - -#define rPGCON (*(volatile unsigned *)0x15600044) -#define rPGDAT (*(volatile unsigned *)0x15600048) -#define rPGUP (*(volatile unsigned *)0x1560004C) - -#define rOPENCR (*(volatile unsigned *)0x15600050) -#define rMISCCR (*(volatile unsigned *)0x15600054) -#define rEXTINT (*(volatile unsigned *)0x15600058) - - -/* RTC */ -#ifdef __BIG_ENDIAN -#define rRTCCON (*(volatile unsigned char *)0x15700043) -#define rRTCALM (*(volatile unsigned char *)0x15700053) -#define rALMSEC (*(volatile unsigned char *)0x15700057) -#define rALMMIN (*(volatile unsigned char *)0x1570005B) -#define rALMHOUR (*(volatile unsigned char *)0x1570005F) -#define rALMDAY (*(volatile unsigned char *)0x15700063) -#define rALMMON (*(volatile unsigned char *)0x15700067) -#define rALMYEAR (*(volatile unsigned char *)0x1570006B) -#define rRTCRST (*(volatile unsigned char *)0x1570006F) -#define rBCDSEC (*(volatile unsigned char *)0x15700073) -#define rBCDMIN (*(volatile unsigned char *)0x15700077) -#define rBCDHOUR (*(volatile unsigned char *)0x1570007B) -#define rBCDDAY (*(volatile unsigned char *)0x1570007F) -#define rBCDDATE (*(volatile unsigned char *)0x15700083) -#define rBCDMON (*(volatile unsigned char *)0x15700087) -#define rBCDYEAR (*(volatile unsigned char *)0x1570008B) -#define rTICINT (*(volatile unsigned char *)0x15700047) - -#else /* Little Endian */ -#define rRTCCON (*(volatile unsigned char *)0x15700040) -#define rRTCALM (*(volatile unsigned char *)0x15700050) -#define rALMSEC (*(volatile unsigned char *)0x15700054) -#define rALMMIN (*(volatile unsigned char *)0x15700058) -#define rALMHOUR (*(volatile unsigned char *)0x1570005C) -#define rALMDAY (*(volatile unsigned char *)0x15700060) -#define rALMMON (*(volatile unsigned char *)0x15700064) -#define rALMYEAR (*(volatile unsigned char *)0x15700068) -#define rRTCRST (*(volatile unsigned char *)0x1570006C) -#define rBCDSEC (*(volatile unsigned char *)0x15700070) -#define rBCDMIN (*(volatile unsigned char *)0x15700074) -#define rBCDHOUR (*(volatile unsigned char *)0x15700078) -#define rBCDDAY (*(volatile unsigned char *)0x1570007C) -#define rBCDDATE (*(volatile unsigned char *)0x15700080) -#define rBCDMON (*(volatile unsigned char *)0x15700084) -#define rBCDYEAR (*(volatile unsigned char *)0x15700088) -#define rTICINT (*(volatile unsigned char *)0x15700044) -#endif - - -/* ADC */ -#define rADCCON (*(volatile unsigned *)0x15800000) -#define rADCDAT (*(volatile unsigned *)0x15800004) - - -/* SPI */ -#define rSPCON (*(volatile unsigned *)0x15900000) -#define rSPSTA (*(volatile unsigned *)0x15900004) -#define rSPPIN (*(volatile unsigned *)0x15900008) -#define rSPPRE (*(volatile unsigned *)0x1590000C) -#define rSPTDAT (*(volatile unsigned *)0x15900010) -#define rSPRDAT (*(volatile unsigned *)0x15900014) - - -/* MMC INTERFACE */ -#define rMMCON (*(volatile unsigned *)0x15a00000) -#define rMMCRR (*(volatile unsigned *)0x15a00004) -#define rMMFCON (*(volatile unsigned *)0x15a00008) -#define rMMSTA (*(volatile unsigned *)0x15a0000C) -#define rMMFSTA (*(volatile unsigned *)0x15a00010) -#define rMMPRE (*(volatile unsigned *)0x15a00014) -#define rMMLEN (*(volatile unsigned *)0x15a00018) -#define rMMCR7 (*(volatile unsigned *)0x15a0001C) -#define rMMRSP0 (*(volatile unsigned *)0x15a00020) -#define rMMRSP1 (*(volatile unsigned *)0x15a00024) -#define rMMRSP2 (*(volatile unsigned *)0x15a00028) -#define rMMRSP3 (*(volatile unsigned *)0x15a0002C) -#define rMMCMD0 (*(volatile unsigned *)0x15a00030) -#define rMMCMD1 (*(volatile unsigned *)0x15a00034) -#define rMMCR16 (*(volatile unsigned *)0x15a00038) -#define rMMDAT (*(volatile unsigned *)0x15a0003C) - - -/* ISR */ -#define pISR_RESET (*(unsigned *)(_ISR_STARTADDRESS+0x0)) -#define pISR_UNDEF (*(unsigned *)(_ISR_STARTADDRESS+0x4)) -#define pISR_SWI (*(unsigned *)(_ISR_STARTADDRESS+0x8)) -#define pISR_PABORT (*(unsigned *)(_ISR_STARTADDRESS+0xC)) -#define pISR_DABORT (*(unsigned *)(_ISR_STARTADDRESS+0x10)) -#define pISR_RESERVED (*(unsigned *)(_ISR_STARTADDRESS+0x14)) -#define pISR_IRQ (*(unsigned *)(_ISR_STARTADDRESS+0x18)) -#define pISR_FIQ (*(unsigned *)(_ISR_STARTADDRESS+0x1C)) - -#define pISR_EINT0 (*(unsigned *)(_ISR_STARTADDRESS+0x20)) -#define pISR_EINT1 (*(unsigned *)(_ISR_STARTADDRESS+0x24)) -#define pISR_EINT2 (*(unsigned *)(_ISR_STARTADDRESS+0x28)) -#define pISR_EINT3 (*(unsigned *)(_ISR_STARTADDRESS+0x2C)) -#define pISR_EINT4 (*(unsigned *)(_ISR_STARTADDRESS+0x30)) -#define pISR_EINT5 (*(unsigned *)(_ISR_STARTADDRESS+0x34)) -#define pISR_EINT6 (*(unsigned *)(_ISR_STARTADDRESS+0x38)) -#define pISR_EINT7 (*(unsigned *)(_ISR_STARTADDRESS+0x3C)) -#define pISR_TICK (*(unsigned *)(_ISR_STARTADDRESS+0x40)) -#define pISR_WDT (*(unsigned *)(_ISR_STARTADDRESS+0x44)) -#define pISR_TIMER0 (*(unsigned *)(_ISR_STARTADDRESS+0x48)) -#define pISR_TIMER1 (*(unsigned *)(_ISR_STARTADDRESS+0x4C)) -#define pISR_TIMER2 (*(unsigned *)(_ISR_STARTADDRESS+0x50)) -#define pISR_TIMER3 (*(unsigned *)(_ISR_STARTADDRESS+0x54)) -#define pISR_TIMER4 (*(unsigned *)(_ISR_STARTADDRESS+0x58)) -#define pISR_UERR01 (*(unsigned *)(_ISR_STARTADDRESS+0x5C)) -#define pISR_NOTUSED (*(unsigned *)(_ISR_STARTADDRESS+0x60)) -#define pISR_DMA0 (*(unsigned *)(_ISR_STARTADDRESS+0x64)) -#define pISR_DMA1 (*(unsigned *)(_ISR_STARTADDRESS+0x68)) -#define pISR_DMA2 (*(unsigned *)(_ISR_STARTADDRESS+0x6C)) -#define pISR_DMA3 (*(unsigned *)(_ISR_STARTADDRESS+0x70)) -#define pISR_MMC (*(unsigned *)(_ISR_STARTADDRESS+0x74)) -#define pISR_SPI (*(unsigned *)(_ISR_STARTADDRESS+0x78)) -#define pISR_URXD0 (*(unsigned *)(_ISR_STARTADDRESS+0x7C)) -#define pISR_URXD1 (*(unsigned *)(_ISR_STARTADDRESS+0x80)) -#define pISR_USBD (*(unsigned *)(_ISR_STARTADDRESS+0x84)) -#define pISR_USBH (*(unsigned *)(_ISR_STARTADDRESS+0x88)) -#define pISR_IIC (*(unsigned *)(_ISR_STARTADDRESS+0x8C)) -#define pISR_UTXD0 (*(unsigned *)(_ISR_STARTADDRESS+0x90)) -#define pISR_UTXD1 (*(unsigned *)(_ISR_STARTADDRESS+0x94)) -#define pISR_RTC (*(unsigned *)(_ISR_STARTADDRESS+0x98)) -#define pISR_ADC (*(unsigned *)(_ISR_STARTADDRESS+0xA0)) - - -/* PENDING BIT */ -#define BIT_EINT0 (0x1) -#define BIT_EINT1 (0x1<<1) -#define BIT_EINT2 (0x1<<2) -#define BIT_EINT3 (0x1<<3) -#define BIT_EINT4 (0x1<<4) -#define BIT_EINT5 (0x1<<5) -#define BIT_EINT6 (0x1<<6) -#define BIT_EINT7 (0x1<<7) -#define BIT_TICK (0x1<<8) -#define BIT_WDT (0x1<<9) -#define BIT_TIMER0 (0x1<<10) -#define BIT_TIMER1 (0x1<<11) -#define BIT_TIMER2 (0x1<<12) -#define BIT_TIMER3 (0x1<<13) -#define BIT_TIMER4 (0x1<<14) -#define BIT_UERR01 (0x1<<15) -#define BIT_NOTUSED (0x1<<16) -#define BIT_DMA0 (0x1<<17) -#define BIT_DMA1 (0x1<<18) -#define BIT_DMA2 (0x1<<19) -#define BIT_DMA3 (0x1<<20) -#define BIT_MMC (0x1<<21) -#define BIT_SPI (0x1<<22) -#define BIT_URXD0 (0x1<<23) -#define BIT_URXD1 (0x1<<24) -#define BIT_USBD (0x1<<25) -#define BIT_USBH (0x1<<26) -#define BIT_IIC (0x1<<27) -#define BIT_UTXD0 (0x1<<28) -#define BIT_UTXD1 (0x1<<29) -#define BIT_RTC (0x1<<30) -#define BIT_ADC (0x1<<31) -#define BIT_ALLMSK (0xFFFFFFFF) - -#define ClearPending (bit) {\ - rSRCPND = bit;\ - rINTPND = bit;\ - rINTPND;\ - } -/* Wait until rINTPND is changed for the case that the ISR is very short. */ -#endif #endif /*__S3C2400_H__*/
include/s3c2410.h +38 -120
208 lines not on this page · raw message
include/s3c24x0.h +55 -540
787 lines not on this page · raw message
Signature · 1 line
1.6.1.2
[U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 2/7
Quoted 43 lines · kevin.morfitt at fearnside-systems.co.uk
This patch re-formats the s3c24x0 header files in preparation for changes to add support for the Embest SBC2440-II Board.
The changes are as follows:
- re-indent the code using Lindent
- make sure register layouts are defined using a C struct, from a comment by Wolfgang on 03/06/2009
- replace the upper-case typedef'ed C struct names with lower case non-typedef'ed ones, from a comment by Scott on 22/06/2009
- make sure registers are accessed using the proper accessor functions, from a comment by Wolfgang on 03/06/2009
- run checkpatch.pl and fix any error reportsSigned-off-by Kevin Morfitt <[email protected]>--- include/s3c2400.h | 493 ++++---------------------------------------- include/s3c2410.h | 158 ++++----------- include/s3c24x0.h | 595 +++++------------------------------------------------ 3 files changed, 130 insertions(+), 1116 deletions(-)include/s3c2400.h +3
-3@@ -35,12 +35,12 @@#define S3C24X0_SPI_CHANNELS 1#define PALETTE (0x14A00400)/* SJS */ -typedef enum { +enum s3c24x0_uarts_nr {S3C24X0_UART0 ,S3C24X0_UART1 , -}S3C24X0_UARTS_NR ; +}; -/* S3C2400 device base addresses */ +/*S3C2400 device base addresses */ #define S3C24X0_MEMCTL_BASE 0x14000000#define S3C24X0_USB_HOST_BASE 0x14200000#define S3C24X0_INTERRUPT_BASE 0x14400000
include/s3c2400.h typedef enum { · line 66
Quoted 5 lines
include/s3c2400.h +1
-1@@ -63,492 +63,73 @@ typedef enum {#include <s3c24x0.h> -static inline S3C24X0_MEMCTL *S3C24X0_GetBase_MEMCTL (void ) +static inline struct s3c24x0_memctl *S3C24X0_GetBase_MEMCTL (void )
please no uppercase in the function name
Quoted 10 lines
include/s3c2400.h +1
-1{ -return (S3C24X0_MEMCTL *const )S3C24X0_MEMCTL_BASE ; +return (struct s3c24x0_memctl *)S3C24X0_MEMCTL_BASE ; }include/s3c24x0.h +0
-0
include/s3c24x0.h typedef volatile u16 S3C24X0_REG16; · line 40
Quoted 6 lines
include/s3c24x0.h +1
-1@@ -36,18 +36,18 @@ typedef volatile u16 S3C24X0_REG16;typedef volatile u32 S3C24X0_REG32 ;/* Memory controller (see manual chapter 5) */ -typedef struct { +struct s3c24x0_memctl {S3C24X0_REG32 BWSCON;
please remove the S3C24X0_REG32
please use u32 or other proper type
please no uppercase in entry name too
include/s3c24x0.h typedef volatile u16 S3C24X0_REG16; · line 45
Quoted 5 lines
include/s3c24x0.h +0
-0S3C24X0_REG32 BANKCON [8 ];S3C24X0_REG32 REFRESH ;S3C24X0_REG32 BANKSIZE ;S3C24X0_REG32 MRSRB6 ;S3C24X0_REG32 MRSRB7 ;
Best Regards,
J.