Skip to contentSkip to conversation

Please pull u-boot-ubi

U-Boot Stefan Roese 3 participants 9 messages Jul 9, 2009

lore
Share & tools
lore
#0 lore raw

The following changes since commit a350d0d37d7c113afbd9b0d2cf60ac542007f9e6:
Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians

are available in the git repository at:

git://www.denx.de/git/u-boot-ubi.git master

Simon Kagstrom (1):
Handle VID header offset in ubi part command

 common/cmd_ubi.c |   21 ++++++++++++++++-----
 1 files changed, 16 insertions(+), 5 deletions(-)
#1 lore raw
Quoted 10 lines · On Thu, 9 Jul 2009 09:59:56 +0200 Stefan Roese <[email protected]> wrote:

The following changes since commit a350d0d37d7c113afbd9b0d2cf60ac542007f9e6:
Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians

are available in the git repository at:

git://www.denx.de/git/u-boot-ubi.git master

Simon Kagstrom (1):
Handle VID header offset in ubi part command

Thanks for applying this! However, I think the "[PATCH 8/8]: Command improvements for ubifs" patch should also be uncontroversial:

http://lists.denx.de/pipermail/u-boot/2009-July/055602.html

It's basically just a check for the number of arguments passed and a description of what the command does.

To use ubifs on ARM, I also need the rest of the patch series

http://lists.denx.de/pipermail/u-boot/2009-July/055594.html

but I haven't seen any comments on that so far.

// Simon

#2 lore raw
Quoted 11 lines · On Thursday 09 July 2009 10:16:11 Simon Kagstrom wrote:
Quoted 10 lines

The following changes since commit a350d0d37d7c113afbd9b0d2cf60ac542007f9e6: Wolfgang Denk (1):
Merge branch 'master' of /home/wd/git/u-boot/custodians

are available in the git repository at:

git://www.denx.de/git/u-boot-ubi.git master

Simon Kagstrom (1):
Handle VID header offset in ubi part command

Quoted 7 lines

Thanks for applying this! However, I think the "[PATCH 8/8]: Command improvements for ubifs" patch should also be uncontroversial:

http://lists.denx.de/pipermail/u-boot/2009-July/055602.html

It's basically just a check for the number of arguments passed and a description of what the command does.

Yes. And I already acked it on the list. Please note that I'm "only" the co- custodian for the UBI repository. We have no UBIFS custodian. So it needs to get into mainline via Wolfgang.

Quoted 5 lines

To use ubifs on ARM, I also need the rest of the patch series

   http://lists.denx.de/pipermail/u-boot/2009-July/055594.html

but I haven't seen any comments on that so far.

No comments doesn't have to be a bad sign. So nobody has something to complain about them. In fact I think your patches are good. So I'll probably send a few acked-by's soon.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#3 lore raw
Quoted 6 lines · On Thu, 9 Jul 2009 10:24:42 +0200 Stefan Roese <[email protected]> wrote:
Quoted 2 lines

Thanks for applying this! However, I think the "[PATCH 8/8]: Command improvements for ubifs" patch should also be uncontroversial:

Yes. And I already acked it on the list. Please note that I'm "only" the co- custodian for the UBI repository. We have no UBIFS custodian. So it needs to get into mainline via Wolfgang.

Ah, OK! I simply assumed UBI/UBIFS maintenance went together and that it simply got missed.

Quoted 9 lines
Quoted 5 lines

To use ubifs on ARM, I also need the rest of the patch series

   http://lists.denx.de/pipermail/u-boot/2009-July/055594.html

but I haven't seen any comments on that so far.

No comments doesn't have to be a bad sign. So nobody has something to complain about them. In fact I think your patches are good. So I'll probably send a few acked-by's soon.

Well my worry with the series is that it touches pretty much all architectures, which I haven't been able to test. So that is basically where I'd like some feedback.

// Simon

#4 lore raw
Quoted 6 lines · On Thursday 09 July 2009 10:32:02 Simon Kagstrom wrote:
Quoted 6 lines
Quoted 5 lines

To use ubifs on ARM, I also need the rest of the patch series

   http://lists.denx.de/pipermail/u-boot/2009-July/055594.html

but I haven't seen any comments on that so far.

Quoted 7 lines
Quoted 3 lines

No comments doesn't have to be a bad sign. So nobody has something to complain about them. In fact I think your patches are good. So I'll probably send a few acked-by's soon.

Well my worry with the series is that it touches pretty much all architectures, which I haven't been able to test. So that is basically where I'd like some feedback.

Unfortunately we don't have many boards in mainline U-Boot yet that include UBI/UBIFS till now. So problems in this area might get unnoticed right now.

Did you at least compile-test your patchset on some of the other architectures (PPC, MIPS...)?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#5 lore raw
Quoted 5 lines · On Thu, 9 Jul 2009 10:36:58 +0200 Stefan Roese <[email protected]> wrote:

Unfortunately we don't have many boards in mainline U-Boot yet that include UBI/UBIFS till now. So problems in this area might get unnoticed right now.

Did you at least compile-test your patchset on some of the other architectures (PPC, MIPS...)?

Well, the only other cross-compiler I had around is for powerpc. I built for the MPC8349ITX board, and that compiled just fine. But then again PPC already had ffs/fls.

// Simon

#6 lore raw
Quoted 6 lines · On Thursday 09 July 2009 10:49:47 Simon Kagstrom wrote:
Quoted 2 lines

Did you at least compile-test your patchset on some of the other architectures (PPC, MIPS...)?

Well, the only other cross-compiler I had around is for powerpc. I built for the MPC8349ITX board, and that compiled just fine. But then again PPC already had ffs/fls.

Well, that's a good sign then. You didn't break the PPC implementation with your patch. ;)

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#7 lore raw
In reply to Stefan Roese

Dear Stefan Roese,

Quoted 4 lines · In message <[email protected]> you wrote:

Yes. And I already acked it on the list. Please note that I'm "only" the co- custodian for the UBI repository. We have no UBIFS custodian. So it needs to get into mainline via Wolfgang.

I see UBIFS and UBI as one topic. Please run it through your UBI repo. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Experience is what causes a person to make new  mistakes  instead  of
old ones.
#8 lore raw
Quoted 6 lines · On Thursday 09 July 2009 12:05:31 Wolfgang Denk wrote:
Quoted 3 lines

Yes. And I already acked it on the list. Please note that I'm "only" the co- custodian for the UBI repository. We have no UBIFS custodian. So it needs to get into mainline via Wolfgang.

I see UBIFS and UBI as one topic. Please run it through your UBI repo. Thanks.

So I'm promoted from UBI co-custodian to UBIFS custodian? ;)

OK, I'll try to take care of UBIFS related patches for now. Will send an updated ubi/ubifs pull request soon.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================