Skip to contentSkip to conversation

don't add i2c_imx_driver's probe function to the driver struct

PATCH New Wolfram Sang 3 participants 3 messages Jul 12, 2009 – Jul 15, 2009 4 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 1247428431-27315-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org

Wolfram Sang

author Acked-by
#2 lore raw
Quoted 10 lines · Uwe Kleine-König

i2c_imx_driver is registered using platform_driver_probe which takes care for the probe function itself. So don't pass it in the driver struct, too.

Cc Sascha Hauer <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Darius Augulis <[email protected]>
Cc Ben Dooks <[email protected]>

Adding linux-i2c to CC...

Quoted 19 lines
---
 drivers/i2c/busses/i2c-imx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-imx.c +0 -1
index 0b486a6..b7a0ac7 100644
@@ -597,7 +597,6 @@ static int __exit i2c_imx_remove(struct platform_device *pdev)
 }
 
 static struct platform_driver i2c_imx_driver = {
-	.probe		= i2c_imx_probe,
 	.remove		= __exit_p(i2c_imx_remove),
 	.driver	= {
 		.name	= DRIVER_NAME,
Signature · 1 line
1.6.3.1
Signature · 2 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 11 lines · Wolfram Sang
Quoted 9 lines · Uwe Kleine-K?nig

i2c_imx_driver is registered using platform_driver_probe which takes care for the probe function itself. So don't pass it in the driver struct, too.

Cc Sascha Hauer <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Darius Augulis <[email protected]>
Cc Ben Dooks <[email protected]>
Quoted 3 lines

Adding linux-i2c to CC...

Can I have the original to apply please?

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

PATCH 1/1 don't add i2c_imx_driver's probe function to the driver struct

i2c_imx_driver is registered using platform_driver_probe which takes care for the probe function itself. So don't pass it in the driver struct, too.

Cc Sascha Hauer <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Darius Augulis <[email protected]>
Cc Ben Dooks <[email protected]>

---
Hi Ben,

Quoted 12 lines · Ben Dooks
Quoted 11 lines · Wolfram Sang
Quoted 9 lines · Uwe Kleine-K?nig

i2c_imx_driver is registered using platform_driver_probe which takes care for the probe function itself. So don't pass it in the driver struct, too.

Cc Sascha Hauer <[email protected]>
Cc Wolfram Sang <[email protected]>
Cc Guennadi Liakhovetski <[email protected]>
Cc Darius Augulis <[email protected]>
Cc Ben Dooks <[email protected]>
Quoted 5 lines
Quoted 3 lines

Adding linux-i2c to CC...

Can I have the original to apply please?

hhhhmm? According to my sent mail folder you got a Cc of the original mail. Anyhow, here it comes again. The only difference to the first post is that Wolfram's Cc: became an Acked-by:

Best regards
Uwe

 drivers/i2c/busses/i2c-imx.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-imx.c +0 -1
index 0b486a6..b7a0ac7 100644
@@ -597,7 +597,6 @@ static int __exit i2c_imx_remove(struct platform_device *pdev)
 }
 
 static struct platform_driver i2c_imx_driver = {
-	.probe		= i2c_imx_probe,
 	.remove		= __exit_p(i2c_imx_remove),
 	.driver	= {
 		.name	= DRIVER_NAME,
Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |