Skip to contentSkip to conversation

fixes a dangerous typo

PATCH New Wengang Wang 2 participants 3 messages Jul 13, 2009 – Jul 21, 2009 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fixes a dangerous typo

---
 fs/ocfs2/aops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/aops.c +1 -1
index b730010..a10c989 100644
@@ -1397,7 +1397,7 @@ static int ocfs2_write_cluster(struct address_space *mapping,
 		if (tmpret) {
 			mlog_errno(tmpret);
 			if (ret == 0)
-				tmpret = ret;
+				ret = tmpret;
 		}
 	}
 
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/1 fixes a dangerous typo

Quoted 1 line · Wengang Wang

This change is in the fixes branch of ocfs2.git. However, in the future, the commit message needs more information. The commit message above doesn't even mention what the dangerous typo is. Someone reading the message wouldn't know what had changed at all.

I've fixed the message, but in the future please try to be descriptive.

Joel

Signature · 9 lines
"Practice random acts of kindness and senseless acts of beauty."

 Oh, and don't forget where your towel is.

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
#2 lore raw

PATCH 1/1 fixes a dangerous typo

Ok, I will be descriptive for posts in the future.

regards,
wengang.

Quoted 11 lines · Joel Becker
Quoted 1 line · Wengang Wang

This change is in the fixes branch of ocfs2.git. However, in the future, the commit message needs more information. The commit message above doesn't even mention what the dangerous typo is. Someone reading the message wouldn't know what had changed at all.

I've fixed the message, but in the future please try to be descriptive.

Joel