ath5k: temporarily disable crypto for AP mode
PATCH 1/1 ath5k: temporarily disable crypto for AP mode
Pavel Roskin reported some issues with using AP mode without nohwcrypt=1. Most likely this is similar to the problem fixed some time ago in ath9k by 3f53dd64f192450cb331c0fecfc26ca952fb242f, "ath9k: Fix hw crypto configuration for TKIP in AP mode."
That only affects TKIP but it's easiest to just disable that and WEP too until we get a proper fix in.
---
Pavel, this ok with you for now?
drivers/net/wireless/ath/ath5k/base.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/wireless/ath/ath5k/base.c +3 -0
@@ -2980,6 +2980,9 @@ ath5k_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,if (modparam_nohwcrypt)return -EOPNOTSUPP ; +if (sc->opmode ==NL80211_IFTYPE_AP ) +return -EOPNOTSUPP ; +switch (key->alg) {case ALG_WEP :case ALG_TKIP :
Signature · 4 lines
1.6.2.5 -- Bob Copeland %% www.bobcopeland.com
Quoted 5 lines · Bob Copeland
Pavel Roskin reported some issues with using AP mode without nohwcrypt=1. Most likely this is similar to the problem fixed some time ago in ath9k by
3f53dd64f192450cb331c0fecfc26ca952fb242f, "ath9k: Fix hw crypto configuration for TKIP in AP mode."
Quoted 7 lines
That only affects TKIP but it's easiest to just disable that and WEP too until we get a proper fix in.
Signed-off-by Bob Copeland <[email protected]>---
Pavel, this ok with you for now?
Sorry for delay. I don't have time to test it, but I have no specific objections.
Signature · 2 lines
Regards, Pavel Roskin
Quoted 5 lines · Pavel Roskin
Quoted 2 lines
Pavel, this ok with you for now?
Sorry for delay. I don't have time to test it, but I have no specific objections.
Thanks, for the update. It already went to Linus I believe.
I did spend enough time looking at the root problem to decide that fixing it won't be too hard, but I also saw some questionable logic in the original code that wants a cleanup, I can post patches soon.
Signature · 1 line
Bob Copeland %% www.bobcopeland.com