sparc64: build compressed image (zImage) by default

From: Jurij Smakov <[email protected]>
Subject: sparc64: build compressed image (zImage) by default

Besides creating the uncompressed vmlinux image for sparc64, also create a compressed zImage. This is more consistent with other architectures and required to make the 'deb-pkg' target work.

---
The patch was taken from the Debian kernel package. It was written by Jurij. I added his Signed-off-by with his permission.

The patch was tested to work during my recent tests for the cmd64x issue.

index 2003ded..2adc5ea 100644
@@ -91,6 +91,9 @@ endif
 
 boot := arch/sparc/boot
 
+# Default target
+all: zImage
+
 image zImage tftpboot.img vmlinux.aout: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 

index 1ff0fd9..97e3feb 100644
@@ -79,6 +79,9 @@ $(obj)/image: vmlinux FORCE
 	$(call if_changed,strip)
 	@echo '  kernel: $@ is ready'
 
+$(obj)/zImage: $(obj)/image
+	$(call if_changed,gzip)
+
 $(obj)/tftpboot.img: $(obj)/image $(obj)/piggyback_64 System.map $(ROOT_IMG) FORCE
 	$(call if_changed,elftoaout)
 	$(call if_changed,piggy)

Hmmm..
This path does the following:
1) zImage becomes default for sparc and sparc64
2) fixes zImage on sparc64 (it dod not work before)
3) On sparc zImage is a stripped version of vmlinux, on sparc64 it is a gzipped not-stripped version of vmlinux - so it introduces a significantly different zImage.

Could we agree on the _same_ format for zImage on sparc and sparc64 and then apply that patch?

I know Julian is working on unifying piggyback_{32,64}.c so maybe that is covered by his work?

If we fix it so zImage is the same thing on sparc and sparc64 this could go in before we see the unification of piggyback.
For deb-pkg to work we could just let the sparc64 version be a stripped version - no? Then you would have covered my main complaint about this patch.

Sam

I have been fiddling with that, but time is been at a premium at the moment.

I don't believe that changes to the zImage / vmlinux targets will affect this as the tftpboot code uses the uncompressed (I believe) "Image" target.

Thanks,

Julian Calaby

Email: [email protected]
.Plan: http://sites.google.com/site/juliancalaby/

If I read arch/sparc/boot/Makefile correctly then the sparc64 image _is_ stripped as the zImage target calls $(obj)/image which does the strip. So the difference is less than you suggest.

I vaguely recall from Debian work that loading compressed kernels caused problems on sparc32 hardware (due to insufficient memory?), which could justify the difference. But I may be wrong.

Cheers,
FJP

From: Frans Pop <[email protected]>
Date: Wed, 22 Jul 2009 19:07:39 +0200

This is, unfortunately, very likely true.

It's in my queue you don't need to resend this:

http://patchwork.ozlabs.org/patch/29268/

OK, thanks. I did not see any ack on my mail so I was not aware you'd already picked it up.

The zImage target was added and gets built by default.

---

While looking at Sam Ravnborg's comments I noticed that the following should be added on top of Jurij's patch.

David: if you prefer to merge this into the previous patch, that'd be fine by me.

index 2adc5ea..b588880 100644
@@ -112,8 +112,9 @@ define archhelp
 endef
 else
 define archhelp
-  echo  '* vmlinux       - Standard sparc64 kernel'
-  echo  '  vmlinux.aout  - a.out kernel for sparc64'
+  echo  '* vmlinux      - standard sparc64 kernel'
+  echo  '* zImage       - stripped and compressed sparc64 kernel ($(boot)/zImage)'
+  echo  '  vmlinux.aout - a.out kernel for sparc64'
   echo  '  tftpboot.img - image prepared for tftp'
 endef
 endif

From: Frans Pop <[email protected]>
Date: Thu, 23 Jul 2009 20:55:18 +0200

I merged it into the sparc64 zImage patch, thanks!