ppc: Fix compile error for boards with CONFIG_DDR_ECC
PATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
A bug was introduced by commit e94e460c6e8741f42dab6d8dd4b596ba5d9d79ae which affected non-MPC83xx/85xx/86xx ppc boards which had CONFIG_DDR_ECC defined and resulted in errors such as:
Configuring for canyonlands board...
fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor"
make[1]: *** No rule to make target .depend', needed by libdma.a'. Stop.
--- include/asm-ppc/config.h | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
include/asm-ppc/config.h +5 -4
@@ -29,10 +29,11 @@#endif #endif -#ifndef CONFIG_FSL_DMA -#if ((!defined CONFIG_MPC83xx && defined(CONFIG_DDR_ECC ) && \ - !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER )) || \ - (defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA ))) +/* Check if boards need to enable FSL DMA engine for SDRAM init */ +#if !defined(CONFIG_FSL_DMA ) && defined(CONFIG_DDR_ECC ) +#if (defined(CONFIG_MPC83xx) && defined(CONFIG_DDR_ECC_INIT_VIA_DMA )) || \ + ((defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)) && \ + !defined(CONFIG_ECC_INIT_VIA_DDRCONTROLLER ))#define CONFIG_FSL_DMA #endif #endif
Signature · 1 line
1.6.2.1
PATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
Quoted 10 lines · On Wednesday 15 July 2009 07:01:08 Peter Tyser wrote:
A bug was introduced by commit
e94e460c6e8741f42dab6d8dd4b596ba5d9d79aewhich affected non-MPC83xx/85xx/86xx ppc boards which hadCONFIG_DDR_ECCdefined and resulted in errors such as:Configuring for canyonlands board...
fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor"
make[1]: *** No rule to make target.depend', needed bylibdma.a'. Stop.Signed-off-by Peter Tyser <[email protected]>
Thanks Peter.
Wolfgang, I suggest that you pull this patch directly so that the breakage is fixed.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
Dear Stefan Roese,
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 9 lines · On Wednesday 15 July 2009 07:01:08 Peter Tyser wrote:
A bug was introduced by commit
e94e460c6e8741f42dab6d8dd4b596ba5d9d79aewhich affected non-MPC83xx/85xx/86xx ppc boards which hadCONFIG_DDR_ECCdefined and resulted in errors such as:Configuring for canyonlands board...
fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor"
make[1]: *** No rule to make target.depend', needed bylibdma.a'. Stop.
Quoted 6 lines
Quoted 1 line
Signed-off-by Peter Tyser <[email protected]>Thanks Peter.
Wolfgang, I suggest that you pull this patch directly so that the breakage is fixed.
Done.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I'm a soldier, not a diplomat. I can only tell the truth. -- Kirk, "Errand of Mercy", stardate 3198.9
PATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
Hi Wolfgang,
Quoted 10 lines · On Friday 17 July 2009 23:45:02 Wolfgang Denk wrote:
Quoted 10 lines
Quoted 10 lines
A bug was introduced by commit
e94e460c6e8741f42dab6d8dd4b596ba5d9d79aewhich affected non-MPC83xx/85xx/86xx ppc boards which hadCONFIG_DDR_ECCdefined and resulted in errors such as:Configuring for canyonlands board...
fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor"
make[1]: *** No rule to make target.depend', needed bylibdma.a'. Stop.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Peter Tyser <[email protected]>Thanks Peter.
Wolfgang, I suggest that you pull this patch directly so that the breakage is fixed.
Done.
This patch is still not available in mainline.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
Dear Stefan Roese,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 5 lines
Quoted 3 lines
Wolfgang, I suggest that you pull this patch directly so that the breakage is fixed.
Done.
This patch is still not available in mainline.
Should be visible now. I forgot to push my changes out to the public server (you should have been able to see it on pollux, though).
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
History is only a confused heap of facts.
-- Philip Earl of ChesterfieldWolfgang Denk
AppliedPATCH 1/1 ppc: Fix compile error for boards with CONFIG_DDR_ECC
In reply to Peter TyserDear Peter Tyser,
Quoted 9 lines · In message <[email protected]> you wrote:
A bug was introduced by commit
e94e460c6e8741f42dab6d8dd4b596ba5d9d79aewhich affected non-MPC83xx/85xx/86xx ppc boards which hadCONFIG_DDR_ECCdefined and resulted in errors such as:Configuring for canyonlands board...
fsl_dma.c:50:2: error: #error "Freescale DMA engine not supported on your processor"
make[1]: *** No rule to make target.depend', needed bylibdma.a'. Stop.
Quoted 4 lines
Signed-off-by Peter Tyser <[email protected]>--- include/asm-ppc/config.h | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Heavier than air flying machines are impossible.
-- Lord Kelvin, President, Royal Society, c. 1895